Help Little Help With Captcha Code

[b0rto]

hello Mxc i need some help from who understands java since i'm a bit noob as you can see and i'll go crazy, i made a antibot captcha by levels of punishment and i have tried using these pieces of code to put a config to look for items in the player's inventory and if you have to delete them, but i get 5000 errors in the server console after the system try to delete the items.

 

this is the config.java:

			ANTIBOT_3_LEVEL_LISTITEMS_REMOVE = L2JModSettings.getBoolean("AntiBotLevel3ListItemsRemove", true);
			String[] AntibotRemoveItems = L2JModSettings.getString("AntibotRemoveItems", "").split(",");
			ANTIBOT_REMOVE_ITEMS_LIST = new ArrayList<>(AntibotRemoveItems.length);
			for (String id : AntibotRemoveItems)
			{
				ANTIBOT_REMOVE_ITEMS_LIST.add(Integer.parseInt(id));
			}

this is my antibot file ( piece of code):

					if (Config.ANTIBOT_3_LEVEL_LISTITEMS_REMOVE)
					{
						for (L2ItemInstance item : player.getInventory().getAllItemsByItemId2(Config.ANTIBOT_REMOVE_ITEMS_LIST))
						{
							if (item != null)
							{
								player.getInventory().destroyItem("Anti Bot", item, player, player);
							}
						}
						
					}
					
					break;

and this is the method that i created in pcinventory.java to check the list...:

	/**
	 * @param ANTIBOT_REMOVE_ITEMS_LIST
	 * @return
	 */
	public L2ItemInstance[] getAllItemsByItemId2(List<Integer> ANTIBOT_REMOVE_ITEMS_LIST)
	{
		return getAllItemsByItemId2(ANTIBOT_REMOVE_ITEMS_LIST);
	}

and this is the config.ini:

# Remove the list of items listed below on third level punishment?
AntiBotLevel3ListItemsRemove = True

# Remove the list of items listed below on third level punishment
# Example 6673,3470 (festival adena, gold bars)
AntibotRemoveItems = 6673,3470

i am getting the errors in the method getAllItemsByItemId2() , if someone can give me a hand 's take will be thankful ,thanks in advance.

Edited March 30, 2016 by b0rto

[Tryskell]

Your method is calling itself, leading to a permanent loop (server processes it until it ends into a stackoverflow).

 

What you want to do is to loop over all items (generic existing method), retrieve their ids and compare id with whatever id from the list (I added ArrayUtil.contains for such case on aCis, dunno if you got a similar thing on whatever project you use). If it's positive, you delete the item.

 

Take inspiration from "castle circlet removal" custom.

Edited March 30, 2016 by Tryskell

[b0rto]

thanks for your fast reply, i will try this.