Jump to content
  • 0

No Karma After Pk


improved
 Share

Question

Hi,

I have faced a problem when installed custom server modification called: Pvp Rank System (By Masterio).

I'v managed to fix my errors and problems (since that mod is outdated) and launched it on my server - everything would look fine except 1 thing:

 

InGame: When any kind of Character PKs (Kills innocent) another player - he gets no PK, no karma, no nick color change (as it should be as karma).

Ofc it's becouse of this mod i'v added, but maybe any1 could suggest how i could reenable normal PK mode without deleting Masterio's Pvp Rank System?

 

Maybe some1 knows the pk/karma correct code(full)? And where i should add it? Since it looks this mode is ignoring L2PcInstance's karma rules becouse it starts in L2PcInstance (7000+) before it begins (karma rules begins 8000+)...

 

Masterio's system:


 

P.S.

Posted this message here and on l2jserver since this pack was based on that server pack, i hope some1 will give me some answers - im desperate

Edited by improved
Link to comment
Share on other sites

3 answers to this question

Recommended Posts

  • 0

Would be nice if you post here what have you changed on your L2PcInstance.

 

Also, search for key word setKarma( and see if there is any code regarding the pvp system.

Edited by SweeTs
Link to comment
Share on other sites

  • 0

Well i could attach my L2PcInstance, but since it has about 20000 lines ... and it weights more kb than i could attach nothing i can do to show you full of it

And the code i'v added is:

Index: head-src/com/l2jfrozen/gameserver/model/actor/instance/L2PcInstance.java
===================================================================
--- head-src/com/l2jfrozen/gameserver/model/actor/instance/L2PcInstance.java	(revision 1004)
+++ head-src/com/l2jfrozen/gameserver/model/actor/instance/L2PcInstance.java	(working copy)
@@ -92,6 +92,8 @@
 import com.l2jfrozen.gameserver.managers.QuestManager;
 import com.l2jfrozen.gameserver.managers.SiegeManager;
 import com.l2jfrozen.gameserver.managers.TownManager;
+import com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.RankPvpSystemConfig;
+import com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.RankPvpSystemPc;
 import com.l2jfrozen.gameserver.model.BlockList;
 import com.l2jfrozen.gameserver.model.FishData;
 import com.l2jfrozen.gameserver.model.Inventory;
@@ -927,6 +929,10 @@
 	/** The _no duel reason. */
 	private SystemMessageId _noDuelReason = SystemMessageId.THERE_IS_NO_OPPONENT_TO_RECEIVE_YOUR_CHALLENGE_FOR_A_DUEL;
 
+	// Rank PvP System by Masterio
+	private RankPvpSystemPc _rankPvpSystemPc = new RankPvpSystemPc();
+	public RankPvpSystemPc getRankPvpSystemPc(){ return _rankPvpSystemPc; }
+	
 	/** Boat. */
 	private boolean _inBoat;
 	
@@ -7984,6 +7990,9 @@
 	 */
 	public void onKillUpdatePvPKarma(L2Character target)
 	{
+		// Rank PvP System by Masterio
+		_rankPvpSystemPc.runPvpTask(this, target);
+
 		if (target == null)
 			return;
 		
@@ -8295,8 +8304,10 @@
 			return;
 		
 		// Add karma to attacker and increase its PK counter
-		setPvpKills(getPvpKills() + 1);
-
+		// Rank PvP System by Masterio
+		if(!RankPvpSystemConfig.LEGAL_COUNTER_ALTT_ENABLED)
+			setPvpKills(getPvpKills() + 1);
+	
 		 // Increase the kill count for a special hero aura
 		 heroConsecutiveKillCount++;
 		

Its implemented before the PK system (Pk system starts few hundred lines after it). // Add karma to attacker and increase its PK counter - ignore this - its location is in PVP rules.

And after i add this masterio pvp rank system it looks like it overrides (ignores) default l2j pvp system. Even PVP counter in Alt+T is different. So it's in that custom system's code.

 

As i think - i should add pk karma system manually into that new masterio system codes, but i dunno how full of that code should look like since in l2pcinstance there is too many meanings... I'v tried to track it - not succeded.

 

If you really know how to help me, and you really want to - i can send you any of files you need. Believe me - i added that masterio pvp rank system correctly.

Edited by improved
Link to comment
Share on other sites

  • 0

All i get when i try to PK a player is a message, wich comes from masterio pvp rank system:

	private boolean checkRewardProtections(Pvp pvp)
	{
		// if PK mode is disabled:
		if(!RankPvpSystemConfig.REWARD_FOR_INNOCENT_KILL_ENABLED && _victim.getPvpFlag() == 0 && _victim.getKarma() == 0)
		{
			_killer.sendMessage("You can't earn rewards/rank on innocent players!");
			return false;
		}

I just get purple nick (like in pvp) the victim dies and the killer stays like he's innocent.

I think i could add somewhere here in theese lines full pk/karma code and it should work fine.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock