Jump to content
  • 0

Save Votes On Database


Question

Posted

Hello , Im tryning to make vote systems save the votes into the database , and load them after restart

 

topzone system

package com.l2jserver.gameserver.instancemanager;
    
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.net.URL;
import java.net.URLConnection;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;

import com.l2jserver.Config;
import com.l2jserver.L2DatabaseFactory;
import com.l2jserver.gameserver.ThreadPoolManager;
import com.l2jserver.gameserver.model.L2World;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
import com.l2jserver.gameserver.network.clientpackets.Say2;
import com.l2jserver.gameserver.network.serverpackets.CreatureSay;
import com.l2jserver.gameserver.network.serverpackets.ExShowScreenMessage;
import com.l2jserver.gameserver.util.Broadcast;
    
public class TzVoteRewardManager
{
   private static Logger _log = Logger.getLogger(TzVoteRewardManager.class.getName());
       
   private static final String http = Config.TOPZONE_URL;
   private static final int initialCheck  = 1 * 1000;
   private static final int delayForCheck = 10 * 60000;
   private static final int itemId    = Config.TOPZONE_REWARD_ID ;
   private static final int itemCount = Config.TOPZONE_REWARD_COUNT ;
   private static final int votesRequiredForReward = 10;

   private static List<String> _ips = new ArrayList<String>();
   private static int lastVoteCount = 0;
      
   private TzVoteRewardManager()
   {
	   if(!Config.ENABLE_TOPZONE)
		   return;
	   _log.info("----------------------------------------------------");
       _log.info("AutoVoteRewardManager: Vote reward system For TZ initiated.");
       _log.info("----------------------------------------------------");
           load();  
       ThreadPoolManager.getInstance().scheduleGeneralAtFixedRate(new AutoReward(), initialCheck, delayForCheck);
   }
      
   private class AutoReward implements Runnable
   {
       public void run()
       {
           int votes = getVotes();
           _log.info("AutoVoteRewardManager For TZ : We now have " + votes + "/"+(getLastVoteCount()+votesRequiredForReward)+" vote(s). Next check in "+(delayForCheck/1000)+" sec.");

           if (votes >= getLastVoteCount() + votesRequiredForReward)
           {
               Collection<L2PcInstance> pls = L2World.getInstance().getAllPlayers().values();
               {
                   for (L2PcInstance onlinePlayer : pls)
                   {
                       if (onlinePlayer.isOnline() && !onlinePlayer.getClient().isDetached() && !_ips.contains(onlinePlayer.getClient().getConnection().getInetAddress().getHostAddress()))
                       {
                              _log.warning("Hello Moto!Giving reward to character "+onlinePlayer.getName());
                               onlinePlayer.addItem("vote_reward", itemId, itemCount, onlinePlayer, true);
                               onlinePlayer.sendPacket(new ExShowScreenMessage("You Have bean Rewarded For topzone votes!", 5000));
                               onlinePlayer.sendPacket(new CreatureSay(1, Say2.PARTY, "SYSTEM", "You Have bean Rewarded For topzone votes!"));
                           _ips.add(onlinePlayer.getClient().getConnection().getInetAddress().getHostAddress());
                       }
                   }
               }
               _log.info("AutoVoteRewardManager: Reward for votes now!");
               Broadcast.toAllOnlinePlayers(new CreatureSay(1, Say2.CRITICAL_ANNOUNCE, "SYSTEM", "Topzone SYSTEM:" + " Thanks For Vote You Have Been Rewarded!"));
               setLastVoteCount(getLastVoteCount() + votesRequiredForReward);
           }
                
           if (getLastVoteCount() == 0)
           {
               setLastVoteCount(votes);
           }
           else if ((getLastVoteCount() + votesRequiredForReward) - votes > votesRequiredForReward || votes > (getLastVoteCount() + votesRequiredForReward))
           {
               setLastVoteCount(votes);
           }
              
           Broadcast.toAllOnlinePlayers(new CreatureSay(1, Say2.CRITICAL_ANNOUNCE, "SYSTEM", "Topzone SYSTEM:" + " We have " + votes + " Vote(s). || Next Reward On " + (getLastVoteCount()+votesRequiredForReward) + " Votes."));
           _ips.clear();
       }
   }
      
   private int getVotes()
   {
       URL url = null;
       InputStreamReader isr = null;
       BufferedReader in = null;
       try
       {
           url = new URL(http);
           URLConnection con = url.openConnection();
           con.addRequestProperty("User-Agent", "Mozilla/4.76"); 
           isr = new InputStreamReader(con.getInputStream());
           in = new BufferedReader(isr);
           String inputLine;
           while ((inputLine = in.readLine()) != null)
           {
               // for top-zone
        	   if (inputLine.contains("Votes:"))
        	   {
        	    	  return  Integer.parseInt(inputLine.split(">")[3].replace("</div", ""));
        	      }
           }
       }
       catch (IOException e)
       {
           _log.warning("AutoVoteRewardHandler: "+e);
       }
       finally
       {
           try
           {
               in.close();
           }
           catch (IOException e)
           {}
           try
           {
               isr.close();
           }
           catch (IOException e)
           {}
       }
       return 0;
   }
      
   private void setLastVoteCount(int voteCount)
   {
       lastVoteCount = voteCount;
   }
      
   private static int getLastVoteCount()
   {
       return lastVoteCount;
   }
   
   private void load()
     {
         int votes = 0;
         Connection con = null;
         try
         {
             con = L2DatabaseFactory.getInstance().getConnection();
             PreparedStatement statement = con.prepareStatement("SELECT vote FROM votes LIMIT 1");
             ResultSet rset = statement.executeQuery();
   
             while (rset.next())
             {
                 votes = rset.getInt("vote");
             }
             rset.close();
             statement.close();
         }
         catch (Exception e)
         {
             _log.log(Level.WARNING, "data error on vote: ", e);
         }
         finally
         {
             L2DatabaseFactory.close(con);
         }
         
         setLastVoteCount(votes);
     }
     
     public void save()
     {
         Connection con = null;
         try
         {
             con = L2DatabaseFactory.getInstance().getConnection();
             PreparedStatement statement = con.prepareStatement("UPDATE votes SET vote = ? WHERE id=1");
             statement.setInt(1, getLastVoteCount());
             statement.execute();
             statement.close();
         }
         catch (Exception e)
         {
             _log.log(Level.WARNING, "data error on vote: ", e);
         }
         finally
         {
             L2DatabaseFactory.close(con);
         }
     }
  
   public static TzVoteRewardManager getInstance()
   {
       return SingletonHolder._instance;
   }
      
   @SuppressWarnings("synthetic-access")
   private static class SingletonHolder
   {
       protected static final TzVoteRewardManager _instance = new TzVoteRewardManager();
   }
}

shutdown.java

		TzVoteRewardManager.getInstance().save();
		_log.info("Vote Reward Manager TZ: Data saved For Topzone.");

votes.sql

-- ----------------------------
-- Table structure for votes
-- ----------------------------
DROP TABLE IF EXISTS `votes`;
CREATE TABLE `votes` (
  `id` int(6) NOT NULL,
  `vote` int(6) NOT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

-- ----------------------------
-- Records of votes
-- ----------------------------

when server restarting i can see the msg ive add about saving.. but does not saving really :P Kinda strange .. any idea? No errors at all , system is working , rewards for all , ip check etc , just not saving like ti should..

12 answers to this question

Recommended Posts

  • 0
Posted

Not exactly. If the table is completely empty, obviously there's nothing to UPDATE.

his table hasn't been empty any time so the problem is not there.
  • 0
Posted (edited)

Its outdated, plus can be work for topzone + hopzone + reward ? or i have to make 2 different instaces , so i can have both running? And i dont see ip protection :/

 

And one more , This one need same database for gameserver and login.. I want seperated .. its really stupid to merge databases for many ressons !

Edited by ČυяŞŀŅğ
  • 0
Posted (edited)

oh i got this 

http://imageshack.us/f/203/tkmu.jpg/

 

29090 was the votes of the one site , this means votes () can see the votes.. So the only poblem is writing this into the sql right? and load after

 

 

edit , i checked load , its working , i write it manualy inside database , id 1 and votes 40000 , and when server loaded i saw next reward at 40010.

Edited by ČυяŞŀŅğ
  • 0
Posted (edited)

You are missing INSERT statement. Your save() method is incorrect.

 

You can do it with 2 ways, either way is fine (save() method):

1) First DELETE the entire table and then INSERT the votes.

2) Make a boolean on load() to see if votes exist or not**. If boolean is false, use INSERT statement, if boolean is true, use UPDATE statement.

 

Also that id field is completely unnecessary.

 

** You can do that, by going to load() method and add the boolean to this line:

while (rset.next())
{
    _votesRegistered = true;
    votes = rset.getInt("vote");
}

Also change while (rset.next()) to if (rset.next()), a loop there is also not necessary.

Edited by Versus
  • 0
Posted

Btw , this code was working before , i just changed the names from getting and loading from database from votes , to votetz etc , because i made 2 similar system to work together.. and samewere there i lost it i guess.. anyway :) I need You to explain this in noob language

     public void save()
     {
         Connection con = null;
         try
         {
             con = L2DatabaseFactory.getInstance().getConnection();
             PreparedStatement statement = con.prepareStatement("UPDATE votes SET vote = ? ");
             statement.setInt(1, getLastVoteCount());
             statement.execute();
             statement.close();
             System.out.println(getLastVoteCount()); 
         }
         catch (Exception e)
         {
             _log.log(Level.WARNING, "data error on vote: ", e);
         }
         finally
         {
             L2DatabaseFactory.close(con);
         }
     }
  

i removed the id shit you said :D

   private void load()
     {
         int votes = 0;
         Connection con = null;
         try
         {
             con = L2DatabaseFactory.getInstance().getConnection();
             PreparedStatement statement = con.prepareStatement("SELECT vote FROM votes LIMIT 1");
             ResultSet rset = statement.executeQuery();
             System.out.println(getLastVoteCount()); 
              if (rset.next())
             {
                _votesRegistered = true;
                votes = rset.getInt("vote");
             }
             rset.close();
             statement.close();
         }
         catch (Exception e)
         {
             _log.log(Level.WARNING, "data error on vote: ", e);
         }
         finally
         {
             L2DatabaseFactory.close(con);
         }
         
         setLastVoteCount(votes);
     }

and this one like you said :D I i think save part still incomplete xD i didnt understand :/

  • 0
Posted

the save() method seems fine... I used to have exactly the same and it's working, the "UPDATE" thingy is fine, you don't need to delete and insert...

 

the only thing that comes to my mind is that you're calling wrong the "save()" method when the server is restarting... but that would be weird... try changing the method by "public static void save()" and then access with "TzVoteRewardManager.save()", I feel like it's stupid but I don't see any problem in the whole code..

  • 0
Posted (edited)

and this one like you said :D I i think save part still incomplete xD i didnt understand :/

You only did one part of what i said. Should be like that on save() method

 

if (_votesRegistered)

      statement = con.prepareStatement("UPDATE ...........");

else

      statement = con.prepareStatement("INSERT ...........");

 

Please re-read my previous post to understand better what i meant.

 

 

the save() method seems fine... I used to have exactly the same and it's working, the "UPDATE" thingy is fine, you don't need to delete and insert...

 

the only thing that comes to my mind is that you're calling wrong the "save()" method when the server is restarting... but that would be weird... try changing the method by "public static void save()" and then access with "TzVoteRewardManager.save()", I feel like it's stupid but I don't see any problem in the whole code..

Not exactly. If the table is completely empty, obviously there's nothing to UPDATE.

Edited by Versus

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...