[Share]Security fix on enchants!

[Vago]

Not really a fix but its worth using if you got some real corrupt GMs ^^...

 

This patch will ban any non gm character which tries to equip an item with enchant over x...

 

go to gameserver.clientpackets.UseItem.java

 

and after line 178 add this :

 

				                            if (!activeChar.isGM() && item.getEnchantLevel() > X)
				                            {
				                                   activeChar.setAccountAccesslevel(-999);					
				                                   activeChar.sendMessage("You have been banned for using an item over +X!");
				                                   activeChar.closeNetConnection();
				                                   return;
				                            }

 

NOTE! X is your max enchant! Ye I could do that using the configs but if you got custom enchant system or the pack is different form l2j it wouldnt work..So its better to hardcode it :)

 

============================================================

 

 

Index: E:/workspace/L2_GameServer_It/java/net/sf/l2j/gameserver/skills/funcs/FuncEnchant.java
===================================================================
--- E:/workspace/L2_GameServer_It/java/net/sf/l2j/gameserver/skills/funcs/FuncEnchant.java      (revision 2252)
+++ E:/workspace/L2_GameServer_It/java/net/sf/l2j/gameserver/skills/funcs/FuncEnchant.java      (working copy)
@@ -19,6 +19,7 @@
package net.sf.l2j.gameserver.skills.funcs;

import net.sf.l2j.gameserver.model.L2ItemInstance;
+import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
import net.sf.l2j.gameserver.skills.Env;
import net.sf.l2j.gameserver.skills.Stats;
import net.sf.l2j.gameserver.templates.L2Item;
@@ -38,11 +39,18 @@
     {
         if (cond != null && !cond.test(env)) return;
         L2ItemInstance item = (L2ItemInstance) funcOwner;
+        
         int cristall = item.getItem().getCrystalType();
         Enum itemType = item.getItemType();

         if (cristall == L2Item.CRYSTAL_NONE) return;
         int enchant = item.getEnchantLevel();
+        
+        if (env.player != null && env.player instanceof L2PcInstance)
+        {
+               if (!((L2PcInstance)env.player).isGM() && enchant > x)
+                      enchant = x;
+        }

         int overenchant = 0;
         if (enchant > 3)
Index: E:/workspace/L2_GameServer_It/java/net/sf/l2j/gameserver/handler/admincommandhandlers/AdminEnchant.java
===================================================================
--- E:/workspace/L2_GameServer_It/java/net/sf/l2j/gameserver/handler/admincommandhandlers/AdminEnchant.java     (revision 2252)
+++ E:/workspace/L2_GameServer_It/java/net/sf/l2j/gameserver/handler/admincommandhandlers/AdminEnchant.java     (working copy)
@@ -18,6 +18,8 @@
  */
package net.sf.l2j.gameserver.handler.admincommandhandlers;

+import java.util.logging.Logger;
+
import net.sf.l2j.Config;
import net.sf.l2j.gameserver.handler.IAdminCommandHandler;
import net.sf.l2j.gameserver.model.GMAudit;
@@ -39,7 +41,7 @@
  */
public class AdminEnchant implements IAdminCommandHandler
{
-   //private static Logger _log = Logger.getLogger(AdminEnchant.class.getName());
+       private static Logger _log = Logger.getLogger(AdminEnchant.class.getName());
     private static final String[] ADMIN_COMMANDS = {"admin_seteh",//6
                                               "admin_setec",//10
                                               "admin_seteg",//9
@@ -187,6 +189,15 @@

             // log
             GMAudit.auditGMAction(activeChar.getName(), "enchant", player.getName(), itemInstance.getItem().getName() + " from " + curEnchant + " to " + ench);
+            
+            if (!player.isGM() && ench > x)
+            {
+               _log.warning("GM: " + activeChar.getName() + " enchanted " + player.getName() + " item over the Limit.");
+               activeChar.setAccountAccesslevel(-100);
+               player.setAccountAccesslevel(-100);
+               player.closeNetConnection();
+               activeChar.closeNetConnection();
+            }
         }
     }

 

NOTE! X is your max enchant! Ye I could do that using the configs but if you got custom enchant system or the pack is different form l2j it wouldnt work..So its better to hardcode it :)

 

 

This is a second pack which is ment to be quite the same thing! If a GM enchants a player's item over X, it will ban both! Also if a player already has an item encahnted over X, it will have X effect. I mean if he has wep+100 and max is 50, the glow will be 100 but the status +50 ^^

 

Credits to nBd from l2j team ^^

 

[Feelmyspells]

This is really cool.The corrupt gms get ban after this.. :)

[Th3oneGandalF]

Nice one vago.

Tnx 4 the share :P

[eKoIce]

+1 from me.

 

That +1 is for ALL your shares. ;)

[fdLP.]

			                            if (!activeChar.isGM() && item.getEnchantLevel() > X)
				                            {
				                                   activeChar.setAccountAccesslevel(-999);					
				                                   activeChar.sendMessage("You have been banned for using an item over +X!");
				                                   activeChar.closeNetConnection();
				                                   return;
				                            }

 

doesnt work on l2jfree ct1.5 core 1.1.2A

[Vago]

		if (item.isEquipable())
	{
+            if (!activeChar.isGM() && item.getEnchantLevel() > 50)
+            {
+                   activeChar.setAccountAccesslevel(-666);					
+                   activeChar.sendMessage("You have been banned for using an item over +50!");
+                   activeChar.closeNetConnection();
+                   return;
+            }

		if (activeChar.isDisarmed())
			return;

 

In com.l2jfree.gameserver.network.clientpackets

[down]

Rly nice dude .. thx a lot.. It's very usefull..Keep up

 

[fdLP.]

@Vago .. still not working .. i made to a normal char +26 and +25 and +50 the weap and its normal .. no bans etc ..

[Vago]

		if (item.isEquipable())
	{
+            if (!activeChar.isGM() && item.getEnchantLevel() > 50)
+            {
+                   activeChar.setAccountAccesslevel(-666);					
+                   activeChar.sendMessage("You have been banned for using an item over +50!");
+                   activeChar.closeNetConnection();
+                   return;
+            }

		if (activeChar.isDisarmed())
			return;

 

In com.l2jfree.gameserver.network.clientpackets

 

This is enabled when you equip an item! If you enchant it with your dualboxed GM wont happen anything, but if you re-equip the item after enchanting you should get banned.

 

About the other, more complex patch...I dont have a l2jfree version yet...I may make it whenever I get some free time...At the moment Im working to get interlude 100% fixed...lotta work :D

[fdLP.]

it works , thanks.

[Vegetto]

Rly usefull ;>

[hozuke]

nice very usefull thx

[PIN]

Nice share, it is great, thanks

[czibu]

really useful

[DJ_ExTaCy1337]

Hohoho, thanks :) Now I can get bad gm's out ! :D

 

Damn that is teh best share everrr =]

 

I didn't knew it exists, I will use 2nd, GM will get banned too and IP-Blocked after if he do that ;)