[Help] Skills Shop

[Fatalas]

hello guys :) i have lil problem.. got this code for selling skills>>>

 

package custom.SkillsShop;

import net.sf.l2j.gameserver.model.actor.L2Npc;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
import net.sf.l2j.gameserver.datatables.SkillTable;
import net.sf.l2j.gameserver.model.quest.Quest;
import net.sf.l2j.gameserver.model.quest.QuestState;
import net.sf.l2j.gameserver.util.Util;

public class SkillsShop extends Quest
{
private final static int ITEM_ID = 9903;
private final static int ITEM_COUNT = 1;
private final static String qn = "SkillsShop";
private final static int NPC = 50020;
private final static int[] SkillIds =
{
	9990,
	9991,
	9992,
	9993,
	9998,

	9994,
	9995,
	9996,
	9997,
	9999
};

public SkillsShop(int questId, String name, String descr) 
{
	super(questId, name, descr);
	addFirstTalkId(NPC);
	addStartNpc(NPC);
	addTalkId(NPC);
}

@Override
public String onAdvEvent(String event, L2Npc npc, L2PcInstance player)
{
	String htmltext = "";


	player.destroyItemByItemId("Consume", ITEM_ID, ITEM_COUNT, player, true);

	QuestState qs = player.getQuestState(qn);
	int SkillId = Integer.valueOf(event);
	int SkillLv = 1;
	if (Util.contains(SkillIds, SkillId))
	player.addSkill(SkillTable.getInstance().getInfo(SkillId, SkillLv), true);
	player.sendSkillList();

	qs.exitQuest(true);
	htmltext = "main.htm";
	return htmltext;
}

@Override
public String onFirstTalk(L2Npc npc, L2PcInstance player)
{
	String htmltext = "";
	QuestState qs = player.getQuestState(qn);
	if (qs == null)
		qs = newQuestState(player);
	htmltext = "main.htm";
	return htmltext;
}

public static void main(String[] args)
{
	new SkillsShop(-1, qn, "custom");

	System.out.println("..............! - Importing Custom: 50020: NPC SKILL SHOP..............");
}

}

 

the problem is that even if i dont have item needed i got error massage but still can learn skill.. what's wrong? and maybe someone could tell me how to make first part of skills to sell for one item and another part for another item?

[Tryskell]

player.destroyItemByItemId("Consume", ITEM_ID, ITEM_COUNT, player, true) is supposed to return a boolean, so you can use it for your item check.

 

if (player.destroyItemByItemId("Consume", ITEM_ID, ITEM_COUNT, player, true))
{
// put code from your scripts here
}
else
{
// error message
}

 

What's your pack ? net.sf is IL-like, but you use a java script.

 

I finally must add String htmltext is totally useless in both methods, and your script is buggy at :

 

if (Util.contains(SkillIds, SkillId))
	player.addSkill(SkillTable.getInstance().getInfo(SkillId, SkillLv), true);
	player.sendSkillList();

 

You probably used a python script as source and python handles differently if cases. You want to do as follow:

 

if (Util.contains(SkillIds, SkillId))
{
player.addSkill(SkillTable.getInstance().getInfo(SkillId, SkillLv), true);
player.sendSkillList();
}

 

as there is no reason to send skill list if the id is incorrect.

[Fatalas]

Thx Tryskell, helped me a lot :) made what i wanted :) just one more question .. could you tell me please how to check if player already have skill? cause now it consumes item even if player already have skill ;/ i'm using aCis pack (the best of all in my opinion) :)