Jump to content
  • 0

[Help] New Enchant Scrolls


Question

Posted

Feliz, Navidad, Merry Christmas.

 

This is my abstractEnchantPacket.java

 

:poker face:

 

package net.sf.l2j.gameserver.network.clientpackets;

 

import gnu.trove.map.hash.TIntObjectHashMap;

 

import net.sf.l2j.Config;

import net.sf.l2j.gameserver.model.L2ItemInstance;

import net.sf.l2j.gameserver.templates.item.L2Item;

import net.sf.l2j.gameserver.templates.item.L2Weapon;

import net.sf.l2j.gameserver.templates.item.L2WeaponType;

 

public abstract class AbstractEnchantPacket extends L2GameClientPacket

{

  public static final TIntObjectHashMap<EnchantScroll> _scrolls = new TIntObjectHashMap<>();

 

  public static final class EnchantScroll

  {

      protected final boolean _isWeapon;

      protected final int _grade;

      private final boolean _isBlessed;

      private final boolean _isCrystal;

     

      public EnchantScroll(boolean wep, boolean bless, boolean crystal, int type)

      {

        _isWeapon = wep;

        _grade = type;

        _isBlessed = bless;

        _isCrystal = crystal;

      }

     

      /**

      * @param enchantItem : The item to enchant.

      * @return true if support item can be used for this item

      */

      public final boolean isValid(L2ItemInstance enchantItem)

      {

        if (enchantItem == null)

            return false;

       

        // checking scroll type and configured maximum enchant level

        switch (enchantItem.getItem().getType2())

        {

            case L2Item.TYPE2_WEAPON:

              if (!_isWeapon || (Config.ENCHANT_MAX_WEAPON > 0 && enchantItem.getEnchantLevel() >= Config.ENCHANT_MAX_WEAPON))

                  return false;

              break;

           

            case L2Item.TYPE2_SHIELD_ARMOR:

            case L2Item.TYPE2_ACCESSORY:

              if (_isWeapon || (Config.ENCHANT_MAX_ARMOR > 0 && enchantItem.getEnchantLevel() >= Config.ENCHANT_MAX_ARMOR))

                  return false;

              break;

           

            default:

              return false;

        }

       

        // check for crystal type

        if (_grade != enchantItem.getItem().getCrystalType())

            return false;

       

        return true;

      }

     

      /**

      * @return true if item is a blessed scroll.

      */

      public final boolean isBlessed()

      {

        return _isBlessed;

      }

     

      /**

      * @return true if item is a crystal scroll.

      */

      public final boolean isCrystal()

      {

        return _isCrystal;

      }

     

      /**

      * Regarding enchant system :

 

      *

 

      * Weapons

      * <ul>

      * <li>magic weapons has chance of 40% until +15 and 20% from +15 and higher. There is no upper limit, there is no dependance on current enchant level.</li>

      * <li>non magic weapons has chance of 70% until +15 and 35% from +15 and higher. There is no upper limit, there is no dependance on current enchant level.</li>

      * </ul>

      * Armors

      * <ul>

      * <li>non fullbody armors (jewelry, upper armor, lower armor, boots, gloves, helmets and shirts) has chance of 2/3 for +4, 1/3 for +5, 1/4 for +6, ...., 1/18 +20. If you've made a +20 armor, chance to make it +21 will be equal to zero (0%).</li>

      * <li>full body armors has a chance of 1/1 for +4, 2/3 for +5, 1/3 for +6, ..., 1/17 for +20. If you've made a +20 armor, chance to make it +21 will be equal to zero (0%).</li>

      * </ul>

      * @param enchantItem : The item to enchant.

      * @return the enchant chance under double format (0.7 / 0.35 / 0.44324...).

      */

      public final double getChance(L2ItemInstance enchantItem)

      {

        if (!isValid(enchantItem))

            return -1;

       

        boolean fullBody = enchantItem.getItem().getBodyPart() == L2Item.SLOT_FULL_ARMOR;

        if (enchantItem.getEnchantLevel() < Config.ENCHANT_SAFE_MAX || (fullBody && enchantItem.getEnchantLevel() < Config.ENCHANT_SAFE_MAX_FULL))

            return 1;

       

        double chance = 0;

       

        // Armor formula : 0.66^(current-2), chance is lower and lower for each enchant.

        if (enchantItem.isArmor())

            chance = Math.pow(Config.ENCHANT_CHANCE_ARMOR, (enchantItem.getEnchantLevel() - 2));

        // Weapon formula is 70% for fighter weapon, 40% for mage weapon. Special rates after +14.

        else if (enchantItem.isWeapon())

        {

            if (((L2Weapon) enchantItem.getItem()).isMagical())

              chance = (enchantItem.getEnchantLevel() > 14) ? Config.ENCHANT_CHANCE_WEAPON_MAGIC_15PLUS : Config.ENCHANT_CHANCE_WEAPON_MAGIC;

            else

              chance = (enchantItem.getEnchantLevel() > 14) ? Config.ENCHANT_CHANCE_WEAPON_NONMAGIC_15PLUS : Config.ENCHANT_CHANCE_WEAPON_NONMAGIC;

        }

       

        return chance;

      }

  }

 

  /**

    * Format : itemId, (isWeapon, isBlessed, isCrystal, grade)

 

    * Allowed items IDs must be sorted by ascending order.

    */

  static

  {

      // Scrolls: Enchant Weapon

      _scrolls.put(729, new EnchantScroll(true, false, false, L2Item.CRYSTAL_A));

      _scrolls.put(947, new EnchantScroll(true, false, false, L2Item.CRYSTAL_B));

      _scrolls.put(951, new EnchantScroll(true, false, false, L2Item.CRYSTAL_C));

      _scrolls.put(955, new EnchantScroll(true, false, false, L2Item.CRYSTAL_D));

      _scrolls.put(959, new EnchantScroll(true, false, false, L2Item.CRYSTAL_S));

     

      // Scrolls: Enchant Armor

      _scrolls.put(730, new EnchantScroll(false, false, false, L2Item.CRYSTAL_A));

      _scrolls.put(948, new EnchantScroll(false, false, false, L2Item.CRYSTAL_B));

      _scrolls.put(952, new EnchantScroll(false, false, false, L2Item.CRYSTAL_C));

      _scrolls.put(956, new EnchantScroll(false, false, false, L2Item.CRYSTAL_D));

      _scrolls.put(960, new EnchantScroll(false, false, false, L2Item.CRYSTAL_S));

     

      // Blessed Scrolls: Enchant Weapon

      _scrolls.put(6569, new EnchantScroll(true, true, false, L2Item.CRYSTAL_A));

      _scrolls.put(6571, new EnchantScroll(true, true, false, L2Item.CRYSTAL_B));

      _scrolls.put(6573, new EnchantScroll(true, true, false, L2Item.CRYSTAL_C));

      _scrolls.put(6575, new EnchantScroll(true, true, false, L2Item.CRYSTAL_D));

      _scrolls.put(6577, new EnchantScroll(true, true, false, L2Item.CRYSTAL_S));

     

      // Blessed Scrolls: Enchant Armor

      _scrolls.put(6570, new EnchantScroll(false, true, false, L2Item.CRYSTAL_A));

      _scrolls.put(6572, new EnchantScroll(false, true, false, L2Item.CRYSTAL_B));

      _scrolls.put(6574, new EnchantScroll(false, true, false, L2Item.CRYSTAL_C));

      _scrolls.put(6576, new EnchantScroll(false, true, false, L2Item.CRYSTAL_D));

      _scrolls.put(6578, new EnchantScroll(false, true, false, L2Item.CRYSTAL_S));

     

      // Crystal Scrolls: Enchant Weapon

      _scrolls.put(731, new EnchantScroll(true, false, true, L2Item.CRYSTAL_A));

      _scrolls.put(949, new EnchantScroll(true, false, true, L2Item.CRYSTAL_B));

      _scrolls.put(953, new EnchantScroll(true, false, true, L2Item.CRYSTAL_C));

      _scrolls.put(957, new EnchantScroll(true, false, true, L2Item.CRYSTAL_D));

      _scrolls.put(961, new EnchantScroll(true, false, true, L2Item.CRYSTAL_S));

     

      // Crystal Scrolls: Enchant Armor

      _scrolls.put(732, new EnchantScroll(false, false, true, L2Item.CRYSTAL_A));

      _scrolls.put(950, new EnchantScroll(false, false, true, L2Item.CRYSTAL_B));

      _scrolls.put(954, new EnchantScroll(false, false, true, L2Item.CRYSTAL_C));

      _scrolls.put(958, new EnchantScroll(false, false, true, L2Item.CRYSTAL_D));

      _scrolls.put(962, new EnchantScroll(false, false, true, L2Item.CRYSTAL_S));

     

      // Special scrolls(event): Enchant Weapon

      _scrolls.put(12269, new EnchantScroll(true, true, false, L2Item.CRYSTAL_A));

      _scrolls.put(12271, new EnchantScroll(true, true, false, L2Item.CRYSTAL_B));

      _scrolls.put(12273, new EnchantScroll(true, true, false, L2Item.CRYSTAL_C));

      _scrolls.put(12275, new EnchantScroll(true, true, false, L2Item.CRYSTAL_D));

      _scrolls.put(12277, new EnchantScroll(true, true, false, L2Item.CRYSTAL_S));

     

      // Special scrolls(event): Enchant Armor

      _scrolls.put(12270, new EnchantScroll(false, true, false, L2Item.CRYSTAL_A));

      _scrolls.put(12272, new EnchantScroll(false, true, false, L2Item.CRYSTAL_B));

      _scrolls.put(12274, new EnchantScroll(false, true, false, L2Item.CRYSTAL_C));

      _scrolls.put(12276, new EnchantScroll(false, true, false, L2Item.CRYSTAL_D));

      _scrolls.put(12278, new EnchantScroll(false, true, false, L2Item.CRYSTAL_S));

  }

 

  /**

    * @param scroll The instance of item to make checks on.

    * @return enchant template for scroll.

    */

  protected static final EnchantScroll getEnchantScroll(L2ItemInstance scroll)

  {

      return _scrolls.get(scroll.getItemId());

  }

 

  /**

    * @param item The instance of item to make checks on.

    * @return true if item can be enchanted.

    */

  protected static final boolean isEnchantable(L2ItemInstance item)

  {

      if (item.isHeroItem() || item.isShadowItem() || item.isEtcItem() || item.getItem().getItemType() == L2WeaponType.FISHINGROD)

        return false;

     

      // only equipped items or in inventory can be enchanted

      if (item.getLocation() != L2ItemInstance.ItemLocation.INVENTORY && item.getLocation() != L2ItemInstance.ItemLocation.PAPERDOLL)

        return false;

     

      return true;

  }

}

 

I want to register new scrolls correctly and give them a 100% enchant rate.

Anyone can help me?

Is there an easy way? I am aCis user.

2 answers to this question

Recommended Posts

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Posts

    • The big systems, such as the Olympiad and sieges, are done. Now it’s time to tackle the smaller stuff.   Fishing, pets, striders, lottery, derby, private shops, and macros are ready.   P.S. If anyone has experience launching projects and would like to try launching a project using my client/server, feel free to message me on Telegram and we can discuss it: @artem_lemeshev
    • That's definitely not the reason why they perform wipes.
    • You are right, and most of them meant it when they said it.   Servers wipe because it is the only tool they have left. Something breaks the economy, a duplication bug or an exploited quest or a bad multisell, and the owner cannot tell which items came out of it. When you cannot find the bad items, the only way to clean the world is to delete the world. That is not dishonesty, it is running out of options.   So the answer is not to promise harder. It is to not need the promise: Backups run daily into three places: this machine, an S3 bucket whose key can write and cannot delete, and a computer that is not the server at all.   A restore test runs weekly and actually restores, into a scratch database, comparing every table against production. I ran it before writing this reply: 119 tables, 0 missing, 0 empty, characters back with their coordinates. Binary logging is on with sync_binlog=1 and fourteen days of retention. Every change is on record, so an item can be traced back to what produced it and removed by itself.   That is what makes "fix the bug and remove what it produced" a real option instead of a slogan. What I will not promise is that the server runs forever. If it ever closes, that is an ending, not a wipe, and you would hear it from me first.   Six months is the only proof that counts. Bookmark the thread.
    • I think it happened when I tried adding an ad banner—it turned out to be an ad injector that scattered ads all over the site and cluttered it up. I’ve removed it now; you either visited right when it was active, or it was just leftover residue. It’s gone now (try Ctrl + Shift + R). I’m fixing the responsiveness right now!
    • A brand-new High Five x5 server built for players, not wallets. Only a week old — the perfect time to start. And this Friday we're running a Double XP Comeback Weekend. 🎉 DOUBLE XP COMEBACK WEEKEND — Friday 21 August, 14:00 → Sunday • x2 XP & SP · x2 Adena & drops · FREE full buffs all weekend 📊 RATES • XP / SP: x5 · Adena & drops: boosted · Chronicle: High Five (L2jMobius, retail-based) ✨ QUALITY OF LIFE • Auto-loot for everyone (adena & items straight to inventory; herbs on ground) • Free buffer in the Community Board (Alt+B) • Offline shops • Champion monsters — passive, extra rewards, drop event medals • Premium earned in-game via medals: +20% XP/SP, gold nickname, up to 6 windows • Multibox: 2 windows free, 6 with Premium • Vote rewards (HopZone, TopZone) 🌐 WEBSITE & COMMUNITY • Full web panel, auction house, referral rewards, 2FA, support tickets • Custom auto-updating launcher • Hands-on GM — real-time bug fixes & support • No RMT, no pay-to-win 🔗 Website: https://nolifer.eu · Discord: https://discord.gg/Z9p4pmXFYx
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..