Code Rank Pvp System 3.8.9 [Il - H5]

O_o · October 24, 2013

Suggestion: Can use the pc cafe points window for the rps points or to use it in a other way for your code ? (This is just a idea dunno if i good or bad but I think is interesting)

http://www.l2jserver.com/forum/viewtopic.php?f=69&t=17772

<< Masterio >> · October 25, 2013

Because the RPS is multi chronicle i dont want waste time for H5 features. But of course you can add it, it is simple:D

valanths1990 · October 25, 2013

dude i think you made a logical mistake, in community patch you have this

else if(command.startsWith("_bbsrps") && RankPvpSystemConfig.RANK_PVP_SYSTEM_ENABLED && RankPvpSystemConfig.TOP_LIST_ENABLED)
{
     RankPvpSystemBBSManager.getInstance().parsecmd(command, activeChar);
}

and in that method you call you check if top lists are enabled else do something else i think it will always be true ;)

correct me if i am wrong

Edited October 25, 2013 by valanths1990

<< Masterio >> · October 26, 2013

I think it is correct:

else if(command.startsWith("_bbsrps") && RankPvpSystemConfig.RANK_PVP_SYSTEM_ENABLED && RankPvpSystemConfig.TOP_LIST_ENABLED)
{
     RankPvpSystemBBSManager.getInstance().parsecmd(command, activeChar);
}

else if (command is fetched AND rank pvp system enabled AND top list enabled)
{
       do something...
}

If one of conditions returns false, the code inside will be not executed.

Example: if TOP_LIST_ENABLED is FALSE then the code inside will be skipped.

DennisGR · October 26, 2013

i have rev 1004 frozen..and i have errors at eclipse..what can i do?? i do apply match

<< Masterio >> · October 26, 2013

1. If you have old RPS, remove it. (restore from svn).

2. Install from diff patches (for frozen).

3. Have fun.

Edited October 26, 2013 by >Masterio<

valanths1990 · October 26, 2013

thats why i told you that cause in that method ypu call you are checking again if top lists are enqbled

SweeTs · October 26, 2013

Not used it, nor checked the code, but the Rank System may refer to few options, like top pvp/pk. So, you can just enable for example JUST pk list, so the check is correct.

Edited October 26, 2013 by SweeTs

<< Masterio >> · October 26, 2013

valanths1990

CommunityBoard:







// Rank PvP System by Masterio
else if(command.startsWith("_bbsrps"))
{ 
	RankPvpSystemBBSManager.getInstance().parsecmd(command, activeChar);
}

RankPvpSystemBBSManager:

	@Override
	public void parsecmd(String command, L2PcInstance activeChar)
	{
		if(RankPvpSystemConfig.RANK_PVP_SYSTEM_ENABLED && RankPvpSystemConfig.TOP_LIST_ENABLED)
		{
			if(command.startsWith("_bbsrps:"))
			{
				int page = 0;
				try
				{
					page = Integer.parseInt(command.split(":", 2)[1].trim());
				}
				catch(Exception e)
				{
					log.info(e.getMessage());
					page = 0;
				}
				
				separateAndSend(RankPvpSystemBBSHtm.getPage(activeChar, page), activeChar);
			}
		}
		else if(!RankPvpSystemConfig.TOP_LIST_ENABLED)
		{
			ShowBoard sb = null;

			sb = new ShowBoard("<html><body><br><br><center>Community Board Top List is disabled in config file</center><br><br></body></html>", "101");

			activeChar.sendPacket(sb);
			activeChar.sendPacket(new ShowBoard(null, "102"));
			activeChar.sendPacket(new ShowBoard(null, "103"));
			
			sb = null;
		}
	}

Fixed.

Edited October 26, 2013 by >Masterio<

DennisGR · October 26, 2013

i dont wont to put it out..i want to install it on my server

Dante44® · October 26, 2013

follow the guide and u can have it

<< Masterio >> · October 27, 2013

this fix is not important for now it will be released in new rev.

evagelos · November 1, 2013

First af all your share is awesome...thanks

But i have a little problem with TopTable, my top killers, top gatherers never update. It always says the message "No one ot top 10 list yet"

I am using l2frozen(Iinterlude)

<< Masterio >> · November 1, 2013

It should update at the selected hour in config. BTW i will check it.

Amida Nguyen · November 5, 2013

Hi, I have problem with PvP Count, I use Freya version, but I always get the notice:

You can't earn RPC on innocent players!

You can't earn Rank Points on innocent players!

If I disable it, only receive PvP when kill Karma player, please help me

Code Rank Pvp System 3.8.9 [Il - H5]

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Posts

Topics