[Help] Pk in PvP Mod ?

[Bobi]

any ideas where can be problem when ppl fight in pvp mod and some time they become PK when kill his enemy ?

 

Not every time they become PK but many time that happen

[adenaman]

in pk method of l2pcinstance check if they are in event and just return, that should fix it

[Bobi]

  On 5/26/2012 at 1:58 PM, adenaman said:

in pk method of l2pcinstance check if they are in event and just return, that should fix it

i dont see nothing critical there what can bug pvp mod

[adenaman]

when you say pvp mod you mean pvp stance or some pvp event?

 

anyway this is the important code section of l2PcInstance:

 

public void onKillUpdatePvPKarma(L2Character target)
{
	if (target == null) return;
	if (!(target instanceof L2Playable)) return;

	L2PcInstance targetPlayer = target.getActingPlayer();

	if (targetPlayer == null) return;                                          // Target player is null
	if (targetPlayer == this) return;                                          // Target player is self

	if (isCursedWeaponEquipped())
	{
		CursedWeaponsManager.getInstance().increaseKills(_cursedWeaponEquippedId);
		// Custom message for time left
		// CursedWeapon cw = CursedWeaponsManager.getInstance().getCursedWeapon(_cursedWeaponEquipedId);
		// SystemMessage msg = SystemMessage.getSystemMessage(SystemMessageId.THERE_IS_S1_HOUR_AND_S2_MINUTE_LEFT_OF_THE_FIXED_USAGE_TIME);
		// int timeLeftInHours = (int)(((cw.getTimeLeft()/60000)/60));
		// msg.addItemName(_cursedWeaponEquipedId);
		// msg.addNumber(timeLeftInHours);
		// sendPacket(msg);
		return;
	}

	// If in duel and you kill (only can kill l2summon), do nothing
	if (isInDuel() && targetPlayer.isInDuel()) return;

	// If in Arena, do nothing
	if (isInsideZone(ZONE_PVP) || targetPlayer.isInsideZone(ZONE_PVP))
		return;

	// Check if it's pvp
	if (
			(
					checkIfPvP(target) &&            //   Can pvp and
					targetPlayer.getPvpFlag() != 0   //   Target player has pvp flag set
			) ||                                     // or
			(
					isInsideZone(ZONE_PVP) &&         		 //   Player is inside pvp zone and
					targetPlayer.isInsideZone(ZONE_PVP) 	 //   Target player is inside pvp zone
			)
	)
		increasePvpKills(target);
	else
		// Target player doesn't have pvp flag set
	{
		// check about wars
		if (targetPlayer.getClan() != null && getClan() != null
				&& getClan().isAtWarWith(targetPlayer.getClanId())
				&& targetPlayer.getClan().isAtWarWith(getClanId())
				&& targetPlayer.getPledgeType() != L2Clan.SUBUNIT_ACADEMY
				&& getPledgeType() != L2Clan.SUBUNIT_ACADEMY)
		{
			// 'Both way war' -> 'PvP Kill'
			increasePvpKills(target);
			return;
		}

		// 'No war' or 'One way war' -> 'Normal PK'
		if (targetPlayer.getKarma() > 0)                                        // Target player has karma
		{
			if (Config.KARMA_AWARD_PK_KILL)
				increasePvpKills(target);
		}
		else if (targetPlayer.getPvpFlag() == 0)                                                                    // Target player doesn't have karma
		{
			increasePkKillsAndKarma(target);
			//Unequip adventurer items
			checkItemRestriction();
		}
	}

if your problem is with pvp flag, then check that your code is same than this (or maybe is some pvp flag update problem)

 

else if its the event, just add some check like duel's one

 

else i didnt get the question :s

[Bobi]

  On 5/26/2012 at 4:28 PM, adenaman said:

when you say pvp mod you mean pvp stance or some pvp event?

 

anyway this is the important code section of l2PcInstance:

 

public void onKillUpdatePvPKarma(L2Character target)
{
	if (target == null) return;
	if (!(target instanceof L2Playable)) return;

	L2PcInstance targetPlayer = target.getActingPlayer();

	if (targetPlayer == null) return;                                          // Target player is null
	if (targetPlayer == this) return;                                          // Target player is self

	if (isCursedWeaponEquipped())
	{
		CursedWeaponsManager.getInstance().increaseKills(_cursedWeaponEquippedId);
		// Custom message for time left
		// CursedWeapon cw = CursedWeaponsManager.getInstance().getCursedWeapon(_cursedWeaponEquipedId);
		// SystemMessage msg = SystemMessage.getSystemMessage(SystemMessageId.THERE_IS_S1_HOUR_AND_S2_MINUTE_LEFT_OF_THE_FIXED_USAGE_TIME);
		// int timeLeftInHours = (int)(((cw.getTimeLeft()/60000)/60));
		// msg.addItemName(_cursedWeaponEquipedId);
		// msg.addNumber(timeLeftInHours);
		// sendPacket(msg);
		return;
	}

	// If in duel and you kill (only can kill l2summon), do nothing
	if (isInDuel() && targetPlayer.isInDuel()) return;

	// If in Arena, do nothing
	if (isInsideZone(ZONE_PVP) || targetPlayer.isInsideZone(ZONE_PVP))
		return;

	// Check if it's pvp
	if (
			(
					checkIfPvP(target) &&            //   Can pvp and
					targetPlayer.getPvpFlag() != 0   //   Target player has pvp flag set
			) ||                                     // or
			(
					isInsideZone(ZONE_PVP) &&         		 //   Player is inside pvp zone and
					targetPlayer.isInsideZone(ZONE_PVP) 	 //   Target player is inside pvp zone
			)
	)
		increasePvpKills(target);
	else
		// Target player doesn't have pvp flag set
	{
		// check about wars
		if (targetPlayer.getClan() != null && getClan() != null
				&& getClan().isAtWarWith(targetPlayer.getClanId())
				&& targetPlayer.getClan().isAtWarWith(getClanId())
				&& targetPlayer.getPledgeType() != L2Clan.SUBUNIT_ACADEMY
				&& getPledgeType() != L2Clan.SUBUNIT_ACADEMY)
		{
			// 'Both way war' -> 'PvP Kill'
			increasePvpKills(target);
			return;
		}

		// 'No war' or 'One way war' -> 'Normal PK'
		if (targetPlayer.getKarma() > 0)                                        // Target player has karma
		{
			if (Config.KARMA_AWARD_PK_KILL)
				increasePvpKills(target);
		}
		else if (targetPlayer.getPvpFlag() == 0)                                                                    // Target player doesn't have karma
		{
			increasePkKillsAndKarma(target);
			//Unequip adventurer items
			checkItemRestriction();
		}
	}

if your problem is with pvp flag, then check that your code is same than this (or maybe is some pvp flag update problem)

 

else if its the event, just add some check like duel's one

 

else i didnt get the question :s

i mean when players make normal pvp in normal zone when they are all flag and some time they become PK

 

did u see something wrong here ?

 

public void onKillUpdatePvPKarma(L2Character target)
{
	if (target == null) return;
	if (!(target instanceof L2PlayableInstance)) return;

	if (_inEventCTF || _inEventTvT)
		return;
	if (_inEventFOS) return;

	if (_inEventVIP)
	{
		increasePvpKills(target);
		return;
	}

	L2PcInstance targetPlayer = null;
	if (target instanceof L2PcInstance)
		targetPlayer = (L2PcInstance)target;
	else if (target instanceof L2Summon)
		targetPlayer = ((L2Summon)target).getOwner();

	if (targetPlayer == null) return;                                          // Target player is null
	if (targetPlayer == this) return;                                          // Target player is self

	if (isCursedWeaponEquiped())
	{
		CursedWeaponsManager.getInstance().increaseKills(_cursedWeaponEquipedId);
		return;
	}

	// If in duel and you kill (only can kill l2summon), do nothing
	if (isInDuel() && targetPlayer.isInDuel()) return;
        
	if (Config.L2F_ENABLE_EVENT_ENGINE==true)
        {
	if (EventManager.getInstance().isRegistered(this) && EventManager.getInstance().isRegistered(targetPlayer))
					return;
        }
        // If in Arena, do nothing
	if (isInsideZone(ZONE_PVP) || targetPlayer.isInsideZone(ZONE_PVP))
		return;

        // Check if it's pvp
	if ((checkIfPvP(target) && targetPlayer.getPvpFlag() != 0 ) || ( isInsideZone(ZONE_PVP) && targetPlayer.isInsideZone(ZONE_PVP)))
	{
            increasePvpKills(target);  
	}
	else
	{
            // check about wars
            if (targetPlayer.getClan() != null && getClan() != null)
            {
                if (getClan().isAtWarWith(targetPlayer.getClanId()))
                {
                    if (targetPlayer.getClan().isAtWarWith(getClanId()))
                    {
                        // 'Both way war' -> 'PvP Kill'
                    	increasePvpKills(target);
                        return;
                    }
                }
            }

            // 'No war' or 'One way war' -> 'Normal PK'
		if (targetPlayer.getKarma() > 0)                                        // Target player has karma
		{
			if ( Config.KARMA_AWARD_PK_KILL )
			{
				increasePvpKills(target);
			}
		}
		else if (targetPlayer.getPvpFlag() == 0)                                                                    // Target player doesn't have karma
		{
			increasePkKillsAndKarma(targetPlayer.getLevel(),target);
		}
	}
}

[Vkouk]

can you explain better your problem?

when someone pk or pvp someone their status doesn't get updated?

[Bobi]

  On 5/26/2012 at 5:39 PM, Ventic said:

can you explain better your problem?

when someone pk or pvp someone their status doesn't get updated?

 

when few players make pvp in any zone some time when u kill flag players u are become PK

 

so u kill flaed player and u are PK 

 

not every time but many time that happen

[Vkouk]

seems your updatePkStatus ( or something like this ) is wrong or idea my idea?

[Bobi]

  On 5/26/2012 at 5:49 PM, Ventic said:

seems your updatePkStatus ( or something like this ) is wrong or idea my idea?

i didnt see something wrong with can make this bug

because i ask if someone was have same problem or can give any idea

where can be problem or how to detect how that happen or something else

[adenaman]

about flag update you can try to log getPvpFlagLasts() and pvpStatus

[Bobi]

  On 5/26/2012 at 6:33 PM, adenaman said:

about flag update you can try to log getPvpFlagLasts() and pvpStatus

nothing happen still no idea how that happen