Jump to content

Elfo

Legendary Member
  • Posts

    2,009
  • Credits

  • Joined

  • Last visited

  • Days Won

    51
  • Feedback

    0%

Posts posted by Elfo

  1. 1 minute ago, DukeAwesome said:

    Γι'αυτό τον λόγο ακριβώς πρέπει να αλλάξει κοινό 

    Ααα ναι γιατι το όνειρο μου είναι να διαβάζω τα νέα μου για την τεχνολογία απο το Maxcheaters - The best cheating forum

  2. I always felt like things like this have more of a place in the CommunityBoard, instead of the NpcHtml. You have more space and to add more things. Also previous/next pagination can get hectic without numbered pagination so I would add that.

     

    In terms of the code the following can be optimized:

    npc.getDropData().forEach(c -> list.add(c));
    Collections.reverse(list);

    You can iterate over the getDropData() enumerable in a reverse fashion in order to prevent the reverse call. You just add the objects in reverse before hand.

     

    You can move "final int ITEMS_PER_LIST = 7;" outside of the static method to prevent the allocation to the object every time the method is called.

     

    You should chain sb.append within your sb.append calls. Strings are immutable so you're allocating more memory for no reason.

     

    You can change this:

     

    if (_ignored.contains(itemId))
           _ignored.remove(itemId);
       else
           _ignored.add(itemId);

    To this:

     

    var existed = _ignored.remove(itemId);
    if(!existed)
        _ignored.add(itemId);

     

    You also should rename the public methods "ignoredDropContain" and "ignored" in Player.java. They are really bad names and they don't imply what they do. They also don't belong in the Player class.

     

    There are other small things as well but too nit picky to mention.

    • Upvote 1
  3. 13 minutes ago, Doomus said:

    And why is that? randoms have healer running behind their ass 24/7 when battle ends instantly follows same person. Also bots only get stuck walls 24/7 ;)

    Pretty much every server has fake players nowadays and I have a fair share of blame to take on that.

     

    However, do you want pvp with healers even though they are bots or without healers?

    I would personally go with the first but you have the danger of not having action at all which leads to players leaving. There is an argument to be made on both sides.

  4. 23 minutes ago, L2Elixir.com said:

    Greece’s #1 Hip-Hop artist SNIK to host L2 Elixir’s x3

    Ο Μήτσος για μισό κιλό φέτα και 4 ελιές πουλάει και την μάνα του.

    • Haha 3
×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock