[share] trade bug fix

[ScRaB4ever]

Hello ppl. its my first java post

i used  as a source a post from Rizel

i tried his fix to my server and it didnt fix the bug

so i fixed the code

here it is :

L2PcInstance.java

 

At line 497

 

    private int _apprentice = 0;

    private int _sponsor = 0;

 

+    public boolean _allowTrade = true;

   

private long _clanJoinExpiryTime;

private long _clanCreateExpiryTime;

 

 

 

At line 8121

 

    public void setClanPrivileges(int n)

    {

        _clanPrivileges = n;

    }

 

+    public boolean getAllowTrade()

+    {

+    return _allowTrade;

+    }

+   

+    public void setAllowTrade(boolean a)

+    {

+    _allowTrade = a;

+    }

 

-----------------------------------------------

AnswerTradeRequest.java

 

At line 60

 

        L2PcInstance partner = player.getActiveRequester();

        if (partner == null || L2World.getInstance().findObject(partner.getObjectId()) == null)

        {

+        if (partner.getAllowTrade() == true)

+       {

+      partner.sendPacket(new SendTradeDone(0));

+      player.sendPacket(new SendTradeDone(0));

+      return; }

       

At line 74

            player.sendPacket(msg);

+          player.setAllowTrade(true);

            player.setActiveRequester(null);

At line 80

 

-          if (_response == 1) player.startTrade(partner);

 

+    if (_response == 1)

+    {

+  player.startTrade(partner);

+            partner.setAllowTrade(true);

+            player.setAllowTrade(true);

+    }

 

else

{

SystemMessage msg = new SystemMessage(SystemMessageId.S1_DENIED_TRADE_REQUEST);

msg.addString(player.getName());

+                         partner.setAllowTrade(true);

+                         player.setAllowTrade(true);

partner.sendPacket(msg);

 

 

msg = null;

 

-----------------------------------------------

TradeRequest.java

 

At line 112

 

            player.sendMessage("Target is in trade refusal mode");

            return;

        }

+              if (player.getAllowTrade() == false)

+              {

+                player.sendMessage("You are not allowed to make more than one trade request at the same time.");

+                return;

+                }

+              if (partner.getAllowTrade() == false)

+          {

+            player.sendMessage("The target is not allowed to make more than one trade request at the same time.");

+            return;

+            }

+        partner.setAllowTrade(false);

+        player.setAllowTrade(false);

player.onTransactionRequest(partner);

 

-------------------------------------------

TradeDone.java

 

At line 79

 

        }

        trade.confirm();

+         player.setAllowTrade(true);

 

}

else player.cancelActiveTrade();

+        player.setAllowTrade(true);

 

}

 

[Fanky]

http://www.maxcheaters.com/forum/index.php?topic=49180.0

(?)

---

Now i get the point of your topic.

Anyway

First you should put [GR] tags,

and second the fixe's which you done its not exactly fixes.This wont work.

[ScRaB4ever]

as it seems its not the same code since the previous one didnt solve the problem....

[Matim]

This is ENGLISH not GREEK section, topic locked.

 

---

 

Unlocked as requested, translate this thread to english.

[ScRaB4ever]

bump

[DamianPT]

This is ENGLISH not GREEK section, topic locked.

 

---

 

Unlocked as requested, translate this thread to english.

 

*_*

[ScRaB4ever]

dont spam in my post.....

[allanalcantara]

I was looking for, thanks.

[ScRaB4ever]

hahaha im glad that i help you!!!

[Howl3r]

Well you don't need to always check like this:

if (player.getAllowTrade == true).

 

If you wanna see if the getAllowTrade is false then do this

if (!player.getAllowTrade)

 

else if you wanna be true do this

if (player.getAllowTrade)

 

Just my opinion :)

[bobzih]

But he blocks well because I tested it: D