Jump to content
--> Place your ad text here <--
Get Free Banners - Giveaway MaxCheaters.com
We're Rebuilding – Join Our Staff Team
  • 0

Java / enchant8_skill + enchant12_skill

killer666

Asked by killer666,

 Share

Question

killer666 Rookie

killer666

Posted
Posted

Seems easy enough, but last days after many tests, i failed hard multiple times, so i have to ask for help.

Pretty sure some fella can give me the solution here. xml / item / skill all done correctly. Also by compiling there is no error. 

  

#Weapon.java	
  
	private IntIntHolder _enchant4Skill;
+	private IntIntHolder _enchant8Skill;
+	private IntIntHolder _enchant12Skill;

		
		if (set.containsKey("enchant4_skill"))
			_enchant4Skill = set.getIntIntHolder("enchant4_skill");
+	
+		if (set.containsKey("enchant8_skill"))
+			_enchant8Skill = set.getIntIntHolder("enchant8_skill");
+
+		if (set.containsKey("enchant12_skill"))
+			_enchant12Skill = set.getIntIntHolder("enchant12_skill");
+
  
  	public L2Skill getEnchant4Skill()
	{
		return (_enchant4Skill == null) ? null : _enchant4Skill.getSkill();
	}
+	
+	public L2Skill getEnchant8Skill()
+	{
+		return (_enchant8Skill == null) ? null : _enchant8Skill.getSkill();
+	}
+	
+	public L2Skill getEnchant12Skill()
+	{
+		return (_enchant12Skill == null) ? null : _enchant12Skill.getSkill();
+	}
+	
  
  ------------------------------------------------------
  #RequestEnchantItem.java
  
  					if (it instanceof Weapon && item.getEnchantLevel() == 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.addSkill(enchant4Skill, false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.addSkill(enchant8Skill, false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.addSkill(enchant12Skill, false);
+							player.sendSkillList();
+						}
+					}
+

  
  					if (it instanceof Weapon && item.getEnchantLevel() >= 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.removeSkill(enchant4Skill.getId(), false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.removeSkill(enchant8Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.removeSkill(enchant12Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+

  ------------------------------------------------
  
  #ItemPassiveSkillsListener.java
  
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.addSkill(enchant4Skill, false);
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.addSkill(enchant8Skill, false);
+					update = true;
+				}
+			}
+
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.addSkill(enchant12Skill, false);
+					update = true;
+				}
+			}
+
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.removeSkill(enchant4Skill.getId(), false, enchant4Skill.isPassive() || enchant4Skill.isToggle());
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.removeSkill(enchant8Skill.getId(), false, enchant8Skill.isPassive() || enchant8Skill.isToggle());
+					update = true;
+				}
+			}
+			
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.removeSkill(enchant12Skill.getId(), false, enchant12Skill.isPassive() || enchant12Skill.isToggle());
+					update = true;
+				}
+			}

 

4 answers to this question

Recommended Posts

  • 0
ratchet Enthusiast

ratchet

Posted
Posted

Hello,  to be honest with you, your question is a bit unclear, at least to me.

Are you trying to give special skills to players based upon their weapon enchant level?

 

Also there are parts of the code that are wrong, for example you do: 

if (item.getEnchantLevel() >= 4)

and then immediately after 

else if (item.getEnchantLevel() >= 8)

This last block will never be evaluated since the previous one will be true, and so on.

From the snippets you posted I can't figure out, maybe try to post the whole files somewhere 😄

  • 0
Salty Mike Community Regular

Salty Mike

Posted
Posted
On 7/11/2024 at 10:15 AM, killer666 said:

Seems easy enough, but last days after many tests, i failed hard multiple times, so i have to ask for help.

Pretty sure some fella can give me the solution here. xml / item / skill all done correctly. Also by compiling there is no error. 

  

#Weapon.java	
  
	private IntIntHolder _enchant4Skill;
+	private IntIntHolder _enchant8Skill;
+	private IntIntHolder _enchant12Skill;

		
		if (set.containsKey("enchant4_skill"))
			_enchant4Skill = set.getIntIntHolder("enchant4_skill");
+	
+		if (set.containsKey("enchant8_skill"))
+			_enchant8Skill = set.getIntIntHolder("enchant8_skill");
+
+		if (set.containsKey("enchant12_skill"))
+			_enchant12Skill = set.getIntIntHolder("enchant12_skill");
+
  
  	public L2Skill getEnchant4Skill()
	{
		return (_enchant4Skill == null) ? null : _enchant4Skill.getSkill();
	}
+	
+	public L2Skill getEnchant8Skill()
+	{
+		return (_enchant8Skill == null) ? null : _enchant8Skill.getSkill();
+	}
+	
+	public L2Skill getEnchant12Skill()
+	{
+		return (_enchant12Skill == null) ? null : _enchant12Skill.getSkill();
+	}
+	
  
  ------------------------------------------------------
  #RequestEnchantItem.java
  
  					if (it instanceof Weapon && item.getEnchantLevel() == 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.addSkill(enchant4Skill, false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.addSkill(enchant8Skill, false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.addSkill(enchant12Skill, false);
+							player.sendSkillList();
+						}
+					}
+

  
  					if (it instanceof Weapon && item.getEnchantLevel() >= 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.removeSkill(enchant4Skill.getId(), false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.removeSkill(enchant8Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.removeSkill(enchant12Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+

  ------------------------------------------------
  
  #ItemPassiveSkillsListener.java
  
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.addSkill(enchant4Skill, false);
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.addSkill(enchant8Skill, false);
+					update = true;
+				}
+			}
+
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.addSkill(enchant12Skill, false);
+					update = true;
+				}
+			}
+
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.removeSkill(enchant4Skill.getId(), false, enchant4Skill.isPassive() || enchant4Skill.isToggle());
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.removeSkill(enchant8Skill.getId(), false, enchant8Skill.isPassive() || enchant8Skill.isToggle());
+					update = true;
+				}
+			}
+			
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.removeSkill(enchant12Skill.getId(), false, enchant12Skill.isPassive() || enchant12Skill.isToggle());
+					update = true;
+				}
+			}

 


The solution is what the guy before me said. You need to either place the higher value before the smaller value or limit the range.

Ex. 1: 
  

if (item.getEnchantLevel() >= 12)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 8)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 4)
{
     // do whatever
}


Ex. 2:
  

if (item.getEnchantLevel() >= 4 && item.getEnchantLevel() <= 7)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 8 && item.getEnchantLevel() <= 11)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 12)
{
     // do whatever
}

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to question listing


  • Posts

    • DiscordAccS
      Elite Discord Mass DM Service | Hyper-Targeted Growth & Own

      By DiscordAccS · Posted

      Our sales are ongoing. Bump. 02 July 2025 Telegram: ContactDiscordAccS
    • DiscordAccS
      HQ Discord Accounts | Mass DM Ready | Full Email Access | Bu

      By DiscordAccS · Posted

      Our sales are ongoing. Bump. 02 July 2025 Telegram: ContactDiscordAccS
    • GX-Ext
      🌟 [RELEASE] Full Lineage 2 C4 Accumulative

      By GX-Ext · Posted

      just with this extender that I have shared it is not possible to start with c4 client, you have to make some changes to the extender and it works with c4 client perfectly. regarding the updates in this last revision   🔹dll is not packaged with vmprotect   New custom zone types have been added: 🔹 NO_NOBLESS begin MinX=84638 MaxX=92616 MinY=-87170 MaxY=-82018 MinZ=-6000 MaxZ=0 Type=NO_NOBLESS KickOutPos=83007/148057/-3464 end   ▶️ This zone checks if the character is noble. If it does not meet the condition, it will be automatically kicked to the indicated position (KickOutPos). 🔹 CUSTOM_SPAWN_ZONE begin MinX=77275 MaxX=85704 MinY=10122 MaxY=18066 MinZ=-8000 MaxZ=5000 Type=CUSTOM_SPAWN_ZONE OutPos=83007/148057/-3464 Spawns={{82984/18066/-5256}};{{79275/15147/-5248}};{{82922/14263/-5256}};{{83704/10122/-5288}} end ▶️ This zone allows characters, upon death, to respawn with full buff, CP, HP and MP if they press “Fixed”. They will only be able to revive in one of the positions defined in Spawns. 🔧 Both zones are fully configurable from territorydata.txt 🔧 Development Repository (SVN) GX-EXT supports open, collaborative, and professional development. That’s why we provide access to our public SVN repository where you can:   ✅ Compile your own version of the project ✅ Optimize and extend its features ✅ Learn from real production-quality source code   🔒 Delayed access: The repository is always 2 months behind the latest commercial release to prevent unauthorized reselling.   🔗 SVN URL: https://svn.l2servers.com.ar/!/#GX-EXT_INTERLUDE Username: gx Password: gx   You can use tools like TortoiseSVN to download and work with the code.
    • EUSOUOMESTREDOSMAGOS
      🌟 [RELEASE] Full Lineage 2 C4 Accumulative

      By EUSOUOMESTREDOSMAGOS · Posted

      Could you tell me what changed in this update?   more one question: Is it possible to log in through the c4 client instead of interlude? That would be great  
    • SocNet
      ⭐SOCNET BOOST⭐ is a new solution among all SMM panels

      By SocNet · Posted

      ➡ Discount for your purchase: JULY2025 (11% discount) ➡ Our Online Shop: https://socnet.store  ➡ Our SMM-Boosting Panel: https://socnet.pro  ➡ Telegram Shop Bot: https://socnet.shop  ➡ Telegram Support: https://t.me/solomon_bog  ➡ Telegram Channel: https://t.me/accsforyou_shop  ➡ Discord Support: @AllSocialNetworksShop  ➡ Discord Server: https://discord.gg/y9AStFFsrh  ➡ WhatsApp Support: https://wa.me/79051904467 ➡ WhatsApp Channel: https://whatsapp.com/channel/0029Vau0CMX002TGkD4uHa2n  ➡ Email Support: solomonbog@socnet.store 

  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock