Jump to content
MaxCheaters Official Group on X
MaxCheaters Official Group on Discord
--> Place your ad text here <--
  • 0

Java / enchant8_skill + enchant12_skill

killer666

Asked by killer666,

 Share

Question

killer666 Rookie

killer666

Posted
Posted

Seems easy enough, but last days after many tests, i failed hard multiple times, so i have to ask for help.

Pretty sure some fella can give me the solution here. xml / item / skill all done correctly. Also by compiling there is no error. 

  

#Weapon.java	
  
	private IntIntHolder _enchant4Skill;
+	private IntIntHolder _enchant8Skill;
+	private IntIntHolder _enchant12Skill;

		
		if (set.containsKey("enchant4_skill"))
			_enchant4Skill = set.getIntIntHolder("enchant4_skill");
+	
+		if (set.containsKey("enchant8_skill"))
+			_enchant8Skill = set.getIntIntHolder("enchant8_skill");
+
+		if (set.containsKey("enchant12_skill"))
+			_enchant12Skill = set.getIntIntHolder("enchant12_skill");
+
  
  	public L2Skill getEnchant4Skill()
	{
		return (_enchant4Skill == null) ? null : _enchant4Skill.getSkill();
	}
+	
+	public L2Skill getEnchant8Skill()
+	{
+		return (_enchant8Skill == null) ? null : _enchant8Skill.getSkill();
+	}
+	
+	public L2Skill getEnchant12Skill()
+	{
+		return (_enchant12Skill == null) ? null : _enchant12Skill.getSkill();
+	}
+	
  
  ------------------------------------------------------
  #RequestEnchantItem.java
  
  					if (it instanceof Weapon && item.getEnchantLevel() == 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.addSkill(enchant4Skill, false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.addSkill(enchant8Skill, false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.addSkill(enchant12Skill, false);
+							player.sendSkillList();
+						}
+					}
+

  
  					if (it instanceof Weapon && item.getEnchantLevel() >= 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.removeSkill(enchant4Skill.getId(), false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.removeSkill(enchant8Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.removeSkill(enchant12Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+

  ------------------------------------------------
  
  #ItemPassiveSkillsListener.java
  
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.addSkill(enchant4Skill, false);
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.addSkill(enchant8Skill, false);
+					update = true;
+				}
+			}
+
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.addSkill(enchant12Skill, false);
+					update = true;
+				}
+			}
+
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.removeSkill(enchant4Skill.getId(), false, enchant4Skill.isPassive() || enchant4Skill.isToggle());
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.removeSkill(enchant8Skill.getId(), false, enchant8Skill.isPassive() || enchant8Skill.isToggle());
+					update = true;
+				}
+			}
+			
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.removeSkill(enchant12Skill.getId(), false, enchant12Skill.isPassive() || enchant12Skill.isToggle());
+					update = true;
+				}
+			}

 

4 answers to this question

Recommended Posts

  • 0
ratchet Enthusiast

ratchet

Posted
Posted

Hello,  to be honest with you, your question is a bit unclear, at least to me.

Are you trying to give special skills to players based upon their weapon enchant level?

 

Also there are parts of the code that are wrong, for example you do: 

if (item.getEnchantLevel() >= 4)

and then immediately after 

else if (item.getEnchantLevel() >= 8)

This last block will never be evaluated since the previous one will be true, and so on.

From the snippets you posted I can't figure out, maybe try to post the whole files somewhere 😄

  • 0
Salty Mike Community Regular

Salty Mike

Posted
Posted
On 7/11/2024 at 10:15 AM, killer666 said:

Seems easy enough, but last days after many tests, i failed hard multiple times, so i have to ask for help.

Pretty sure some fella can give me the solution here. xml / item / skill all done correctly. Also by compiling there is no error. 

  

#Weapon.java	
  
	private IntIntHolder _enchant4Skill;
+	private IntIntHolder _enchant8Skill;
+	private IntIntHolder _enchant12Skill;

		
		if (set.containsKey("enchant4_skill"))
			_enchant4Skill = set.getIntIntHolder("enchant4_skill");
+	
+		if (set.containsKey("enchant8_skill"))
+			_enchant8Skill = set.getIntIntHolder("enchant8_skill");
+
+		if (set.containsKey("enchant12_skill"))
+			_enchant12Skill = set.getIntIntHolder("enchant12_skill");
+
  
  	public L2Skill getEnchant4Skill()
	{
		return (_enchant4Skill == null) ? null : _enchant4Skill.getSkill();
	}
+	
+	public L2Skill getEnchant8Skill()
+	{
+		return (_enchant8Skill == null) ? null : _enchant8Skill.getSkill();
+	}
+	
+	public L2Skill getEnchant12Skill()
+	{
+		return (_enchant12Skill == null) ? null : _enchant12Skill.getSkill();
+	}
+	
  
  ------------------------------------------------------
  #RequestEnchantItem.java
  
  					if (it instanceof Weapon && item.getEnchantLevel() == 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.addSkill(enchant4Skill, false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.addSkill(enchant8Skill, false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.addSkill(enchant12Skill, false);
+							player.sendSkillList();
+						}
+					}
+

  
  					if (it instanceof Weapon && item.getEnchantLevel() >= 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.removeSkill(enchant4Skill.getId(), false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.removeSkill(enchant8Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.removeSkill(enchant12Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+

  ------------------------------------------------
  
  #ItemPassiveSkillsListener.java
  
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.addSkill(enchant4Skill, false);
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.addSkill(enchant8Skill, false);
+					update = true;
+				}
+			}
+
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.addSkill(enchant12Skill, false);
+					update = true;
+				}
+			}
+
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.removeSkill(enchant4Skill.getId(), false, enchant4Skill.isPassive() || enchant4Skill.isToggle());
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.removeSkill(enchant8Skill.getId(), false, enchant8Skill.isPassive() || enchant8Skill.isToggle());
+					update = true;
+				}
+			}
+			
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.removeSkill(enchant12Skill.getId(), false, enchant12Skill.isPassive() || enchant12Skill.isToggle());
+					update = true;
+				}
+			}

 


The solution is what the guy before me said. You need to either place the higher value before the smaller value or limit the range.

Ex. 1: 
  

if (item.getEnchantLevel() >= 12)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 8)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 4)
{
     // do whatever
}


Ex. 2:
  

if (item.getEnchantLevel() >= 4 && item.getEnchantLevel() <= 7)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 8 && item.getEnchantLevel() <= 11)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 12)
{
     // do whatever
}

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to question listing


  • Posts

    • Tryskell
      Multi route walker npc HELP

      By Tryskell · Posted

      Verify if following is supposed to be the way to handle movement npc.getAI().setIntention(CtrlIntention.AI_INTENTION_MOVE_TO, new Location(point.getX(), point.getY(), point.getZ())); For me, it's not enough. And if it's the case, whole AI system is probably buggy.
    • SmurfsZone
      SmurfsZone: Your Best Source for League of Legend

      By SmurfsZone · Posted

      This is a  bump
    • reacheap
      wtt harbor 1x for l2reborn 10x new

      By reacheap · Posted

      hello, i want to wtt my charracter in l2elmorelab 1x harbor for 1.5kkk adena in l2reborn 10x new. Or if you interested tell me your offer. :)) Clean Mail 30 lvl Cleric Naked   Updated.
    • Starfire868686
      Multi route walker npc HELP

      By Starfire868686 · Posted

      package ai.npc.NFWalker; import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Random; import l2r.gameserver.enums.CtrlIntention; import l2r.gameserver.model.Location; import l2r.gameserver.model.actor.L2Npc; import l2r.gameserver.model.quest.Quest; import l2r.gameserver.network.clientpackets.Say2; import l2r.gameserver.network.serverpackets.NpcSay; public class NFWalkerAI extends Quest { private static final int WALKER_NPC_ID = 20116; private final Map<String, Route> routes = new HashMap<>(); private final Map<Integer, Integer> npcIndexes = new HashMap<>(); private final Map<Integer, Boolean> npcReverse = new HashMap<>(); private final Map<Integer, String> npcCurrentRoute = new HashMap<>(); public NFWalkerAI() { super(-1, NFWalkerAI.class.getSimpleName(), "ai/npc/NFWalker"); loadRoutes(); addSpawnId(WALKER_NPC_ID); } private void loadRoutes() { // Route 1 Data Route route1 = new Route("route1"); route1.addPoint(new RoutePoint(0, 149363, 172341, -941, 0, false, "")); route1.addPoint(new RoutePoint(1, 148568, 172328, -980, 5, true, "Puff")); route1.addPoint(new RoutePoint(2, 148536, 172792, -980, 0, false, "")); // Route 2 Data Route route2 = new Route("route2"); route2.addPoint(new RoutePoint(0, 149363, 172341, -941, 0, false, "")); route2.addPoint(new RoutePoint(1, 150248, 172328, -980, 5, true, "Rise my children! Bring me the servants of the god! Let them be offered to our god Bifrons!")); route2.addPoint(new RoutePoint(2, 150248, 172776, -980, 0, false, "")); // Add routes to the map routes.put("route1", route1); routes.put("route2", route2); } @Override public String onSpawn(L2Npc npc) { if (npc.getId() == WALKER_NPC_ID) { selectInitialRouteForNpc(npc); } return super.onSpawn(npc); } @Override public String onAdvEvent(String event, L2Npc npc, l2r.gameserver.model.actor.instance.L2PcInstance player) { if (event.equalsIgnoreCase("move")) { moveNpc(npc); } else if (event.equalsIgnoreCase("check_reached")) { checkIfReached(npc); } return null; } private void moveNpc(L2Npc npc) { String routeName = npcCurrentRoute.get(npc.getObjectId()); Route route = routes.get(routeName); Integer pointIndex = npcIndexes.get(npc.getObjectId()); if (route != null && pointIndex != null) { RoutePoint point = route.getPoints().get(pointIndex); if (point.isRun()) { npc.setRunning(); } else { npc.setWalking(); } if (!point.getChat().isEmpty()) { npc.broadcastPacket(new NpcSay(npc.getObjectId(), Say2.NPC_ALL, npc.getId(), point.getChat())); } npc.getAI().setIntention(CtrlIntention.AI_INTENTION_MOVE_TO, new Location(point.getX(), point.getY(), point.getZ())); // Log movement intention System.out.println("NPC " + npc.getObjectId() + " moving to " + point.getX() + ", " + point.getY() + ", " + point.getZ()); // Schedule a check to see if the NPC has reached its destination startQuestTimer("check_reached", 1000, npc, null); } } private void checkIfReached(L2Npc npc) { String routeName = npcCurrentRoute.get(npc.getObjectId()); Route route = routes.get(routeName); Integer pointIndex = npcIndexes.get(npc.getObjectId()); if (route != null && pointIndex != null) { RoutePoint point = route.getPoints().get(pointIndex); Location currentLocation = npc.getLocation(); Location targetLocation = new Location(point.getX(), point.getY(), point.getZ()); // Check if the NPC has reached the target location if (currentLocation.equals(targetLocation)) { // Log that the NPC has reached the target System.out.println("NPC " + npc.getObjectId() + " reached target " + targetLocation); // Schedule the next movement startQuestTimer("move", point.getDelay() * 1000, npc, null); if (!npcReverse.get(npc.getObjectId())) { pointIndex++; if (pointIndex >= route.getPoints().size()) { npcReverse.put(npc.getObjectId(), true); pointIndex = route.getPoints().size() - 1; } } else { pointIndex--; if (pointIndex < 0) { npcReverse.put(npc.getObjectId(), false); pointIndex = 0; // Choose a new route after completing the current one in both directions switchRouteForNpc(npc); return; } } npcIndexes.put(npc.getObjectId(), pointIndex); } else { // Check again after 1 second startQuestTimer("check_reached", 1000, npc, null); } } } private void selectInitialRouteForNpc(L2Npc npc) { // Randomly select either route1 or route2 String selectedRouteName = "route" + (new Random().nextInt(2) + 1); npcCurrentRoute.put(npc.getObjectId(), selectedRouteName); npcIndexes.put(npc.getObjectId(), 0); npcReverse.put(npc.getObjectId(), false); startQuestTimer("move", 5000, npc, null); // Log initial route selection System.out.println("NPC " + npc.getObjectId() + " selected initial route " + selectedRouteName); } private void switchRouteForNpc(L2Npc npc) { String currentRoute = npcCurrentRoute.get(npc.getObjectId()); String newRoute = currentRoute.equals("route1") ? "route2" : "route1"; npcCurrentRoute.put(npc.getObjectId(), newRoute); npcIndexes.put(npc.getObjectId(), 0); npcReverse.put(npc.getObjectId(), false); startQuestTimer("move", 5000, npc, null); // Log route switching System.out.println("NPC " + npc.getObjectId() + " switched to route " + newRoute); } private static class Route { private List<RoutePoint> points = new ArrayList<>(); public Route(String name) { } public void addPoint(RoutePoint point) { points.add(point); } public List<RoutePoint> getPoints() { return points; } } private static class RoutePoint { private int id; private int x, y, z, delay; private boolean run; private String chat; public RoutePoint(int id, int x, int y, int z, int delay, boolean run, String chat) { this.id = id; this.x = x; this.y = y; this.z = z; this.delay = delay; this.run = run; this.chat = chat; } public int getId() { return id; } public int getX() { return x; } public int getY() { return y; } public int getZ() { return z; } public int getDelay() { return delay; } public boolean isRun() { return run; } public String getChat() { return chat; } } } I looking for help, with this, the npc not start to move. Im trying to create, an NPC wich have multiple walk routes basic logic is  random pick a route complite the route  like Route 1 start form zero (0 -> 1 -> 2(or more) -> 1 -> 0) When the npc return to 0, the script should pic the other route and start again.  And if there is a message like point 1 here     "route1.addPoint(new RoutePoint(1, 148568, 172328, -980, 5, true, "Puff"));" The npc should display the chat message. Currently my problem is the npc not moving, but if I manage it to start moving its randomly move between the route 1 and 2 set of coordinates. Currently for me its  a nightmare. I hope anyone can help somhow.
    • SXorg
      Proxy Market SX.ORG for any task | Buy and sell IP quickly

      By SXorg · Posted

      We are certainly not an ambulance, but we will definitely cure you of blacklists and empty pockets. Live freely with SX! Each of you will receive a trial version of SX to familiarize yourself with the product, all you have to do is post in this thread

  • Topics

×
×
  • Create New...