Formulas

[ElTyto]

yo guys, whats wrong with these formulas?

MCAtk1 = attacker.calcStat(Stats.MAGICAL_CRITICAL_DAMAGE, 1,  target,  skill);
MCAtk2 = attacker.calcStat(Stats.MCRITICAL_DAMAGE_ADD, 0, target, skill);
MCVul = target.calcStat(Stats.MCRIT_VULN, 1, target, skill);
damage = damage * 4 * MCAtk1 + MCAtk2;
damage *= MCVul;

before adding them simple hit was 450, mc was 1802, now the mc does the same dmg as a simple hit when im using MCAtkAdd, and with MCAtk the mc is like 2500, while the simple is 1650

else if (mcrit){
damage *= 4;

Edited November 19, 2015 by ElTyto

[Tryskell]

Maybe because you coded it that way...?

damage = damage * 4

[ElTyto]

 

Maybe because you coded it that way...?

damage = damage * 4

isnt damage *= 4 the same?

 

damage *= 4;

damage *= MCAtk1;

damage += MCAtk2;

damage *= MCVul;

is this better?

Edited November 19, 2015 by ElTyto

[Tryskell]

That wasn't what I meant, I meant you coded regular way the same way than critical, therefore it's normal you don't have any changes between normal and critical.

Edited November 19, 2015 by Tryskell

[ElTyto]

i am still not getting your point, it should work but it isnt? :D

[ElTyto]

I'm gonna bump this topic everyday till someone helps ^^

[whiite]

I'm gonna bump this topic everyday till someone helps ^^

 

 

I have written so

        damage += attacker.calcStat(Stats.CRITICAL_DAMAGE, (damage + power), target, skill);
        damage += attacker.calcStat(Stats.CRITICAL_DAMAGE_ADD, 0, target, skill) * 6.5;
        damage *= target.calcStat(Stats.CRIT_VULN, 1, target, skill);

 

[ElTyto]

if i would change from 1 to (power + damage) my mcs would go from 2k to 2kk :D

[ElTyto]

cmon guys if ur not willing to help me atleast point me to a right direction, a guide or smth :/ 

[Tryskell]

Log every variable and every calculation step, you will know what happen.

 

Tbh I don't even understand your question.  If formulas are wrong it's because you wrote them bad. I don't even understand what you expect as result. How do you want any help ?

Edited January 26, 2016 by Tryskell

[ElTyto]

my expectations for what i am doing is: 
a variable MCAtkAdd similar to CAtkAdd, flat value like 200 bonus for a magic critical hit

a variable MCAtk similar to CAtk, % value to use like <mul 0x30 1.3 MCAtk>

a variable MCritVuln similar to CritVuln, % value to use like <mul 0x30 0.7 MCritVuln>

[Tryskell]

And what did you do so far ? Complete diff patch.

[ElTyto]

dont have eclipse nor java atm, will post here the details after a few days ;)