Help L2Character$Notifyaitask

[Xerus]

 com.l2jesios.gameserver.model.actor.L2Character$NotifyAITask run

WARNING: 

java.lang.StackOverflowError

 at com.l2jesios.gameserver.ai.L2CharacterAI.maybeMoveToPawn(L2CharacterAI.java:934)

 at com.l2jesios.gameserver.ai.L2PlayerAI.thinkCast(L2PlayerAI.java:240)

 at com.l2jesios.gameserver.ai.L2PlayerAI.onEvtThink(L2PlayerAI.java:316)

 at com.l2jesios.gameserver.ai.L2CharacterAI.onEvtArrived(L2CharacterAI.java:673)

 at com.l2jesios.gameserver.ai.AbstractAI.notifyEvent(AbstractAI.java:417)

 at com.l2jesios.gameserver.ai.AbstractAI.notifyEvent(AbstractAI.java:340)

 at com.l2jesios.gameserver.model.actor.L2Character.moveToLocation(L2Character.java:3893)

 at com.l2jesios.gameserver.model.actor.L2Character$AIAccessor.moveTo(L2Character.java:3039)

 at com.l2jesios.gameserver.ai.AbstractAI.moveTo(AbstractAI.java:582)

 at com.l2jesios.gameserver.ai.AbstractAI.moveToPawn(AbstractAI.java:538)

 at com.l2jesios.gameserver.ai.L2CharacterAI.maybeMoveToPawn(L2CharacterAI.java:948)

 

This error is flloding my gs very often and produce lag anyone know how to fix it? this is the line in L2CharacterAI

 

protected boolean maybeMoveToPawn(L2Object target, int offset)
{
if (target == null || offset < 0) // skill radius -1
return false;


offset += _actor.getTemplate().getCollisionRadius();   //this is the line 934
if (target instanceof L2Character)
offset += ((L2Character) target).getTemplate().getCollisionRadius();

 

[Versus]

There shouldn't be an issue there, obviously the original authors of this pack knew about this and added the catch (StackOverflowError). The only way to resolve this, is by checking all the calls of this method (infinite recursive calls are most likely the issue to this problem).

[Akken]

not sure but disable NpcWalkers and reply if it got fixed

 

noobish answer but try :P 

Edited December 10, 2013 by Akken

[Xerus]

not sure but disable NpcWalkers and reply if it got fixed

 

noobish answer but try :P

Nop

[Akken]

Nop

well i doubt if you tested it, well i am sure you didnt cause if you knew what action char makes and this error appear you would had this bug fixed

[Xerus]

well i doubt if you tested it, well i am sure you didnt cause if you knew what action char makes and this error appear you would had this bug fixed

yes of course

[Akken]

yes of course

willing to help you but your irony is of limits, i hope nobody gives a fuck for your trash server and get always this error damn people these days....

[Xerus]

willing to help you but your irony is of limits, i hope nobody gives a fuck for your trash server and get always this error damn people these days....

wtf? my irony? i said nop the thing you posted doesnt work and yes i would fix it if i know where it came from. Where is my irony? just honest replies..

Edited December 10, 2013 by Xerus

[Akken]

yes of course

this irony

 

and NpcWalkers are the retarded l2j npc and generally offi ones that goes around town etc, i googled it and a random guy got that issue with stackoverflow he disabled NpcWalkers and it helped..

in order to test it disable them and check tommorow if error log still exists so how you test so fast? 

[Xerus]

this irony

 

and NpcWalkers are the retarded l2j npc and generally offi ones that goes around town etc, i googled it and a random guy got that issue with stackoverflow he disabled NpcWalkers and it helped..

in order to test it disable them and check tommorow if error log still exists so how you test so fast? 

cause i already tested before and not working....

[Akken]

cause i already tested before and not working....

well obviously cause i saw only stackoverflow and i gaved the 1st answer of google.. you got stackOverFlow on other part of the code and it has also a movement issue i guess, not sure but as i searched more is a badly rework of l2j movement system rework and this issue exist in the most l2j packs so i guess a proper movement rework will fix all those stackoverflows or general-pools errors

[Xerus]

well obviously cause i saw only stackoverflow and i gaved the 1st answer of google.. you got stackOverFlow on other part of the code and it has also a movement issue i guess, not sure but as i searched more is a badly rework of l2j movement system rework and this issue exist in the most l2j packs so i guess a proper movement rework will fix all those stackoverflows or general-pools errors

the flood is coming like every 30 minutes i tried everything..

[Versus]

I'm not familiar with esios pack, but seems to me you are getting an error, you don't necessarily need. Most likely this is due to L2J's outdated way of using catch(Throwable t), that's almost never wanted, you want to catch specific exceptions and not generally everything - that should be the case only to the very top of a thread.

 

Go to L2Character.java at NotifyAiTask class and replace 

catch (Throwable t)
{
_log.log(Level.WARNING, "", t);
}

with

catch (Exception e)
{
_log.log(Level.WARNING, "", e);
}

[Xerus]

 

I'm not familiar with esios pack, but seems to me you are getting an error, you don't necessarily need. Most likely this is due to L2J's outdated way of using catch(Throwable t), that's almost never wanted, you want to catch specific exceptions and not generally everything - that should be the case only to the very top of a thread.

 

Go to L2Character.java at NotifyAiTask class and replace 

catch (Throwable t)
{
_log.log(Level.WARNING, "", t);
}

with

catch (Exception e)
{
_log.log(Level.WARNING, "", e);
}

 

At the moment its like this

public void run()
{
try
{
getAI().notifyEvent(_evt, null);
}
catch (StackOverflowError e) {
if(Config.DEBUG) // safer
_log.log(Level.WARNING, "", e);
}
catch (Throwable t)
{
_log.log(Level.WARNING, "", t);
}
}

but i think that stackoverflowerror is useless should i change to:

           public void run()
        {
            try
            {
                getAI().notifyEvent(_evt, null);
            }
            catch (Exception e)
            {
                _log.log(Level.WARNING, "NotifyAITask failed. " + e.getMessage() + " Actor " + L2Character.this, e);
            }

[Versus]

 

 

At the moment its like this

public void run()
{
try
{
getAI().notifyEvent(_evt, null);
}
catch (StackOverflowError e) {
if(Config.DEBUG) // safer
_log.log(Level.WARNING, "", e);
}
catch (Throwable t)
{
_log.log(Level.WARNING, "", t);
}
}

but i think that stackoverflowerror is useless should i change to:

           public void run()
        {
            try
            {
                getAI().notifyEvent(_evt, null);
            }
            catch (Exception e)
            {
                _log.log(Level.WARNING, "NotifyAITask failed. " + e.getMessage() + " Actor " + L2Character.this, e);
            }

 

Yes, you should change to that.

Edited December 10, 2013 by Versus

[SweeTs]

L2jEsios, really.. ? :not bad:

 

It's 'kinda' outdated, don't you think? :P