[HELP] Flagg zone

[sirzufall]

Hey again... well I got a new problem..

this is my code :

    /*
     * This program is free software: you can redistribute it and/or modify it under
     * the terms of the GNU General Public License as published by the Free Software
     * Foundation, either version 3 of the License, or (at your option) any later
     * version.
     *
     * This program is distributed in the hope that it will be useful, but WITHOUT
     * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
     * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
     * details.
     *
     * You should have received a copy of the GNU General Public License along with
     * this program. If not, see <http://www.gnu.org/licenses/>.
     */
    package com.l2jserver.gameserver.model.zone.type;
     
    import com.l2jserver.gameserver.ThreadPoolManager;
    import com.l2jserver.gameserver.model.actor.L2Character;
    import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
    import com.l2jserver.util.Rnd;
     
     
    /**
     * An Custom PvP Zone
     *
     * @author  NeverMore
     */
    public class L2CustomPvP extends L2RespawnZone
    {
        //Ramdom Locations configs
        private static int[] _x = {-80583, -82689, -83488};
        private static int[] _y = {150932, 152504, 153180};
        private static int[] _z = {-3041, -3178, -3178 };
       
        public L2CustomPvP(int id)
        {
            super(5555);
        }
       
        @Override
        protected void onEnter(L2Character character)
        {
            character.setInsideZone(L2Character.ZONE_NOSUMMONFRIEND, true);
           
               if (character instanceof L2PcInstance)
               {
			   ((L2PcInstance) character).sendMessage("You enter a PvP Area");
                   ((L2PcInstance) character).updatePvPFlag(1);
			   ((L2PcInstance) character).broadcastUserInfo();
               }
        }
       
        @Override
        protected void onExit(L2Character character)
        {
            character.setInsideZone(L2Character.ZONE_NOSUMMONFRIEND, false);
           
            if (character instanceof L2PcInstance)
            {
                ((L2PcInstance) character).stopNoblesseBlessing(null);
                ((L2PcInstance) character).stopPvPFlag();
                ((L2PcInstance) character).sendMessage("You exit from a PvP Area");
			((L2PcInstance) character).setPvpFlagLasts(System.currentTimeMillis() + 20000);
			((L2PcInstance) character).startPvPFlag();

            }
        }
       
        static class BackToPvp implements Runnable
        {
            private L2Character _activeChar;
     
            BackToPvp(L2Character character)
            {
                _activeChar = character;
            }
     
            @Override
            public void run()
            {
                int r = Rnd.get(3);
                _activeChar.teleToLocation(_x[r] , _y[r], _z[r]);
            }
        }
       
        @Override
        public void onDieInside(L2Character character)
        {
               if (character instanceof L2PcInstance)
               {
               }
        }
       
        @Override
        public void onReviveInside(L2Character character)
        {
		ThreadPoolManager.getInstance().scheduleGeneral(new BackToPvp(character), 500);
            ((L2PcInstance) character).isNoblesseBlessed();
	}
    }

So when you leave the the zone and enter the zone again directly , the flag lasts for 3 secs but after that you are not flagged anymore. Only when you leave the zone and wait until your flag is gone and enter again the zone the server updates your flag again.

How to fix it ?

Sall I add " ((L2PcInstance) character).stopPvPFlag();" on Enter the zone and after that

"((L2PcInstance) character).updatePvPFlag(1);" so the LastFlagg will cancel and update the flag again?

I dont know what to do please give me some help =)

thanks

 

 

 

[^Wyatt]

Can you explain clearly what u want to do with the code?

Dunno if am I the only that didn't understand anything...

[sirzufall]

well when a player exit the PvP Zone the flag should not be removed instantly.. it should last some seconds. that is what the code does... but when you enter the zone again while the flag is lasting your flag get removed and you are not flagged anymore although you are in the pvp zone.

 

[^Wyatt]

Why to not only do it? And erase the other...

@Override
protected void onEnter(L2Character character)
{
	character.setInsideZone(L2Character.ZONE_NOSUMMONFRIEND, true);

       if (character instanceof L2PcInstance)
       {
    	   ((L2PcInstance) character).sendMessage("You entered in a PvP Area");
    	   if (((L2PcInstance) character).getPvpFlag() == 0)
				((L2PcInstance) character).updatePvPFlag(1);          
       }
}

@Override
protected void onExit(L2Character character)
{
	character.setInsideZone(L2Character.ZONE_NOSUMMONFRIEND, false);

	if (character instanceof L2PcInstance)
	{
		((L2PcInstance) character).stopPvPFlag();  
    	((L2PcInstance) character).sendMessage("You left from a PvP Area");
    	
	}
}

[sirzufall]

Thx I will test it

[GsL]

Thx I will test it

 

So you dont answer this work now?

[^Wyatt]

Maybe too much work to answer...

I have it working so yes it works...

[sirzufall]

yes it work but when you leave the zone your flagg instantly stop. I want it to last for 3 secs.

[^Wyatt]

replace what we put inside onExit with this

((L2PcInstance) character).setPvpFlagLasts(System.currentTimeMillis() + 30000);

And test.

[sirzufall]

yeah that works.. but there is one problem when you leave the zone and enter again the pvp zone when your flag is lasting you will be white again ( not flagged ).

[^Wyatt]

And removing the checker if pvpflag == 0 from the onEnter method?

 

[sirzufall]

same problem

[^Wyatt]

I think I know why.

Try to follow the method setpvpflaglasttime or whatever is called (can't see right now) and where it sets the pvp flag to 0, add a checker, !if player.isInsideZone(L2Character.zone..)

If you don't succeed I'll help u in 1h, not at home right now.

[sirzufall]

sorry cant follow you

[^Wyatt]

Something like that.

Index: java/com/l2jserver/gameserver/model/actor/instance/L2PcInstance.java
===================================================================
--- java/com/l2jserver/gameserver/model/actor/instance/L2PcInstance.java	(revision 374)
+++ java/com/l2jserver/gameserver/model/actor/instance/L2PcInstance.java	(working copy)
@@ -1094,7 +1094,7 @@
		{
			try
			{
-				if (System.currentTimeMillis() > getPvpFlagLasts())
+				if (System.currentTimeMillis() > getPvpFlagLasts() && !isInsideZone(L2Character.ZONE_CUSTOM))
				{
					stopPvPFlag();
				}