[? Exploit] Crash GameServerThread - Pending more inspection.

[Vazelos]

Any exploit share is useless if l2j developers hang around on these forums...

A quick fix for this exploit is inevitable.

So true.

[Xanderॐ]

Anyway, the reason that you got NPE is probably because somehow the account wasnt inside _loginServerClients

 

Come on nick ,thats not an explanation. If somehow the account was not in loginServerClients then it can happen again. And possibly can be triggered by players. I would come discuss that in your forums, but im not welcome there. There's something bigger behind this im sure. Probably some race condition ? As a programmer you can just go and put :

 

if(client == null)

return;

 

It fixes it sure, but the cause of the npe is not investigated.

[Nik]

This is fucking ridiculous... i've investigated for no more than 1 min and this is what i see:

 

case AUTH_SUCCESS:

client.setAccount(_user);

lc.getCharactersOnAccount(_user);

client.setState(LoginClientState.AUTHED_LOGIN);

client.setSessionKey(lc.assignSessionKeyToClient(_user, client));

public SessionKey aassignSessionKeyToClient(String account, L2LoginClient client)

{

SessionKey key;

 

key = new SessionKey(Rnd.nextInt(), Rnd.nextInt(), Rnd.nextInt(), Rnd.nextInt());

_loginServerClients.put(account, client);

return key;

}

[QWASTA]

Thanks bro ..