Jump to content

Recommended Posts

Posted

Leeroy I'm pretty sure you got that code from somewhere in here (Maybe it was because I made it for someone else in the help section lool) and you didn't even bother to change the note,you just copied  / paste.

Thats not funny at all ^^

Nah i didnt.This is my first creation ,NB4L1 helped me with it (ask him if u want) ,just looked at stefoulis15's topic to see how to make it configurable thats all :)

So bad that my first work and some1 thinks it copied.. feels -beep-y.

But yes ,i got the idea from you ,tried to make your code ,but just didnt work at all ,gave me an error.So i asked nb4l1 to help me ,and even if he hates me.. :D he did ,so i`m happy for it ^^

 

EDIT : Thats your code

if(this.getPvpKills() == 1000 && !this.getSkills.contains(yourskillid))
   this.addSkill(skillid, skilllevel, processname 0);

 

Thats mine

			if (getPvpKills() == Config.PVP_CUSTOM_SKILL_P && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)
			  addSkill(SkillTable.getInstance().getInfo(Config.PVP_CUSTOM_SKILL_ID, Config.PVP_CUSTOM_SKILL_LV));

 

You used !this.getSkills.contains - i used another method.

You used a this.addSkill without even selection from where to search it.. so it doesnt work at all.

I dont want problems with you ,just prooving thats its not your copy/paste ,but i got the idea from you ;/

Posted

 

You used a this.addSkill without even selection from where to search it.. so it doesnt work at all.

Ofc it doesn't ,it was a non-existing example lool.

Anyway you should check if the player already has the Skill for security purposes, avoiding possible stacking. Thus the "!".

Posted

if (getPvpKills() == Config.PVP_CUSTOM_SKILL_P && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)

 

It is checked :) But infront of ! that it didnt work ,i used == null ,works too.

 

P.S. I expected a flame from your side ^^

Posted

P.S. I expected a flame from your side ^^

Wrong, it isn't flaming, if it was, you would be pissed ^^

Its just noticing when people take someone's work and claim it as their own. But its no problem, grats on your first share ^^

Posted

Nice work :)

I write a few useful skills:

 

Skill ID: 4408

Max skill LVL: 20

Description: Add HP x12 more.

 

 

Skill ID: 4409

Max skill LVL: 20

Description: Add MP x12 more.

 

 

Skill ID: 4410

Max skill LVL: 22

Description: Ultra strong P. Atk

 

 

Skill ID: 4411

Max skill LVL: 22

Description: Ultra strong M. Atk.

 

Skill ID: 4412

Max skill LVL: 22

Description: Ultra strong P. Def

 

Skill ID: 4413

Max skill LVL: 22

Description: Ultra strong M. Def

 

I think it's be useful :)

Posted

Dont post if you dont know a shit of java.Thanks

hahahahahahahahhahahaah LOL im with you!:P

but isn't a bad idea to give 3 skills or stats?Dont work for l2jserver F*** I want this!! :P someone please fix my post for the l2jserver :/

Posted

I put here

 

            increasePvpKills();

}

else                                                                        // Target player doesn't have pvp flag set

{

            // check about wars

            if (targetPlayer.getClan() != null && getClan() != null)

            {

                if (getClan().isAtWarWith(targetPlayer.getClanId()))

                {

                    if (targetPlayer.getClan().isAtWarWith(getClanId()))

                    {

                        // 'Both way war' -> 'PvP Kill'

                        increasePvpKills();

 

// INSERT

if (getPvpKills() == Config.PVP_CUSTOM_SKILL_ID && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)

  addSkill(SkillTable.getInstance().getInfo(Config.PVP_CUSTOM_SKILL_ID, Config.PVP_CUSTOM_SKILL_LV));

// END INSERT

 

                        return;

                    }

                }

            }

 

is good?

Posted

I put here

 

            increasePvpKills();

}

else                                                                        // Target player doesn't have pvp flag set

{

            // check about wars

            if (targetPlayer.getClan() != null && getClan() != null)

            {

                if (getClan().isAtWarWith(targetPlayer.getClanId()))

                {

                    if (targetPlayer.getClan().isAtWarWith(getClanId()))

                    {

                        // 'Both way war' -> 'PvP Kill'

                        increasePvpKills();

 

// INSERT

if (getPvpKills() == Config.PVP_CUSTOM_SKILL_ID && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)

  addSkill(SkillTable.getInstance().getInfo(Config.PVP_CUSTOM_SKILL_ID, Config.PVP_CUSTOM_SKILL_LV));

// END INSERT

 

                        return;

                    }

                }

            }

 

is good?

 

its wrong!!

 

IncreasePvPKills; (after this add new line and)

 

if (getPvpKills() == Config.PVP_CUSTOM_SKILL_P && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)

  addSkill(SkillTable.getInstance().getInfo(Config.PVP_CUSTOM_SKILL_ID, Config.PVP_CUSTOM_SKILL_LV));

Guest
This topic is now closed to further replies.



  • Posts

    • First, don't really follow the "main voice", moreover if you consider it an hobby. Simply do what you want, you got only one life so use it as you want. If you make it an hobby, it's exactly like piano, or velo - only practice makes you better.   Secondly, how do you learn things ? It's actually a really important question, since some can simply be scholar, read books (theory) then practice ; and some simply can't read books. I'm the second type, I hated school, I find it boring - my knowledge in Java comes from try-and-fail. You improve your coding style every year or so, I can myself rewrite my own code (which I already considered top-notched) after a while. You always learn something new - even if Java barely evolves. L2J is a fun way to learn programming, it's a giant sandbox where you can edit anything, and I believe it should be taken as it.   My own way of learning was as follow : Add existing customs, no matter what they are : the point is to know main classes used by L2J / customs. L2J is barely Java knowledge ; the true knowledge is to know WHAT to search in WHICH location (what I call, organization). You have to understand than EVERYTHING you think already exists, in a form on another, in the source code. A custom is only the association of the different mechanisms you found "here and there", glued together in a proper goal. Once you know main classes to edit, and the customs you added are compiling fine, the main point is to know WHAT exactly you DID. Try to understand WHY and WHERE you actually copied the code. Third point would be to MANIPULATE the customs you added in order to fit your wish. First edit little values, then logic conditions ; eventually add a new Config, or a new functionality to the custom. Fourth point would be to begin to craft your own ideas. Once again, EVERYTHING already exists, in a form or another. You want a cycled event ? You got Seven Signs main task as exemple. Npc ? Search any type of Npc and figure out what it does. Fifth point would be to understand Java - mostly containers (WHAT and WHERE to use them), variables types and main Java mechanisms (inheritance, static modifier, etc). You should also begin to cut your code into maintainable classes or methods. Java can actually run without optimization, but bigger your ideas, more optimized and well-thought it should be. It's direct saved time in the future, and you would thank yourself doing so. Main tips : ALWAYS use any type of versioning system - GIT or SVN. It allows to save your work, step by step and eventually revert back anytime you want if you terribly messed up. L2J is 80% organization knowledge, and 20% Java knowledge. Basically, if you know WHAT and WHERE to search, if you aren't dumb, it's easy to replicate and re-use things. Cherry on top is to use a already good coded pack to avoid copy-paste crap and get bad habits. Avoid any type of russian or brazilian packs, for exemple - their best ability is to leak someone's else code. Obviously you need some default sense of logic, but Java and programming in general help you to improve it.   Finally, most of your questions could be solved joining related Discord (at least for aCis, I can't speak for others) - from the moment your question was correctly asked (and you seemed to search for the answer). My community (and myself) welcomes newbies, but got some issues with noobies.   The simpliest is to try, fail and repeat until you succeed - it sounds stupid, but that's basically how life works.   PS : about Java ressources, before ChatGPT, it was mostly about stackoverflow website, and site like Baeldung's one. With ChatGPT and alike, you generally double-cross AI output to avoid fucked up answers. Also, care about AI, they are often hallucinating really hard, even today. They can give you complete wrong answer, you tell them they are wrong, and they say "indeed, I suck, sorry - here's a new fucked up answer". You shouldn't 100% rely over AI answer, even if that can give sometimes legit answers, full code or just skeletons of ideas.   PPS : I don't think there are reliable ressources regarding L2J itself, also most of the proposed code decays pretty fast if the source code is actually maintained (at least for aCis). Still, old coded customs for old aCis sources are actually a good beginner challenge to apply on latest source.
    • WTS: - AQ - Baium - Zaken  - Frintezza - Vesper Fighter Focus Fire Element   pm for detalis
    • We have the best price! L2Reborn.org Signature x1 Franz NEW!! 1KK = $20 HURRY TO BUY AT THE TOP PRICE discord - adver745645
  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock