Help How to improve my daily reward system

[ruut]

It's based on shared L2Ava files, let's say.

System explain: Every day, at certain time range, for example from 19PM to 22PM, players, who are online for 1hour and are not afk for more than (lets say in this code 10mins) will get certain reward.
Can you tell me what to improve or what part could be done differently or even in more simply way?

It's based on IP/HWID protection and I want to figure out if the daily cleanup is done correctly. 

 

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 * 
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 * 
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package services;

import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.concurrent.ScheduledFuture;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import l2ro.gameserver.Config;
import l2ro.gameserver.ThreadPoolManager;
import l2ro.gameserver.database.mysql;
import l2ro.gameserver.model.GameObjectsStorage;
import l2ro.gameserver.model.Player;
import l2ro.gameserver.scripts.ScriptFile;
/**
 *
 * @author L
 */
public class AutoReward implements ScriptFile, Runnable
{
	private static final Logger _log = LoggerFactory.getLogger(Player.class);
	
	private static final int REWARD_DELAY = 3600000; // 1h.
	private static final int REQUIRED_ONLINE = Config.DAILY_REWARD_REQUIRED_ONLINE * 3600000; // 1h.
	private static final int NOT_REWARD_AFK_DELAY = Config.DAILY_REWARD_AFK_TIME * 60000; // 10 mins.(Config 10)
	private static final DateFormat TIME_FORMAT = new SimpleDateFormat("HH");
	private boolean CLEANED = false;

	private ScheduledFuture<?> _task = null;

	@Override
	public void run()
	{
		if(CLEANED && time() >= Config.DAILY_REWARD_END_HOUR || time() < Config.DAILY_REWARD_START_HOUR)
			CLEANED = false;
		
		if(time() >= Config.DAILY_REWARD_START_HOUR && time() <= Config.DAILY_REWARD_END_HOUR)
		{
			for(Player player : GameObjectsStorage.getAllPlayersForIterate()) {
					if(player.isOnline() && player.getUptime() >= REQUIRED_ONLINE
						&& (System.currentTimeMillis() - player.getLastNotAfkTime()) > NOT_REWARD_AFK_DELAY) {
						if(!isRewardedDB(player)) {
							player.sendMessage("You will get your reward");
							setRewardDB(player);
						}
					}
			}
		}
		
		if(CLEANED == false && time() <= Config.DAILY_REWARD_START_HOUR) {
			CLEANED = true;
			wipeRewardDB();
		}
	}
	
	public static int time()
	{
		return Integer.parseInt(TIME_FORMAT.format(new Date(System.currentTimeMillis())));
	}
	
	public static boolean isRewardedDB(Player player) {
		String value = Config.DAILY_REWARD_PROTECTION.equals("HWID") ? player.getHWID() : player.getIP();
	
		if(player.getVar("daily_reward") != null)
			return true;
		
		if(mysql.get("SELECT value FROM character_variables WHERE name='daily_reward' AND value='"+value+"'") != null)
			return true;
		
		return false;
	}
	
	public static void setRewardDB(Player player) {
		String value = Config.DAILY_REWARD_PROTECTION.equals("HWID") ? player.getHWID() : player.getIP();
		
		mysql.set("INSERT INTO character_variables (obj_id, type, name, value, expire_time) VALUES (?,?,?,?,?)", player.getObjectId(), "user-var", "daily_reward", value, -1);
	}
	
	public static void wipeRewardDB() {

		mysql.set("DELETE FROM `character_variables` WHERE `type`='user-var' and `name`='daily_reward'");
	}

	@Override
	public void onLoad()
	{
		_log.info("Loaded Service: AutoReward");
		if(_task == null)
			_task = ThreadPoolManager.getInstance().scheduleAtFixedDelay(this, REWARD_DELAY, REWARD_DELAY);
	}

	@Override
	public void onReload()
	{
		if(_task != null)
		{
			_task.cancel(true);
			_task = null;
		}
		_task = ThreadPoolManager.getInstance().scheduleAtFixedDelay(this, REWARD_DELAY, REWARD_DELAY);
	}

	@Override
	public void onShutdown()
	{
		//
	}
}

 

Edited December 19, 2017 by ruut

[CUCUmber]

L2Devil have something like this daily reward /quests  

lets talk about the daily reward.. every 30 minute you are online you  get for example 1 coin(you have to get it from alt b  . you dont get it automaticaly) its 4 times per day 4x30min  

next day 1coin  becomes 2. next day 3 etc etc ..max is 7coin (7days) and from that point you will get every time 7coin/per part from 4parts of 30min  

also they have some nice quests " kill 30 warriors, 20 wizzard" sh1ts like this with reward boxes with skins etc

Edited December 19, 2017 by CUCUmber

[ruut]

Well yes, maybe they have I don't really know. However, yes, I've added also reward increase on the day of the week,  however, I want to know what should I change in my code to make it better.

[pantrukilla]

https://www.l2jbrasil.com/topic/149147-daily-reward-tested-on-l2jsunrise/