Jump to content
  • 0

Formulas


Question

Posted (edited)

yo guys, whats wrong with these formulas?

MCAtk1 = attacker.calcStat(Stats.MAGICAL_CRITICAL_DAMAGE, 1,  target,  skill);
MCAtk2 = attacker.calcStat(Stats.MCRITICAL_DAMAGE_ADD, 0, target, skill);
MCVul = target.calcStat(Stats.MCRIT_VULN, 1, target, skill);
damage = damage * 4 * MCAtk1 + MCAtk2;
damage *= MCVul;

before adding them simple hit was 450, mc was 1802, now the mc does the same dmg as a simple hit when im using MCAtkAdd, and with MCAtk the mc is like 2500, while the simple is 1650

else if (mcrit){
damage *= 4;
Edited by ElTyto

12 answers to this question

Recommended Posts

  • 0
Posted (edited)

 

Maybe because you coded it that way...?

damage = damage * 4

isnt damage *= 4 the same?

 

damage *= 4;
damage *= MCAtk1;
damage += MCAtk2;
damage *= MCVul;

is this better?

Edited by ElTyto
  • 0
Posted (edited)

That wasn't what I meant, I meant you coded regular way the same way than critical, therefore it's normal you don't have any changes between normal and critical.

Edited by Tryskell
  • 0
Posted

I'm gonna bump this topic everyday till someone helps ^^

 
 
I have written so
        damage += attacker.calcStat(Stats.CRITICAL_DAMAGE, (damage + power), target, skill);
        damage += attacker.calcStat(Stats.CRITICAL_DAMAGE_ADD, 0, target, skill) * 6.5;
        damage *= target.calcStat(Stats.CRIT_VULN, 1, target, skill);
 
  • 0
Posted (edited)

Log every variable and every calculation step, you will know what happen.

 

Tbh I don't even understand your question.  If formulas are wrong it's because you wrote them bad. I don't even understand what you expect as result. How do you want any help ?

Edited by Tryskell
  • 0
Posted

my expectations for what i am doing is: 
a variable MCAtkAdd similar to CAtkAdd, flat value like 200 bonus for a magic critical hit

a variable MCAtk similar to CAtk, % value to use like <mul 0x30 1.3 MCAtk>

a variable MCritVuln similar to CritVuln, % value to use like <mul 0x30 0.7 MCritVuln>

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock