Jump to content
  • 0

Unclose connection.


Question

Posted

Hello,

 

After the installation of Dressme : http://pastebin.com/5AYHVPit

 

All passes correctly, except that the GS grumbles a little :

 

Unclosed connection! Trace: com.l2jserver.gameserver.model.actor.instance.L2PcInstance.restoreVisualArmors(L2PcInstance.java:17365)
java.lang.RuntimeException at com.l2jserver.L2DatabaseFactory.getConnection(L2DatabaseFactory.java:273)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.restoreVisualArmors(L2PcInstance.java:17365)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.restore(L2PcInstance.java:7999)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.load(L2PcInstance.java:1316)
        at com.l2jserver.gameserver.network.L2GameClient.loadCharFromDisk(L2GameClient.java:581)
        at com.l2jserver.gameserver.network.clientpackets.CharacterSelect.runImpl(CharacterSelect.java:133)
        at com.l2jserver.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:70)
        at com.l2jserver.gameserver.network.L2GameClient.run(L2GameClient.java:1092)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)


Unclosed connection! Trace: com.l2jserver.gameserver.model.actor.instance.L2PcInstance.storeVisualArmors(L2PcInstance.java:17424)
java.lang.RuntimeException
        at com.l2jserver.L2DatabaseFactory.getConnection(L2DatabaseFactory.java:273)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.storeVisualArmors(L2PcInstance.java:17424)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.store(L2PcInstance.java:8276)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.store(L2PcInstance.java:9115)
        at com.l2jserver.gameserver.network.L2GameClient.saveCharToDisk(L2GameClient.java:376)
        at com.l2jserver.gameserver.network.L2GameClient$AutoSaveTask.run(L2GameClient.java:901)
        at com.l2jserver.gameserver.ThreadPoolManager$RunnableWrapper.run(ThreadPoolManager.java:93)
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
        at java.util.concurrent.FutureTask$Sync.innerRunAndReset(Unknown Source)

        at java.util.concurrent.FutureTask.runAndReset(Unknown Source)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(Unknown Source)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)

Unclosed connection! Trace: com.l2jserver.gameserver.model.actor.instance.L2PcInstance.checkIfExist(L2PcInstance.java:17397)
java.lang.RuntimeException
        at com.l2jserver.L2DatabaseFactory.getConnection(L2DatabaseFactory.java:273)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.checkIfExist(L2PcInstance.java:17397)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.storeVisualArmors(L2PcInstance.java:17417)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.store(L2PcInstance.java:8276)
        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.store(L2PcInstance.java:9115)
        at com.l2jserver.gameserver.network.L2GameClient.saveCharToDisk(L2GameClient.java:376)
        at com.l2jserver.gameserver.network.L2GameClient$AutoSaveTask.run(L2GameClient.java:901)
        at com.l2jserver.gameserver.ThreadPoolManager$RunnableWrapper.run(ThreadPoolManager.java:93)
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
        at java.util.concurrent.FutureTask$Sync.innerRunAndReset(Unknown Source)

        at java.util.concurrent.FutureTask.runAndReset(Unknown Source)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(Unknown Source)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)

 

 

 

Here are the concerned codes :

 

 

 

 

private void restoreVisualArmors()
{
	try
	{
		Connection con = L2DatabaseFactory.getInstance().getConnection();
		PreparedStatement statement = con.prepareStatement("SELECT * FROM character_visual_armors WHERE charId=?");
		statement.setInt(1, getObjectId());
		ResultSet rset = statement.executeQuery();
		if (rset.next())
		{
			isUsingVisualArmors(rset.getBoolean("isUsingVisual"));
			setVisualArmor(VisualArmors.Armor, rset.getInt("armor"));
			setVisualArmor(VisualArmors.Legs, rset.getInt("leggings"));
			setVisualArmor(VisualArmors.Feet, rset.getInt("feet"));
			setVisualArmor(VisualArmors.Gloves, rset.getInt("gloves"));
			setVisualArmor(VisualArmors.LHand, rset.getInt("lHand"));
			setVisualArmor(VisualArmors.Sword, rset.getInt("sword"));
			setVisualArmor(VisualArmors.Bow, rset.getInt("bow"));
			setVisualArmor(VisualArmors.Pole, rset.getInt("pole"));
			setVisualArmor(VisualArmors.Dual, rset.getInt("dualWeapons"));
			setVisualArmor(VisualArmors.BigSword, rset.getInt("bigSword"));
		}
		rset.close();
		statement.close();
	}

	catch (Exception e)
	{
		_log.log(Level.WARNING, "Could not restore " + getObjectId() + " visual armors data " + e.getMessage(), e);
	}
}

 

private void storeVisualArmors()
{
	if (!checkIfExist())
	{
		insertVisualArmors();
	}
	// UPDATE characters SET vitality_points=?,language=? WHERE charId=?";
	try
	{
		Connection con = L2DatabaseFactory.getInstance().getConnection();
		PreparedStatement statement = con.prepareStatement("UPDATE character_visual_armors SET isUsingVisual=?,armor=?,leggings=?,feet=?,gloves=?,sword=?,bow=?,pole=?,dualWeapons=?,bigSword=?,lHand=? WHERE charId=?");
		statement.setInt(1, isUsingVisualArmors() ? 1 : 0);
		statement.setInt(2, getVisualArmor(VisualArmors.Armor, true) == null ? 0 : getVisualArmor(VisualArmors.Armor, true).getItemId());
		statement.setInt(3, getVisualArmor(VisualArmors.Legs, true) == null ? 0 : getVisualArmor(VisualArmors.Legs, true).getItemId());
		statement.setInt(4, getVisualArmor(VisualArmors.Feet, true) == null ? 0 : getVisualArmor(VisualArmors.Feet, true).getItemId());
		statement.setInt(5, getVisualArmor(VisualArmors.Gloves, true) == null ? 0 : getVisualArmor(VisualArmors.Gloves, true).getItemId());
		statement.setInt(6, getVisualArmor(VisualArmors.Sword, true) == null ? 0 : getVisualArmor(VisualArmors.Sword, true).getItemId());
		statement.setInt(7, getVisualArmor(VisualArmors.Bow, true) == null ? 0 : getVisualArmor(VisualArmors.Bow, true).getItemId());
		statement.setInt(8, getVisualArmor(VisualArmors.Pole, true) == null ? 0 : getVisualArmor(VisualArmors.Pole, true).getItemId());
		statement.setInt(9, getVisualArmor(VisualArmors.Dual, true) == null ? 0 : getVisualArmor(VisualArmors.Dual, true).getItemId());
		statement.setInt(10, getVisualArmor(VisualArmors.BigSword, true) == null ? 0 : getVisualArmor(VisualArmors.BigSword, true).getItemId());
		statement.setInt(11, getVisualArmor(VisualArmors.LHand, true) == null ? 0 : getVisualArmor(VisualArmors.LHand, true).getItemId());
		statement.setInt(12, getObjectId());
		statement.execute();
	}
	catch (Exception e)
	{
		_log.log(Level.WARNING, "Could not store character " + getObjectId() + " visual armors data: ", e);
	}
}

 

private boolean checkIfExist()
{
	try
	{
		Connection con = L2DatabaseFactory.getInstance().getConnection();
		PreparedStatement statement = con.prepareStatement("SELECT charId FROM character_visual_armors WHERE charId=?");
		statement.setInt(1, getObjectId());
		try (ResultSet rset = statement.executeQuery())
		{
			if (rset.next())
			{
				return true;
			}

		}

	}
	catch (Exception e)
	{
		_log.log(Level.WARNING, "Could not restore " + getObjectId() + " visual armors data " + e.getMessage(), e);
	}
	return false;
}

 

 

How to solve these problems?

Thank You.

4 answers to this question

Recommended Posts

  • 0
Posted

All

 

	try
	{
		Connection con = L2DatabaseFactory.getInstance().getConnection();

 

has to be

 

	try (Connection con = L2DatabaseFactory.getInstance().getConnection())
	{

  • 0
Posted

SweeTs method is the thing to do, but is doable only if your project uses JDK 7.

 

Otherwise you have to use old methods, depending of your pack/chronicle :

- finally { L2DatabaseFactory.close(con); }

- finally { try { con.close(); } catch... }

Guest
This topic is now closed to further replies.


  • Posts

    • Good evening everyone! I wouldn't normally ask for help with something like this, but I'm honestly stuck and can't figure it out anymore. I have a C3 pack (I'll also include the link below since it took me a while to find a good one with everything needed to run it): (https://www.mediafire.com/file/glhnscql6hkd6ra/l2jnvc3_rev178_Greenhope_l2j_%2Bjava_%2Bsql.zip/file) The problem is that I'm completely stuck on one thing. No matter what I do, I can't log in. I keep getting a "wrong protocol" error. I've tried changing the protocol from 550–700 all the way to 1–999. I've tested many different C3 versions and every main system I could find, but I still haven't managed to log in successfully. I'm not sure if I'm doing something wrong when saving the .ini file after changing it to my server's IP address. If anyone could help me, I would really appreciate it. I'll keep the server online so that if someone is willing to assist, they can try logging in and help me figure out what's wrong. Server IP: 194.219.108.63 Thank you very much in advance to anyone who decides to take the time to help me. I'd really love to get this pack running properly and preserve it for the future.
    • Anosim Update   - New updated design is live - Free Numbers added on the mainpage - Use free numbers for activation - Receive SMS for free   ⸻   New Blog added Future news, updates and platform changes will be posted there   ⸻   Partner Section added New space for partners and integrations   ⸻   New Websites for Activation added   🇩🇪 Germany wg-gesucht.de dikidi.net 🇨🇭 Switzerland Tutti.ch Ricardo.ch 🇦🇺 Australia Gumtree.com.au 🇬🇧 UK Askable.com   ⸻   New Countries added for Activation   🇦🇷 Argentina 🇧🇬 Bulgaria 🇨🇲 Cameroon 🇭🇷 Croatia 🇬🇷 Greece 🇰🇿 Kazakhstan 🇲🇦 Morocco   ⸻   New Full Rent 🇬🇪 Georgia +995 Numbers Full Rent now available Real SIM Cards No VoIP   ⸻   Available now on https://anosim.net
    • Shadowsocks Released   World’s first Dedicated Mobile Proxy with Shadowsocks support. Dedicated 4G/5G mobile proxies can now be used with Shadowsocks.   New dedicated mobile proxy locations added: 🇩🇪 Germany (Leipzig) 🇳🇬 Nigeria (Lagos) 🇺🇸 USA (South Haven)   Also available: 🌐 Residential Proxies from $1/GB   ⚡️ Datacenter Proxies from $0.50/GB   Available now on Proxied.   https://proxied.com For Free Trials, write us a DM with your registered E-mail.
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..