Grade Penalty

[Inken]

Hi again!

Theres a problem with Grade Penalty. Doesn't matter what level is my character, if he wears S84 Grade he take Grade Penalty lvl 1, if he wears B Grade, he also take Grade Penalty lvl 1.

I still remember korean patchnotes in 2009, and there was 4 levels of a grade penalties!

If someone have got skilldata.txt, skill_pch.txt, ai.obj with all of grade penalty levels working, i'll pray for you every night!

Thnx in advance!

[mcbigmac]

Skill 239.

effect:p_remove_grade_penalty.

acquired by all skill base classes based on level.

 

your skilacquire is messed.

 

This is NOT an issue with the base leaked Gracia Final off pack.

 

...your other issue also doesn't exist and has NOTHING to do with ai.obj.

 

You need to get the cleanly shared GF leak pack.

[Inken]

Hm... in my skillacquire i can't find p_remove_grade_penalty... And how is this effect bound with penalty debaff?

Hit me if i'm wrong, but here are that skill

skill_begin skill_name = [s_grade_penalty] /* [그레이드 페널티] */ skill_id = 4267 level = 1 operate_type = P magic_level = 1 self_effect = {} effect = {} multi_class = 0 skill_end

and this effect in skilldata.txt, but there are only 1st level of debuff, unlike for example weight_penalty, there are 4 level of debuff...

[mcbigmac]

seriously, how the -beep- do you run a server?

 

...yes i got the effect name wrong, but still. you should go consider l2j or something.

 

skill_begin	skill_name = [s_expertise_d]	/* [엑스퍼티즈 D] */	skill_id = 239	level = 1	operate_type = P	magic_level = 20	self_effect = {}	effect = {{p_remove_equip_penalty;d}}	multi_class = 0	skill_end
skill_begin	skill_name = [s_expertise_c]	/* [엑스퍼티즈 C] */	skill_id = 239	level = 2	operate_type = P	magic_level = 40	self_effect = {}	effect = {{p_remove_equip_penalty;c}}	multi_class = 0	skill_end
skill_begin	skill_name = [s_expertise_b]	/* [엑스퍼티즈 B] */	skill_id = 239	level = 3	operate_type = P	magic_level = 52	self_effect = {}	effect = {{p_remove_equip_penalty;b}}	multi_class = 0	skill_end
skill_begin	skill_name = [s_expertise_a]	/* [엑스퍼티즈 A] */	skill_id = 239	level = 4	operate_type = P	magic_level = 61	self_effect = {}	effect = {{p_remove_equip_penalty;a}}	multi_class = 0	skill_end
skill_begin	skill_name = [s_expertise_s]	/* [엑스퍼티즈 S] */	skill_id = 239	level = 5	operate_type = P	magic_level = 76	self_effect = {}	effect = {{p_remove_equip_penalty;s}}	multi_class = 0	skill_end
skill_begin	skill_name = [s_expertise_s80]	/* [엑스퍼티즈 S80] */	skill_id = 239	level = 6	operate_type = P	magic_level = 80	self_effect = {}	effect = {{p_remove_equip_penalty;s80}}	multi_class = 0	skill_end
skill_begin	skill_name = [s_expertise_s84]	/* [엑스퍼티즈 S84] */	skill_id = 239	level = 7	operate_type = P	magic_level = 84	self_effect = {}	effect = {{p_remove_equip_penalty;s84}}	multi_class = 0	skill_end

 

fighter_begin							
skill_begin	/* [럭키] */	skill_name = [s_lucky]	get_lv = 1	lv_up_sp = 0	auto_get = true	item_needed = {}	skill_end
skill_begin	/* [엑스퍼티즈 D] */	skill_name = [s_expertise_d]	get_lv = 20	lv_up_sp = 0	auto_get = true	item_needed = {}	skill_end
skill_begin	/* [엑스퍼티즈 C] */	skill_name = [s_expertise_c]	get_lv = 40	lv_up_sp = 0	auto_get = true	item_needed = {}	skill_end
skill_begin	/* [엑스퍼티즈 B] */	skill_name = [s_expertise_b]	get_lv = 52	lv_up_sp = 0	auto_get = true	item_needed = {}	skill_end
skill_begin	/* [엑스퍼티즈 A] */	skill_name = [s_expertise_a]	get_lv = 61	lv_up_sp = 0	auto_get = true	item_needed = {}	skill_end
skill_begin	/* [엑스퍼티즈 S] */	skill_name = [s_expertise_s]	get_lv = 76	lv_up_sp = 0	auto_get = true	item_needed = {}	skill_end
skill_begin	/* [엑스퍼티즈 S80] */	skill_name = [s_expertise_s80]	get_lv = 80	lv_up_sp = 0	auto_get = true	item_needed = {}	skill_end
skill_begin	/* [엑스퍼티즈 S84] */	skill_name = [s_expertise_s84]	get_lv = 84	lv_up_sp = 0	auto_get = true	item_needed = {}	skill_end

[Inken]

I found this code. So my script is alright, but problem are still there, maybe it's problem with ext.

you should go consider l2j or something

Despite that i'm novice, i'm trying very hard to make myself good stable server. And your opinion about what i should consider costs nothing.

 

Anyway. Thnx for help.

[mcbigmac]

... so ask in your ext's forum or creator.

 

[Sighed]

You pay money for an ext and you don't use the support provided by the creator ? Well at least, if its the creator and not a reseller, that doesn't have any idea about fixing anything.

[Inken]

mcbigmac already helped me. GTREAT THNX for him!

Bug in l2server, not in scripts. All penalties works great!

 

Plz close this topic =)

[mcbigmac]

error is here..

88C759

 

creature + 22BE for armor checking?  seems very odd - should investigate that.

::IsInItemGrade for weapons by a quick check of it's contents - which itself calls  ::GetWeaponGradePenalty to return level difference of equipped gear vs expertise skill- so yay ncsoft for ignoring that completely!

 

Seems to move bools 0/1 to the stack instead of the respective armor/weapon penalty level, thus only lvl 1 appearing.

 

Seems a bit weird to me, since i noticed ArmorGrade NEVER appears.

Easy fix would be hooking 88C7D0 and fixing ze packet yourself with correct level checking quickly.

Since penalties themselves seem solid and correct after testing.

 

[Warmaster]

Locked