xXObanXx

so... i've made some changes...

		if (activeChar.isInBoat())
		{
			if (Config.COORD_SYNCHRONIZE == 2)
			{
				dx = _x - activeChar.getInVehiclePosition().getX();
				dy = _y - activeChar.getInVehiclePosition().getY();
-				// dz = _z - activeChar.getInVehiclePosition().getZ();
+				dz = _z - activeChar.getInVehiclePosition().getZ();
-				diffSq = ((dx * dx) + (dy * dy));
+				diffSq = ((dx * dx) + (dy * dy) + (dz * dz));
				if (diffSq > 250000)
				{
					sendPacket(new GetOnVehicle(activeChar.getObjectId(), _data, activeChar.getInVehiclePosition()));
				}
			}
			return;
		}

and i've added this option:

			if (Config.COORD_SYNCHRONIZE == 3)
			{
				activeChar.setXYZ(_x, _y, _z);
				return;
			}

i saw that on Config.COORD_SYNCHRONIZE == -1 it's saying only the Z coord will synch with the server... by using the code activeChar.setXYZ(realX, realY, _z);

so if this code is synchronizing only Z... what will happened if i will make it like the code above?!

Edit: i tried and something else..

-				if (((Math.abs(dz) > 200) && (Math.abs(dz) < 1500) && (Math.abs(_z - activeChar.getClientZ()) < 800))
+				if (((Math.abs(dx) > 200) && (Math.abs(dx) < 1500) && (Math.abs(_x - activeChar.getClientX()) < 800)) && ((Math.abs(dy) > 200) && (Math.abs(dy) < 1500) && (Math.abs(_y - activeChar.getClientY()) < 800)) && ((Math.abs(dz) > 200) && (Math.abs(dz) < 1500) && (Math.abs(_z - activeChar.getClientZ()) < 800)))
				{
-					activeChar.setXYZ(realX, realY, _z);
+					activeChar.setXYZ(_x, _y, _z);
+					realX = _x;
+					realY = _y;
					realZ = _z;
				}

i tested it and i can said that the cords have a better synch than before but not actually the same at all times..!

so these are the coords

You could try to leach ValidatePostion.java packets from other packs, cause formulas differ among projects

hmmm... i will search tomorrow and i will reply the results!

What he says is that the client reads the l2 world differently from the server, if i am not mistaken.

so the only solution to synchronize these things is just a good geodata?

ur talking about the validatePosition packet...

 

First of all its sooooo hard coded, you wont ever make a worty modification in it...

Secondly the only solution to this is geodata, but imo, the serverXYZ != clientXYZ or serverIntention != clientIntention isnt even close to a problem

can you explain it better? :P

i have geodata and pathnodes and the Geodata config is setted to 2

Hello my friends again...

so i enabled the DEBUG configs today and i saw that the client position and server position are not the same and in some cases an error was appearing..!

so how can i make the server and client to have the same char position?!

hm. . .

Then has no sense to not load the data from the db coz in the code seems fine, otherwise u should get some errors in console O.o

and yes... doesn't work... no errors on console.. only a message on char "wrong usage: join time or event time invalid"

U should use the command "admin_rai_load" before using the autoevent command, or add loadData() at the start of this method "public static void autoEvent()"

like that?

	public static void autoEvent()
	{
		if (startAutoJoin())
		{
			loadData();
			if (_joinTime > 0)
			{
				waiter(_joinTime * 60 * 1000); // minutes for join event
				_log.warning("Place 1 OK!");
			}
.....

Hello guys!

so i've put the Raid event that have on l2jserver forum... Click

so i was looking the code... and i saw that this event's codes etc. are c/p from the CTF Event (by FFs)

all are ok on eclipse...! the problem is..! the code is not reading from the sql table (like CTF event)

what i mean? when i'm pressing  //rai_autoevent a message appears that is saying the join time and event time are invalid (maybe it's reading the _joinTime = 0;)

don't really know..!

so can you help me to make the event to working well?! :)

my Raid.java is this (Latest unstable High Five L2J Pack)

so the problem solved guys... you can lock this topic..! thank you!!

ok guys i'm on the way to test these things...

i will update the post in some minutes!

edit: the "hide" option doesn't work... i think cause check for hide players but doesn't doing something to make him visible..!

about the summon... i can't summon pets like Fernir etc. but i can summon servitors like Mew the Cat (Archmage) or Reanimated Man (Soultaker)

Ye, I typed that too fast... that thing about storing pet buffs after unsummon shouldn't exist coz then, even if you remove the buff before unsumonning it, they could unsummon the pet by theirselves and then summon and be inside the event with buffs. I think it was a config to turn it off/on, should be off xd

 

no :s

ok.. i'll test it tomorrow!!

if it's unused just remove that line

the "return;" doesn't need?

So if the "bug" that I pointed still exists, why is it useless? For example: full buff server (but the event just gives you 4-5 buffs), you got your full buffs in your pet and you unsummon it, you register to the event, you get teleported, then you re-summon your pet and bam! full buffed  :rage:

the best way for a "stable" event is to fix all the possible bugs like that... to exclude every way from the player to get buffs outside from the event..!

@topic author, I want the use of eInvisible.

hmmm.... i don't think it is doing something :P

cause of @SuppressWarnings("unused")

and i think it's not working..!

a think a "return;" could work..! or not? :P

 

About hide, I want original code and where it is used. What you did is wrong. Before the point of that code was to retrieve if player was under a HIDE effect, now you messed.

Original line:

L2Effect eInvisible = _player.getFirstEffect(L2EffectType.HIDE);

replaced with:

AbnormalType eInvisible = AbnormalType.HIDE;

the whole code is:

                // If player is invisible, make them visible
		if (_player.getAppearance().getInvisible())
		{
			@SuppressWarnings("unused")
			AbnormalType eInvisible = AbnormalType.HIDE;
		}

Haha :D.

 

About HIDE stuff, what is it supposed to do ? What is the original code, what do you want to do ?

about hide i replaced the original code with this

AbnormalType eInvisible = AbnormalType.HIDE;

(didn't test it yet)

Replace the whole loop for :

 

summon.stopAllEffects();

Finale if you want to access getEffectList(), and notably if you know it's a buff, debuff, etc, you should access it via the internal map. For instance, retrieveing all buff effect types should be called like that :

summon.getEffectList().getBuffs().values()

An important note, it returns BuffInfo type.

correct me if i'm wrong... is it ok?

from this:

if (player.getSummon() != null)
{
L2Summon summon = player.getSummon();
for (BuffInfo e : summon.getEffectList().getEffects())
{
if (e != null)
{
e.stopAllEffects(false);
}
}

if (summon instanceof L2PetInstance)
{
summon.unSummon(player);
}
} 

to this:

if (player.getSummon() != null)
{
L2Summon summon = player.getSummon();
summon.stopAllEffects();
summon.getEffectList().getBuffs().values();

if (summon instanceof L2PetInstance)
{
summon.unSummon(player);
}
}

for (BuffInfo e : summon.getEffectList().getEffects())
{
if (e != null)
{
e.stopAllEffects(false);
}
}

working..! thank you dude! :)

 

Try with

CharEffectList e : summon.getEffectList()

error (Can only iterate over an array or an instance of java.lang.Iterable)

on summon.getEffectList()

What about changing AbstractEffect by L2Effect? Last rev of unstable or stable...?

unstable... and L2Effect renamed with AbstractEffect..!

Hello... so i updated my pack (L2j) with the latest revision (skill and effect system complete rework)

and i have these problems on CTF.java:

AbstractEffect eInvisible = _player.getFirstEffect(L2EffectType.HIDE);

AbnormalType eInvisible = AbnormalType.HIDE;

i will appreciate your help! :)

Compiled.. First problem when i open //admin every tab try to open ask me if im sure to execute command ... (admin7 etc..)

this is from AdminHandlers folder...

i can help you fix it if you want by adding me on skype..!

just pm me your skype and i will accept you in some minutes!

i edit to this now its ok. (from _player.broadcastPacket(new SocialAction(_player, 16)); // amazing glow )

 

Lets try Compile ! Many Warrings (!). Lets see.

better resolve all the warnings and then try to compile..!

just replace

sendPacket(new SystemMessage(SystemMessageId.YOU_CANNOT_MOUNT_A_STEED_WHILE_HOLDING_A_FLAG));

with this

activeChar.sendMessage("You cannot mount a steed while holding a flag.");

put this on MasterHandler

  (Config.L2JMOD_ALLOW_WEDDING ? Wedding.class : null),
+ (Config.CTF_ALLOW_VOICE_COMMAND ? CTFCmd.class : null),

about

_player.broadcastPacket(new SocialAction(_player.getObjectId(), 16)); // amazing glow

try to resolve them with the quick fix option