Jump to content

<< Masterio >>

Members
  • Posts

    252
  • Credits

  • Joined

  • Last visited

  • Days Won

    6
  • Feedback

    0%

Everything posted by << Masterio >>

  1. 3.8.5 relesed. Fxed many bugs. I recommend reinstall all previous version for this one ;) It is beta but i've hope I not created new bugs ;)
  2. DO NOT DOWNLOAD 3.7.6+, it is wrong calculate the ranks. sorry for this missing. It will be fixed ASAP.
  3. The best way to remove old code is: 1. Remove old classes. It is mean remove masteriopack and imageconverter package from core. 2. Restore from repository all required classes. Class names are the same like the diff patch names (Of course with out version info). 3. If you have no repository access, then remove old code taged with: "// Rank PvP System by Masterio" (I prefer 2 solution). (Eclipse: Ctrl+H help you find this code). You can compare original classes with edited by me and manualy replace to original. Then you can install it again from new patches or raw files. Remember, if you install it on other l2j pack, or to older revision, you should install it manually.
  4. Thanks for raport Amida Nguyen. New release have null checkers. Problem appeared after ConcurrentHashMap implementation, now should works.
  5. O_o, on 07 Nov 2013 - 12:18 PM, said: One more idea : to display players rank at title and for them to can't remove or change it Will you do and this ? maybe :)
  6. new release, have fun. arrer try to update mysql database to 5.5+
  7. I have not time for fit it to all chronicles. It is easy, so mid skilled programmer cad do it ;)
  8. It should be configured in server, probably in xml files. do you mean rebellion?
  9. checked, all works fine in rev. 3.7.6 RankPvpSystemConfig: LegalKillForInnocentKillEnabled = False ... PvpRewardForInnocentKillEnabled = False ... RankRewardForInnocentKillEnabled = False Are you checked all this options?
  10. I fixed describe. ;) For now Custom PvP zones should be defined as ZONE_PVP (in H5 server).
  11. To: DeathSpank287 Try to use Freya edition, it the same like h5, but it uses older core structure. It should be fine. (BTW i will add raw classes without diff patches, it should help ppls) To: gelimeng2008 Yes ican upload it on MEGA. I will do that witch new rev. To: Amida Nguyen I will check it.
  12. It should update at the selected hour in config. BTW i will check it.
  13. this fix is not important for now it will be released in new rev.
  14. valanths1990 CommunityBoard: // Rank PvP System by Masterio else if(command.startsWith("_bbsrps")) { RankPvpSystemBBSManager.getInstance().parsecmd(command, activeChar); } RankPvpSystemBBSManager: @Override public void parsecmd(String command, L2PcInstance activeChar) { if(RankPvpSystemConfig.RANK_PVP_SYSTEM_ENABLED && RankPvpSystemConfig.TOP_LIST_ENABLED) { if(command.startsWith("_bbsrps:")) { int page = 0; try { page = Integer.parseInt(command.split(":", 2)[1].trim()); } catch(Exception e) { log.info(e.getMessage()); page = 0; } separateAndSend(RankPvpSystemBBSHtm.getPage(activeChar, page), activeChar); } } else if(!RankPvpSystemConfig.TOP_LIST_ENABLED) { ShowBoard sb = null; sb = new ShowBoard("<html><body><br><br><center>Community Board Top List is disabled in config file</center><br><br></body></html>", "101"); activeChar.sendPacket(sb); activeChar.sendPacket(new ShowBoard(null, "102")); activeChar.sendPacket(new ShowBoard(null, "103")); sb = null; } } Fixed.
  15. 1. If you have old RPS, remove it. (restore from svn). 2. Install from diff patches (for frozen). 3. Have fun.
  16. I think it is correct: else if(command.startsWith("_bbsrps") && RankPvpSystemConfig.RANK_PVP_SYSTEM_ENABLED && RankPvpSystemConfig.TOP_LIST_ENABLED) { RankPvpSystemBBSManager.getInstance().parsecmd(command, activeChar); } else if (command is fetched AND rank pvp system enabled AND top list enabled) { do something... } If one of conditions returns false, the code inside will be not executed. Example: if TOP_LIST_ENABLED is FALSE then the code inside will be skipped.
  17. Because the RPS is multi chronicle i dont want waste time for H5 features. But of course you can add it, it is simple:D
  18. I will apply concurrent hashmap. do not download 3.7.5, new revision today. PS. I will fit this code when I will finish H5 version. (soon)
  19. marik20001 Probably you try add this diff files into lower chronicle than H5 or other l2jserver. You should check methods names and parameters what are overrided in command handlers. IUserCommandHandlerPvpInfo should be correctly implemented from IUserCommandHandler interface. valanths1990 You can restore the oryginal class from repo and then apply my patch. THat way is faster i think. (BTW I am too lazy ... ;))
  20. Thanks again, i will apply it in next rev. ;) It should be like: for (Map.Entry<Integer, Rank> e : rankList.entrySet()) And btw, is exist a Map what allows you add value on selected position? Example: _map.insert(position, key, value);
  21. So in this case, standard Map/List will be correct and i can remove FastMap from this pack, i think. ConcurrentHashMap & CopyOnWriteArrayList can be useful but now i am little confused what will be better for me (i need more knowledge). Anyway thanks for help ;)
  22. Thanks for this post UnAfraid, but like i sad some time ago i still learn java. I will try apply your clues in my system ;) It is better for debug for me if it is in Core packages. So where i should use thread-safe? I use that public variable only in L2PcInstance, reason: I don't want change original code too much (adding getter and setter will add too much code) I use inner methods for obtain inner fields, because i think it's look better, and cleaner :) _killersList.add(killer); // or getKillerList().add(killer); ...but now i think the first line looks better than third line. It is applied right now. About _ (underscore), yes i know this rule ;) but some code is auto-generated in eclipse, so mostly i don't look into this methods. About e.printStackTrace(), it will be changed for Logger. Can you explain what do you mean? What mean safe? Finally, thanks for check my work. I am really glad :)
×
×
  • Create New...