L2PICK.com — Lineage 2 Private Server List

Illegal skill check help with code

Followers

gmakhs

Members

OfflineStatus
MembersGroup
233Posts
0Solutions
0Reputation
10,050Member No
0Days Won
08/03/2007Joined
Offline Status
Members Group
233 posts
0 Badges
0 Reputation
10,050 Member No
0 Days Won
08/03/2007 Joined

N/A 0 0 0

May 26, 201016 yr

hi i have this code in a forum and im trying change it for epilogue if anyone can help i thing something like that hould be commited becouse its must to every pvp server thanks for you help

Code:

Index: /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java

===================================================================

--- /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 153)

+++ /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 178)

@@ -315,4 +315,8 @@

         TvTEvent.onLogin(activeChar);

         CrownManager.getInstance().checkCrowns(activeChar);

+        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)

+        {

+        	activeChar.checkIlegalSkills();

+        }

	}



Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java

===================================================================

--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 88)

+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 178)

@@ -71,5 +71,5 @@

     {

         String[] commandStr = command.split(" ");

-        String actualCommand = commandStr[0]; // Get actual command

+        String actualCommand = commandStr[0];



         String cmdParams = "";

@@ -256,4 +256,9 @@

                     content.append("Change Subclass:<br>Which of the following sub classes would you like to change?<br>");

                     int classIndex = 1;

+

+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)

+                    {

+                    	player.checkIlegalSkills();

+                    }



                     for (Iterator<SubClass> subList = iterSubClasses(player); subList.hasNext();)

@@ -375,4 +380,9 @@

                         + CharTemplateTable.getClassNameById(player.getActiveClass()) + "</font>.");



+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)

+                    {

+                    	player.checkIlegalSkills();

+                    }

+

                     player.sendPacket(new SystemMessage(SystemMessageId.SUBCLASS_TRANSFER_COMPLETED)); // Transfer completed.

                     break;

@@ -410,4 +420,9 @@



                         player.sendPacket(new SystemMessage(SystemMessageId.ADD_NEW_SUBCLASS)); // Subclass added.

+

+                        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)

+                        {

+                        	player.checkIlegalSkills();

+                        }

                     }

                     else

Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java

===================================================================

--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 161)

+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 178)

@@ -10163,3 +10163,69 @@

		return _currentSkillWorldPosition;

	}

+

+	public void checkIlegalSkills()

+	{

+		boolean LegalSkill = false;

+

+		if (!isGM())

+		{

+			Collection<L2SkillLearn> skillTree = SkillTreeTable.getInstance().getAllowedSkills(getClassId());

+

+			for (L2Skill skill : getAllSkills())

+			{

+				int skillid = skill.getId();

+

+				LegalSkill = false;

+

+				for (L2SkillLearn temp : skillTree)

+				{

+					if (temp.getId() == skillid)

+						LegalSkill = true;

+				}

+

+				if (isCursedWeaponEquiped() && skillid == CursedWeaponsManager.getInstance().getCursedWeapon(_cursedWeaponEquipedId).getSkillId())

+				{

+					LegalSkill = true;

+				}

+

+				if (getClan() != null && (skillid >= 370 && skillid <= 391))

+				{

+					LegalSkill = true;

+				}

+

+				if (getClan() != null && (skillid == 246 || skillid == 247))

+				{

+					if (getClan().getLeaderId() == getObjectId())

+						LegalSkill = true;

+				}

+

+				if (skillid >= 1312 && skillid <= 1322)

+				{

+					LegalSkill = true;

+				}

+

+				if (skillid >= 1368 && skillid <= 1373)

+				{

+					LegalSkill = true;

+				}

+

+				if (skillid >= 3000 && skillid < 7000)

+				{

+					LegalSkill = true;

+				}

+

+				if (Config.ALLOWED_SKILLS_LIST.contains(skillid))

+				{

+					LegalSkill = true;

+				}

+

+				if (!LegalSkill)

+				{

+					removeSkill(skill);

+					sendMessage("[sVR]: Ilegal skill detected: "+skill.getName()+".");

+					sendMessage("[sVR]: The ilegal skill has been removed.");

+				}

+			}

+		}

+	}

}

Index: /trunk/Game/java/net/sf/l2j/Config.java

===================================================================

--- /trunk/Game/java/net/sf/l2j/Config.java (revision 136)

+++ /trunk/Game/java/net/sf/l2j/Config.java (revision 178)

@@ -589,4 +589,7 @@

     public static int                  CHAMPION_REWARD_ID;

     public static int                  CHAMPION_REWARD_QTY;

+    public static boolean              CHECK_SKILLS_ON_ENTER;

+    public static String               ALLOWED_SKILLS;

+    public static FastList<Integer>    ALLOWED_SKILLS_LIST = new FastList<Integer>();



     /** Events */

@@ -616,12 +619,12 @@

     public static String               GAME_VERSION;

     public static String               BUILD_DATE;

-    

+

     /** Data Version */

     public static String               DATA_VERSION;



     /** HexID */

-    public static int                 SERVER_ID;

-    public static byte[]              HEX_ID;

-    

+    public static int                  SERVER_ID;

+    public static byte[]               HEX_ID;

+

     /** Custom */

     // Comming Soon !

@@ -1324,4 +1327,11 @@

                 CHAMPION_REWARD_ID                           = Integer.parseInt(Mods.getProperty("ChampionRewardItemID", "6393"));

                 CHAMPION_REWARD_QTY                          = Integer.parseInt(Mods.getProperty("ChampionRewardItemQty", "1"));

+                CHECK_SKILLS_ON_ENTER                        = Boolean.parseBoolean(Mods.getProperty("CheckSkillsOnEnter", "False"));

+                ALLOWED_SKILLS                               = Mods.getProperty("AllowedSkills", "541,542,543,544,545,546,547,548,549,550,551,552,553,554,555,556,557,558,617,618,619");

+                ALLOWED_SKILLS_LIST                          = new FastList<Integer>();

+                for (String id : ALLOWED_SKILLS.trim().split(","))

+                {

+                	ALLOWED_SKILLS_LIST.add(Integer.parseInt(id.trim()));

+                }

             }

             catch (Exception e)

@@ -1493,6 +1503,6 @@

                 Custom.load(is);

                 is.close();

-                

-                // Comming Soon

+

+                // Commgin Soon !

             }

             catch (Exception e)

Matim

Legendary Member

OfflineStatus
Legendary MemberGroup
4,504Posts
0Solutions
2Reputation
43,010Member No
1Days Won
17/02/2009Joined
Offline Status
Legendary Member Group
4.5k posts
1 Badges
2 Reputation
43,010 Member No
1 Days Won
17/02/2009 Joined

N/A 0 0 0

May 26, 201016 yr

And whats wrong with this code?

xAddytzu

Members

OfflineStatus
MembersGroup
2,395Posts
1Solutions
3Reputation
26,562Member No
1Days Won
10/08/2008Joined
Offline Status
Members Group
2.4k posts
1 Solutions
0 Badges
3 Reputation
26,562 Member No
1 Days Won
10/08/2008 Joined

N/A 0 0 0

May 26, 201016 yr

Any errors ?

gmakhs

Members

OfflineStatus
MembersGroup
233Posts
0Solutions
0Reputation
10,050Member No
0Days Won
08/03/2007Joined
Offline Status
Members Group
233 posts
0 Badges
0 Reputation
10,050 Member No
0 Days Won
08/03/2007 Joined

N/A 0 0 0

May 26, 201016 yr

Author

it not work on l2j server epilogue

xAddytzu

Members

OfflineStatus
MembersGroup
2,395Posts
1Solutions
3Reputation
26,562Member No
1Days Won
10/08/2008Joined
Offline Status
Members Group
2.4k posts
1 Solutions
0 Badges
3 Reputation
26,562 Member No
1 Days Won
10/08/2008 Joined

N/A 0 0 0

May 26, 201016 yr

it not work on l2j server epilogue

:| do you have errors ?

gmakhs

Members

OfflineStatus
MembersGroup
233Posts
0Solutions
0Reputation
10,050Member No
0Days Won
08/03/2007Joined
Offline Status
Members Group
233 posts
0 Badges
0 Reputation
10,050 Member No
0 Days Won
08/03/2007 Joined

N/A 0 0 0

May 27, 201016 yr

Author

i can't use the code on eclipse it says that invalid path

xAddytzu

Members

OfflineStatus
MembersGroup
2,395Posts
1Solutions
3Reputation
26,562Member No
1Days Won
10/08/2008Joined
Offline Status
Members Group
2.4k posts
1 Solutions
0 Badges
3 Reputation
26,562 Member No
1 Days Won
10/08/2008 Joined

N/A 0 0 0

May 27, 201016 yr

i can't use the code on eclipse it says that invalid path

PUT IT MANUAL, AFTER OPEN ECLIPSE AND CHECK IT..DAMN

Matim

Legendary Member

OfflineStatus
Legendary MemberGroup
4,504Posts
0Solutions
2Reputation
43,010Member No
1Days Won
17/02/2009Joined
Offline Status
Legendary Member Group
4.5k posts
1 Badges
2 Reputation
43,010 Member No
1 Days Won
17/02/2009 Joined

N/A 0 0 0

May 27, 201016 yr

Use search, read our Guides and Tutorials, its so hard?

gmakhs

Members

OfflineStatus
MembersGroup
233Posts
0Solutions
0Reputation
10,050Member No
0Days Won
08/03/2007Joined
Offline Status
Members Group
233 posts
0 Badges
0 Reputation
10,050 Member No
0 Days Won
08/03/2007 Joined

N/A 0 0 0

May 28, 201016 yr

Author

ofcourtse i putted it manual but build failed... this code is for interlude as i know so something must be wrong

Matim

Legendary Member

OfflineStatus
Legendary MemberGroup
4,504Posts
0Solutions
2Reputation
43,010Member No
1Days Won
17/02/2009Joined
Offline Status
Legendary Member Group
4.5k posts
1 Badges
2 Reputation
43,010 Member No
1 Days Won
17/02/2009 Joined

N/A 0 0 0

May 28, 201016 yr

ofcourtse i putted it manual but build failed... this code is for interlude as i know so something must be wrong

You expect help with error..without error log? Smart.

Create an account or sign in to comment

Followers

Go to topic listing

NPC Temples Pack with Effects (Interlude).7z

Well i checked the NPC IDs as you suggested.

The server-side NPC IDs match the entries in npcgrp.dat and npcname-e.dat exactly (40040–40049), with no duplicates or display-ID substitutions. the rabbit appearance was occurring in a client that didn't contain those custom NPC records. However, the client crash is a separate issue.
i tested NPC 40042 using LineageNPCs6Script.effectnpc_a and the Kain_van_Holter_m00 mesh.

💥When that NPC came into view, my standard Interlude client crashed.

After inspecting the pack, i noticed that :

1. LineageNpcs6.ukx, LineageNPCs6Script.u and LineageNPCs6Effect.u use a non-standard package header (Lineage2Ver11 followed by 0xD839), rather than the standard Interlude Lineage2Ver111 format.

The included L2Mid packages use Lineage2Ver821.
Several NPC entries reference additional packages that aren't included in the archive.
my environment is Lucera2 Interlude with a standard Interlude client.
if you could you please clarify:

1.Were the LineageNpcs6 files made for a protected or modified Interlude client?
2.Do they require a specific encryption key, DLL or client patch?
3.Are standard Interlude-compatible versions of these files available?
4.Are the missing model packages supposed to be included separately?

i would like to use the actual custom NPC models, rather than replacing them with retail models.
Thanks for your help!

By d1ctatorTV · 23 minutes ago23 min
WTS / WTB L2REBORN

⚔️ ADENAVIP — L2 GAME SHOP ⚔️
🔥 BUY & SELL ADENA ON L2REBORN! 🔥
Looking to buy or sell Adena? You've come to the right place!
💰 WE BUY & SELL:
Adena
In-game currency
Valuable items
Epic items & equipment
⚡ Fast transactions
🛡️ Safe and reliable deals
🤝 Friendly support
💎 Competitive prices
🌍 SERVER: L2REBORN
📩 CONTACT US ON DISCORD:
ADENAVIP
🔥 Your trusted partner in Lineage 2 trading!
BUY SMART. SELL FAST. PLAY STRONG! ⚔️

By addelka · 1 hour ago1 hr
Buy Chatgpt | Gemini | Any Premium Subscription at Klouditem

🛠️ The ultimate digital toolkit: Cursor AI for coding, Claude & ChatGPT for reasoning, and Canva Pro for graphics. Instant automated delivery!

By klouditem · 1 hour ago1 hr
Is L2J's gameserver security indefinitelly compromised ?

It's very easy to call everyone an AI slop vibe coder nowadays when they disagree with you. Let me educate you a bit on the history of Java emulation of Lineage 2 to make my point clearer.

L2J took a very bad turn around 2010.

Around that date, most of people people who were capable programmers that created L2J and L2JFree simply for fun, were starting to get replaced by people who were primarily server-owners or paid-developers who simply wanted either recognition or to steer the project towards personal agendas.

A lot of the L2JServer code got rewritten back then, by so called "senior developers" who decided to "move things to the Datapack" and other niche ideas. This "rewrite" of older code lead to the introduction of most exploits that work today and that AI keeps finding.

For example, around that time, Zoey76 who was leading L2JServer decided to rewrite the favourites module of the community board. That code was perfectly fine, and he rewrote it in a very bad way that introduced a memory leak that can be triggered by a malicious user that can lead to OOM on the server. A lot of packs who forked from L2JServer both private and public have this issue nowadays.

Generally the quality of the developers after 2010 went down because most of these people were qualified asslickers and not qualified developers.

The same rewrite era led to the introduction of a nasty adena dupe exploit that is currently working in many servers using re-bidding from a clan leader that changed a clan and then cancelling the bit. This was fixed, new developers regressed it.

And it's not just the era of L2JServer's 2010+ years. Later on Mobius took control of the scene and he has done a lot of such mistakes too. And it's not just open source. L2Scripts, check the 2020 leak, you can craft manor packets to plant baium rings instead of crops. aCis has messed up zone system, you can become invulnerable in multiple ways and nobody can kill you too. I can go on and on about how insecure ALL the packs are.

"But if you point an AI to the code it will tell you the security issues". Note quietly. AI is a reflection of your skills, if you dont know where to look, how to look, how the mechanics of the code work it wont find anything. There are people who use AI and people who CAN USE AI. It's different.

The reality is for someone who knows what he is doing and an AI agent, it's easy to "demote" the security of all these decent packs to "mediocre".

In some months I'm planning to open a server of my own. I'm terrified to the idea of not knowing all my security vulnerabilities and of a hacker who can come and TRASH it for fun ...

These are existing risks for all of us, that a lot of you dont seem to be taking under consideration ...

By aguy · 1 hour ago1 hr
Is L2J's gameserver security indefinitelly compromised ?

It couldn't have been explained better.
People who consider themselves senior developers because they know how to write text to an AI, whose QA is simply to jump in and see if it works without understanding the actual mechanics or what they entail, is frustrating.
Furthermore, treating developers as if they're nothing because AI can do the same things we do is simply ridiculous.
Imagine you have to create a recipe for a contest and you have zero cooking experience, and your opponent is a professional chef. Even using AI, the odds of winning are low. The same applies here.

By rexen · 2 hours ago2 hr

Illegal skill check help with code

Featured Replies

Create an account or sign in to comment

Posts

NPC Temples Pack with Effects (Interlude).7z

WTS / WTB L2REBORN

Buy Chatgpt | Gemini | Any Premium Subscription at Klouditem

Is L2J's gameserver security indefinitelly compromised ?

Is L2J's gameserver security indefinitelly compromised ?

Topics

Lagacy L2REBORN

Black Chaotic Weapons

🤖 HeistBot

NPC Temples Pack with Effects (Interlude).7z

L2 Good Vs Evil !

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)