xR3spawN Posted May 17, 2010 Posted May 17, 2010 nop, theres an unclosed connecton in my code. go to ColorNameManager.loadValues and at the botton of the method add try{ if(con != null) con.close(); } catch(Exception e){ if(Config.DEBUG) e.printStackTrace(); } where exactly i must add this? cause i am a little stupid in java Quote
`Яomeo` Posted May 18, 2010 Posted May 18, 2010 if anyone want go to my topics and see my prob plsss Quote
B1ggBoss Posted May 18, 2010 Author Posted May 18, 2010 where exactly i must add this? cause i am a little stupid in java go to ColorNameManager.java find the method called public static void loadValues() at the end of the method (before the last " } " ), add the code i posted Quote
xR3spawN Posted May 18, 2010 Posted May 18, 2010 symbol : variable Config location: class com.l2jserver.gameserver.model.actor.appearance.ColorNameManager try{ if(con != null) con.close(); } catch(Exception e){ if(Config.DEBUG) e.printStackTrace(); } ^ this is the error i see now when i try to add the code that you told me in the end of the method Quote
B1ggBoss Posted May 18, 2010 Author Posted May 18, 2010 erase this: if(Config.DEBUG) e.printStackTrace(); Quote
TheFamous Posted July 30, 2010 Posted July 30, 2010 System.out.println("ColorNameManager: Loaded " + _pvpColor.size() + " colors for pvp kills!"); System.out.println("ColorNameManager: Loaded " + _pkColor.size() + " colors for pk kills!"); try { if(con != null) con.close(); } catch(Exception e) { } } This is my code after this fix but still i have unclosed connection when i relog a char with pvp/pk color.Can u help me BB ? Ah forgot to ask u say in ur last post "public static void loadValues()" but in the script is "public void loadValues()" is that a problem? Quote
Hiroshima Posted August 12, 2010 Posted August 12, 2010 i got few errors when trying to apply, but might be my fault ;) gj anyway http://zapodaj.net/images/b15dbb095b49.jpg Quote
galou Posted August 19, 2010 Posted August 19, 2010 I try to use it but as i see from posts i have some of the problems.1st how can i remove primary key and second pls write the fix us a code here pls cause i dodn't understans what you try to tell :/ (i don't understand verygood english so i'm a little stupid :P) Quote
haterade Posted August 24, 2010 Posted August 24, 2010 Thx works well.. i do have issue when i shit+click > Edit > add pvp/pk count it shows edit dialog in players client.. //admin command works fine Quote
muutorpe Posted September 21, 2010 Posted September 21, 2010 B1ggBoss Here you can put the diff with the changes already made? (Puedes postear aqui el diff con los cambios ya echos? B1ggBoss eres un monstruo y perdon por eres XDDD. Gracias un autentico genio!) Quote
B1ggBoss Posted September 21, 2010 Author Posted September 21, 2010 look for com.l2jserver.gameserver.model.actor.appearance.ColorNameManager.java and replace it for: /* * This program is free software: you can redistribute it and/or modify it under * the terms of the GNU General Public License as published by the Free Software * Foundation, either version 3 of the License, or (at your option) any later * version. * * This program is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more * details. * * You should have received a copy of the GNU General Public License along with * this program. If not, see <http://www.gnu.org/licenses/>. */ package com.l2jserver.gameserver.model.actor.appearance; import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; import java.util.Set; import com.l2jserver.L2DatabaseFactory; import javolution.util.FastMap; /** * @author BiggBoss */ public class ColorNameManager { private static FastMap<Integer, String> _pvpColor = new FastMap<Integer, String>(); private static FastMap<Integer, String> _pkColor = new FastMap<Integer, String>(); private ColorNameManager() { } public static ColorNameManager getInstance() { return SingletonHolder._cne; } /** * Will load all pvp count with their respective color at server start up * Also will set up the higher pvp/pk count rank for future purposes */ public void loadValues() { Connection con = null; try { _pvpColor.put(0, "FFFFFF"); _pkColor.put(0, "FFFFFF"); con = L2DatabaseFactory.getInstance().getConnection(); PreparedStatement pvpStatement = con.prepareStatement("SELECT * FROM pvp_color_nick WHERE type = ?"); pvpStatement.setString(1, "pvp"); ResultSet pvpRset = pvpStatement.executeQuery(); while(pvpRset.next()) { _pvpColor.put(pvpRset.getInt("pvppk_count"), pvpRset.getString("color")); } pvpRset.close(); pvpStatement.close(); PreparedStatement pkStatement = con.prepareStatement("SELECT * FROM pvp_color_nick WHERE type = ?"); pkStatement.setString(1, "pk"); ResultSet pkRset = pkStatement.executeQuery(); while(pkRset.next()) { _pkColor.put(pkRset.getInt("pvppk_count"), pkRset.getString("color")); } pkRset.close(); pkStatement.close(); } catch(SQLException sqle) { sqle.printStackTrace(); } finally { try { if(con != null) con.close(); } catch(Exception e) { e.printStackTrace(); } } System.out.println("ColorNameManager: Loaded " + _pvpColor.size() + " colors for pvp kills!"); System.out.println("ColorNameManager: Loaded " + _pkColor.size() + " colors for pk kills!"); } /** * Returns a string-representative with the color of the rank * @param kills * @param forPvp * @return a String containing the Hexadecimal color */ public String getColor(int kills, boolean forPvp) { String color = ""; if(forPvp) color = _pvpColor.get(getValueBefore(kills, _pvpColor.keySet())); else color = _pkColor.get(getValueBefore(kills, _pkColor.keySet())); return color; } /** * Will return the value just before the given value contained * in the provided Set of integers * @param value * @param set * @return the value just before the provided one */ private static int getValueBefore(int value, Set<Integer> set) { int counter = 0; for(int i : set) { if(i > counter && value > i) counter = i; } return counter; } static class SingletonHolder { static ColorNameManager _cne = new ColorNameManager(); } } Quote
muutorpe Posted September 21, 2010 Posted September 21, 2010 you are my idol! to others until I guess! (viva Granada !! y la madre que te pario!) Quote
wazadrian Posted September 21, 2010 Posted September 21, 2010 very usefull code i need this THXX for share ;) make more codes like this :) Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.