[Share]Add a skill for PvP's!

[WizZy™]

Leeroy I'm pretty sure you got that code from somewhere in here (Maybe it was because I made it for someone else in the help section lool) and you didn't even bother to change the note,you just copied  / paste.

Thats not funny at all ^^

Nah i didnt.This is my first creation ,NB4L1 helped me with it (ask him if u want) ,just looked at stefoulis15's topic to see how to make it configurable thats all :)

So bad that my first work and some1 thinks it copied.. feels -beep-y.

But yes ,i got the idea from you ,tried to make your code ,but just didnt work at all ,gave me an error.So i asked nb4l1 to help me ,and even if he hates me.. :D he did ,so i`m happy for it ^^

 

EDIT : Thats your code

if(this.getPvpKills() == 1000 && !this.getSkills.contains(yourskillid))
   this.addSkill(skillid, skilllevel, processname 0);

 

Thats mine

			if (getPvpKills() == Config.PVP_CUSTOM_SKILL_P && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)
			  addSkill(SkillTable.getInstance().getInfo(Config.PVP_CUSTOM_SKILL_ID, Config.PVP_CUSTOM_SKILL_LV));

 

You used !this.getSkills.contains - i used another method.

You used a this.addSkill without even selection from where to search it.. so it doesnt work at all.

I dont want problems with you ,just prooving thats its not your copy/paste ,but i got the idea from you ;/

[Horus]

 

You used a this.addSkill without even selection from where to search it.. so it doesnt work at all.

Ofc it doesn't ,it was a non-existing example lool.

Anyway you should check if the player already has the Skill for security purposes, avoiding possible stacking. Thus the "!".

[WizZy™]

if (getPvpKills() == Config.PVP_CUSTOM_SKILL_P && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)

 

It is checked :) But infront of ! that it didnt work ,i used == null ,works too.

 

P.S. I expected a flame from your side ^^

[Horus]

P.S. I expected a flame from your side ^^

Wrong, it isn't flaming, if it was, you would be pissed ^^

Its just noticing when people take someone's work and claim it as their own. But its no problem, grats on your first share ^^

[bauwbas]

Nice work :)

I write a few useful skills:

 

Skill ID: 4408

Max skill LVL: 20

Description: Add HP x12 more.

 

 

Skill ID: 4409

Max skill LVL: 20

Description: Add MP x12 more.

 

 

Skill ID: 4410

Max skill LVL: 22

Description: Ultra strong P. Atk

 

 

Skill ID: 4411

Max skill LVL: 22

Description: Ultra strong M. Atk.

 

Skill ID: 4412

Max skill LVL: 22

Description: Ultra strong P. Def

 

Skill ID: 4413

Max skill LVL: 22

Description: Ultra strong M. Def

 

I think it's be useful :)

[Korlash]

we cant have the travel. a PATCH to execute the script plz

 

thanks!

[nickps1]

gj keep sharing thnx!

[WizZy™]

we cant have the travel. a PATCH to execute the script plz

 

thanks!

 

Its 3 min work.I won't make a patch,sorry.

[Korlash]

-,- give more detail where i put i see 3 IncreasePvPKills; more detail plz

[WizZy™]

-,- give more detail where i put i see 3 IncreasePvPKills; more detail plz

 

Dont post if you dont know a shit of java.Thanks

[Dexter]

doesnt work, its shit

[naturalkillergr]

Dont post if you dont know a shit of java.Thanks

hahahahahahahahhahahaah LOL im with you!:P

but isn't a bad idea to give 3 skills or stats?Dont work for l2jserver F*** I want this!! :P someone please fix my post for the l2jserver :/

[Korlash]

I put here

 

            increasePvpKills();

}

else                                                                        // Target player doesn't have pvp flag set

{

            // check about wars

            if (targetPlayer.getClan() != null && getClan() != null)

            {

                if (getClan().isAtWarWith(targetPlayer.getClanId()))

                {

                    if (targetPlayer.getClan().isAtWarWith(getClanId()))

                    {

                        // 'Both way war' -> 'PvP Kill'

                        increasePvpKills();

 

// INSERT

if (getPvpKills() == Config.PVP_CUSTOM_SKILL_ID && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)

  addSkill(SkillTable.getInstance().getInfo(Config.PVP_CUSTOM_SKILL_ID, Config.PVP_CUSTOM_SKILL_LV));

// END INSERT

 

                        return;

                    }

                }

            }

 

is good?

[naturalkillergr]

I put here

 

            increasePvpKills();

}

else                                                                        // Target player doesn't have pvp flag set

{

            // check about wars

            if (targetPlayer.getClan() != null && getClan() != null)

            {

                if (getClan().isAtWarWith(targetPlayer.getClanId()))

                {

                    if (targetPlayer.getClan().isAtWarWith(getClanId()))

                    {

                        // 'Both way war' -> 'PvP Kill'

                        increasePvpKills();

 

// INSERT

if (getPvpKills() == Config.PVP_CUSTOM_SKILL_ID && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)

  addSkill(SkillTable.getInstance().getInfo(Config.PVP_CUSTOM_SKILL_ID, Config.PVP_CUSTOM_SKILL_LV));

// END INSERT

 

                        return;

                    }

                }

            }

 

is good?

 

its wrong!!

 

IncreasePvPKills; (after this add new line and)

 

if (getPvpKills() == Config.PVP_CUSTOM_SKILL_P && getKnownSkill(Config.PVP_CUSTOM_SKILL_ID) == null && Config.PVP_CUSTOM_SKILL)

  addSkill(SkillTable.getInstance().getInfo(Config.PVP_CUSTOM_SKILL_ID, Config.PVP_CUSTOM_SKILL_LV));

[Korlash]

PLace plz xD