improved

All i get when i try to PK a player is a message, wich comes from masterio pvp rank system: private boolean checkRewardProtections(Pvp pvp) { // if PK mode is disabled: if(!RankPvpSystemConfig.REWARD_FOR_INNOCENT_KILL_ENABLED && _victim.getPvpFlag() == 0 && _victim.getKarma() == 0) { _killer.sendMessage("You can't earn rewards/rank on innocent players!"); return false; } I just get purple nick (like in pvp) the victim dies and the killer stays like he's innocent. I think i could add somewhere here in theese lines full pk/karma code and it should work fine.

Well i could attach my L2PcInstance, but since it has about 20000 lines ... and it weights more kb than i could attach nothing i can do to show you full of it And the code i'v added is: Index: head-src/com/l2jfrozen/gameserver/model/actor/instance/L2PcInstance.java =================================================================== --- head-src/com/l2jfrozen/gameserver/model/actor/instance/L2PcInstance.java (revision 1004) +++ head-src/com/l2jfrozen/gameserver/model/actor/instance/L2PcInstance.java (working copy) @@ -92,6 +92,8 @@ import com.l2jfrozen.gameserver.managers.QuestManager; import com.l2jfrozen.gameserver.managers.SiegeManager; import com.l2jfrozen.gameserver.managers.TownManager; +import com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.RankPvpSystemConfig; +import com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.RankPvpSystemPc; import com.l2jfrozen.gameserver.model.BlockList; import com.l2jfrozen.gameserver.model.FishData; import com.l2jfrozen.gameserver.model.Inventory; @@ -927,6 +929,10 @@ /** The _no duel reason. */ private SystemMessageId _noDuelReason = SystemMessageId.THERE_IS_NO_OPPONENT_TO_RECEIVE_YOUR_CHALLENGE_FOR_A_DUEL; + // Rank PvP System by Masterio + private RankPvpSystemPc _rankPvpSystemPc = new RankPvpSystemPc(); + public RankPvpSystemPc getRankPvpSystemPc(){ return _rankPvpSystemPc; } + /** Boat. */ private boolean _inBoat; @@ -7984,6 +7990,9 @@ */ public void onKillUpdatePvPKarma(L2Character target) { + // Rank PvP System by Masterio + _rankPvpSystemPc.runPvpTask(this, target); + if (target == null) return; @@ -8295,8 +8304,10 @@ return; // Add karma to attacker and increase its PK counter - setPvpKills(getPvpKills() + 1); - + // Rank PvP System by Masterio + if(!RankPvpSystemConfig.LEGAL_COUNTER_ALTT_ENABLED) + setPvpKills(getPvpKills() + 1); + // Increase the kill count for a special hero aura heroConsecutiveKillCount++; Its implemented before the PK system (Pk system starts few hundred lines after it). // Add karma to attacker and increase its PK counter - ignore this - its location is in PVP rules. And after i add this masterio pvp rank system it looks like it overrides (ignores) default l2j pvp system. Even PVP counter in Alt+T is different. So it's in that custom system's code. As i think - i should add pk karma system manually into that new masterio system codes, but i dunno how full of that code should look like since in l2pcinstance there is too many meanings... I'v tried to track it - not succeded. If you really know how to help me, and you really want to - i can send you any of files you need. Believe me - i added that masterio pvp rank system correctly.

Hi, I have faced a problem when installed custom server modification called: Pvp Rank System (By Masterio). I'v managed to fix my errors and problems (since that mod is outdated) and launched it on my server - everything would look fine except 1 thing: InGame: When any kind of Character PKs (Kills innocent) another player - he gets no PK, no karma, no nick color change (as it should be as karma). Ofc it's becouse of this mod i'v added, but maybe any1 could suggest how i could reenable normal PK mode without deleting Masterio's Pvp Rank System? Maybe some1 knows the pk/karma correct code(full)? And where i should add it? Since it looks this mode is ignoring L2PcInstance's karma rules becouse it starts in L2PcInstance (7000+) before it begins (karma rules begins 8000+)... Masterio's system: http://www.maxcheaters.com/topic/141971-rank-pvp-system-389-il-h5/- designed or L2J-Server P.S. Posted this message here and on l2jserver since this pack was based on that server pack, i hope some1 will give me some answers - im desperate

CrazyLethal, i have a question for you: When you kill innocent player (no flag - pink) - do you get karma? Since i don't and i dunno how to enable it

Okay, i fixed my own problem. CrazyLethal: Check if you installed images folder into correct directory. Did you enabled server side images. Did you did not touched the Image buffer Prefix? - it should be 6-7. Didn't you faced errors or warning before compiling when applied patches to your server pack? I mean at Masterio.ImageConverter?

Serioursly?! I'v tried so many different things, recompilations, spent hours soluting this problem and kept getting different errors. And all i had to do is to FIT to my newer revision by changing many of lines (like i did) and do not touch anything else :)... You can lock/delete this topic - i'v did a mistake in config file - i'v enabled 2 different arguments for 1 job, they ignored each other = both turned off. Sorry... did not believed i could act that foolish :D "noob" mistake.

Thank you for your answers. Well Tessa, the script is not only 1 .java... It would be madness to upload all the data here, but you can find it here: http://www.maxcheaters.com/topic/141971-rank-pvp-system-389-il-h5/ Tryskell - yeah i thought about it also since null pointer exception in mysql meaning is that something is pointing to nothing. But while compiling there was no errors, on those lines no error (X meaning) is shown - becouse targetPvpStats is pointing to something since i tried to edit it into something like targetPvpSummary - and i get errors immediatelly (no meaning). Maybe you know where, and how i could track targetPvpStats is going to? I mean where all of the l2j pack meanings comes from? Many packs are releasing newer and newer revisions - many meanings are getting changed into newer ones. Maybe im using the old one wich is outdated? So how to know into what that meaning was changed. Or as you said "Verify the rank for that particular targetPvpStats exists" - from what should i start to track it for verifying?

Hi, I'm sorry if i took wrong section, but since the creator of this code/system is inactive i would like to ask everyone's help. So what I'm talking about? - Masterio Rank PVP System 3.8.9 [iL - H5]. I know its old, so i have made it to fit my owns l2jfrozen latest rev's code. I know you might don't have idea what's that system and how many faults there might be, but i get only 1 problem, maybe you could help me out: When i write ingame .pvpinfo (it should drop me a htm with targets pvp info table) i get GS error: ERROR Client: [Character: Admin - Account: admin - IP: 127.0.0.1] - Failed reading: [C] 38 Say2 ; null java.lang.NullPointerException at com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.RankPvpSystemPvpStatus.preparePage(RankPvpSystemPvpStatus.java:146) at com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.RankPvpSystemPvpStatus.sendPage(RankPvpSystemPvpStatus.java:40) at com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.VoicedCommandHandlerPvpInfo.useVoicedCommand(VoicedCommandHandlerPvpInfo.java :55) at com.l2jfrozen.gameserver.network.clientpackets.Say2.runImpl(Say2.java:507) at com.l2jfrozen.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:77) at com.l2jfrozen.gameserver.network.L2GameClient.run(L2GameClient.java:1213) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) PreparePage: In that direction where the error is starting exists theese lines: (146 line starts at: tb:= "<tr><td width=......) if(RankPvpSystemConfig.RANKS_ENABLED) { tb += "<tr><td width=135 height=22 align=left><font color=ae9977>Rank</font></td><td width=135 height=22 align=left><font color=ffff00>"+targetPvpStats.getRank().getName()+"</font></td></tr>"; tb += "<tr><td width=135 height=22 align=left><font color=ae9977>Rank Points</font></td><td width=135 height=22 align=left><font color=ffa000>"+RankPvpSystemUtil.preparePrice(targetPvpStats.getTotalRankPoints())+"</font></td></tr>"; } SendPage: The second direction: (40 line starts: n.setHtml (pre.....) NpcHtmlMessage n = new NpcHtmlMessage(0); n.setHtml(preparePage(player, playerTarget)); player.sendPacket(n); So, maybe you could tell what can be wrong with it? maybe i dont see something... Any clues? Maybe im searching for the solution not where i should to? P.S. While compiling no errors, when applied this patch manually no missmatches.

I faced problem while typing .pvpinfo ingame - my GS shows me error: ERROR Client: [Character: Admin - Account: admin - IP: 127.0.0.1] - Failed reading: [C] 38 Say2 ; null java.lang.NullPointerException at com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.RankPvpSystemPvpStatus.preparePage(RankPvpSystemPvpStatus.java:146) at com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.RankPvpSystemPvpStatus.sendPage(RankPvpSystemPvpStatus.java:40) at com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.VoicedCommandHandlerPvpInfo.useVoicedCommand(VoicedCommandHandlerPvpInfo.java :55) at com.l2jfrozen.gameserver.network.clientpackets.Say2.runImpl(Say2.java:507) at com.l2jfrozen.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:77) at com.l2jfrozen.gameserver.network.L2GameClient.run(L2GameClient.java:1213) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) Any suggestions or help?

nice