Welcome to MaxCheaters.com

Register now to gain access to all of our features. Once registered and logged in, you will be able to create topics, post replies to existing threads

Code Private Store Sell Issue (All L2J Projects)


Recommended Posts

So here is the thing. There is a check for private sell stores that verifies if each of listed items has a corresponding item template.

I checked most of projects out there and all had the same issue.

 

Here is the code I refer to, nested in TradeList privateStoreBuy() method:

  // Check if requested item is available for manipulation
  L2ItemInstance oldItem = _owner.checkItemManipulation(item.getObjectId(), item.getCount(), "sell");
  if (oldItem == null || !oldItem.isTradeable())
  {
      // Private store sell invalid item - disable it
      lock();
      return false;
  }

  final L2Item template = ItemTable.getInstance().getTemplate(item.getItemId());
  if (template == null)
  {
      continue;
  }
  weight += item.getCount() * template.getWeight();
  if (!template.isStackable())
  {
      slots += item.getCount();
  }
  else if (player.getInventory().getItemByItemId(item.getItemId()) == null)
  {
      slots++;
  }

 

Object 'item', which happens to be an instance of ItemRequest class, is used for retrieving item template and checking whether there are items of the corresponding ID inside buyer's inventory, in the case of stackable items.
What's really interesting is that this object has no Item ID. Private store sell listed items are usually distinct by Object ID instead.

Here is another code I refer to, nested in RequestPrivateStoreBuy class:

@Override
protected void readImpl()
{
	_storePlayerId = readD();
	_count = readD();
	if (_count < 0 || (_count * 12) > _buf.remaining() || _count > Config.MAX_ITEM_IN_PACKET)
	{
		_count = 0;
	}
	_items = new ItemRequest[_count];

	for (int i = 0; i < _count; i++)
	{
		int objectId = readD();
		long count = readD();
		int price = readD();
			
		if (objectId < 1 || count < 1 || count > Integer.MAX_VALUE || price < 0)
		{
			_items = null;
			return;
		}

		_items[i] = new ItemRequest(objectId, (int) count, price);
	}
}

 

And here is the conclusion. Private store sell never performs slot and weight checks at this point, since privateStoreBuy is searching for an item template using 0 as Item ID, therefore skipping rest of code inside loop.

 

Finally, using L2ItemInstance oldItem object for doing those checks, instead of ItemRequest item would probably be enough to solve this issue.

// Check if requested item is available for manipulation
L2ItemInstance oldItem = _owner.checkItemManipulation(item.getObjectId(), item.getCount(), "sell");
if (oldItem == null || !oldItem.isTradeable())
{
	// Private store sell invalid item - disable it
	lock();
	return false;
}

weight += item.getCount() * oldItem.getItem().getWeight();
if (!oldItem.isStackable())
{
	slots += item.getCount();
}
else if (player.getInventory().getItemByItemId(oldItem.getItemId()) == null)
{
	slots++;
}

 

Best regards,

DnR

Edited by DnR

Share this post


Link to post
Share on other sites
  • 2 months later...

When I read that, I wanted to cry!

 

if (template == null)
  {
      continue;
  }

 

Is this inside a loop or someone was trolling when they wrote the above lines of code?

Edited by xFranky
  • Haha 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.