Jump to content
Sign in to follow this  
Tryskell

aCis - Changesets

Recommended Posts

Changeset 373(887)

Datatype organization, Tasks, Clan, Config, Organization, Misc

Datatype organization
    BoatManager
        - Moved to data.manager, javadoc.
    CastleManager
        - Moved to data.manager, extends XMLDocument.
    CastleManorManager
        - Moved to data.manager, extends XMLDocument.
        - Queries are stringified.
        - More uses of Java8 lambdas.
    NpcTable > NpcData
        - Moved to data.xml, extends XMLDocument.
    RaidBossPointsManager > RaidPointManager
        - Rename, moved to data.manager, javadoc, cleanup.
        - Fix the order on ranks calculation. Ty katara.
    Caches
        - Move gameserver.cache to gameserver.data.cache
        - Cleanup HtmCache and CrestCache (adjust filters, javadoc, Logger...).
        - Drop AdminCache adminhandler (2 commands are dropped). Generic //reload type (crests / htm) still works.
        - Invalid crests files are deleted on server loading (being wrong format, wrong length, etc).
        - Fix an issue where old crests files weren't destroyed on crest edition.
        - RequestSetAllyCrest writting style is harmonized using similar packets.
        - RequestSetAllyCrest / RequestSetPledgeCrest / RequestExSetPledgeCrestLarge don't accept data length of 0 (case of crafted packets).
        
Tasks
    - Unify naming convention. Drop the logs.
    - ServerRestart/Shutdown are moved from MON to THU (still 4AM) to emulate maintenance task of retail server. Still off by default.
    - Drop OlympiadSave task (pointless).
    - RaidPointReset task is enhanced on numerous locations :
        - only clan level 5+ are checked (external loop is reduced).
        - ranks are calculated only for the 100 first (internal loop is reduced).
        - addReputationScore is made only on final score and not on every member check (no multiple db operations / packets broadcast for the same clan).
        
Clan
    - Basic cleanup, minor improvements, javadoc.
    - Don't reward clan skills if player is on olympiad mode.
    - _hiredGuards and associated stuff is dropped (not used).
    - RankPrivs class is dropped, it is edited for a simple Integer on the Map.
    - SubPledge class is moved out of Clan, to model.pledge.
    - CLAN_HAS_ALREADY_ESTABLISHED_A_CLAN_ACADEMY SystemMessageId is correctly shown.
    - Table clan_skills loses skill_name column (unused).
    
Config
    - Drop min/max protocol version.
    - Drop few unused loginserver configs.
    - Drop crown/circlet config (see Misc section for explanation).

Organization
    - CharCreateFail / CharDeleteFail use static approach.
    - VehicleAI / VehicleLocation / Vehicle / model.vehicles / VehicleStat > BoatAI / BoatLocation / Boat / model.boat / BoatStat. getVehicle() is merged with getBoat().
    - Implementation of CLogger (C for crappy, obviously). An effort will be done to unify all loggers writting style with time (people will complain if I only commit that).
    
Misc
    - 3158 skillId fix. Ty sahar.
    - Drop ON_KILL event on SummonMinions script (unused).
    - Fix dropMultipleItems method (impacts Q108, Q163, Q354 && Q360), ty x-user.
    - Fix the impossibility to use NPC names for players and pets. Pet name pattern introduces back numbers. Ty RooT.
    - Rework Player.getMemo(), drop getMail() (already handled by MailBBSManager). Probably fix a rare NPE with getMemo().
    - //setname can't reward a name which is already owned (player-based restriction).
    - Unify handlers writting style.
    - setReputationScore() is processed only if clan level is > 4. You can't accumulate CRPs, no matter the action, if your clan isn't at least level 5.
    - Drop the task on JailZone, leading to infinite teleport. Ty smoke121.
    - Fix toggles which aren't supposed to be desactivated while sitting. Ty TreasureHuman.
    - Fix following issues introduced in previous revisions :
        - Revert removeSkill parts to handle back "keep effect" behavior for augmentations / items passive skills.
        - Revert getAllAvailableSkills edit to make enchant working anew with idiot config. To handle deleveling correctly we need correct magicalLevel for every skill.
        - Fix config about invul gm on startup, since //invul drop.
        - Fix Party IOOBE prior to rev 652.
    - Rework crown/circlet item restriction system.
        - Don't delete objects (not retail).
        - Rework Player#checkItemRestriction() which wasn't properly updating character (headgear was still shown).
        - Rename Castle#removeCirclet and removeCircletsAndCrown for checkItemsForMember and checkItemsForClan. Methods are optimized (clan method uses only one connection for all members).
    - Edit ON DUPLICATE KEY UPDATE queries to handle parameters directly on query and not on core.
   

Edited by Tryskell

Share this post


Link to post
Share on other sites

Changeset 374 (920)
    
Datatype organization, Geoengine, Clan, Zones, TaskManagers, Misc
    
Datatype organization
    ZoneManager cleanup
        - Moved to data.manager, extends XMLDocument, full Javadoc documentation.
        - Zone types are now based on file name (automatically set, the dedicated variable is dropped).
        - Few optimizations are done (zone constructor is unique per loaded file, Node 'for' loops are merged, use of IntIntHolder, getRegionX is moved one step higher to avoid to process it on every y call).
    FishingChampionshipManager cleanup
        - javadoc, CLogger, try-with-ressource use, String black magic > StringBuilder, use of addBatch and avoid to create a PreparedStatement per player.
    MovieMakerManager cleanup
        - javadoc, moved to data.manager, all _sequences container uses are enhanced. Don't create a new Sequence object when you update it.

 

Geoengine (was supposed to be part of next revision, but the removeInvalidSkills() hotfix made me commit it)
    - Merge GeoEngine and GeoEnginePathFinding, use CLogger, edit _debugItems CopyOnWriteArrayList for ConcurrentHashMap.newKeySet().
    - Delete PathFinding config.
    
Clan
    - Tweak clan_data datatypes.
    - village_master Clan and Alliance HTMs are harmonized.
    - Extend internal usage of static pledge types, remove "Clan." from existing ones.
    - updateClanMember method is deleted (it was full garbage).
    - Implement "clan leader transfer cancellation" bypass (was written as undone in HTM).
    - Addition of ClanLeaderTransfer task, which fix possible exploits regarding clan transfer. Set on THU 16:55 (17:00 being retail maintenance time, on 2007). Compared to L2J version :
        - If the given newLeaderId doesn't exist on task execution, we reset it to 0 for this clan (no future execution of the task for this clan).

 

Zones
    - BossZones
        - Following zones are deleted : Ant Queen, Orfen (don't exist on L2OFF).
        - Following zones are edited using L2OFF GF values : Sailren, Frintezza, Altar of Sacrifice.
        - Ice Fairy zones have been implemented (3 new zones).
        - Drop EnabledByDefault parameter (unused, I don't see the use since everything is on by default).
        - CopyOnWriteArrayList is replaced for ConcurrentHashMap.newKeySet() for better performance.
        - Players aren't teleported out if summon enters in a BossZone. The summon is still unsummoned. The unsummon part is moved inside the null check to avoid NPE.
    - Zone names classes lose L2 prefix, javadoc is added. Some variables are either deleted (when unused), or renamed.
    - Zaken curse zone is deleted (postIL).
    - Damage zones deal 200 damages per tick, not 100.
    - SpawnZone is renamed SpawnZoneType, to follow ZoneType and CastleZoneType.
    - Addition of ZoneId.BOSS, to easier checks about boss zones.
    - Cleanup htm/admin/zone.htm and related admincommand
    - Fix an exploit using mass resurrect out of BossZone, reviving people inside it. Ty Sahar.

 

TaskManagers
    - ItemsOnGroundTaskManager : merge 2 db connections, use of CLogger.
    - MovementTaskManager : use regular ThreadPool, drop iterator and try/catch.

 

Misc
    - Fix a MySql data truncation error for shadow items with time >= 600. Ty shyr for report.
    - Fix players stop to attack when speaking to a NPC (before they were continuing attacking first target). Ty RooT for the report.
    - Fix archer double damage.
    - Fix skill animation cancellation with ESC.
    - Fix autoattack which was cancelling by itself (for some dudes).
    - Implementation of removeInvalidSkills(). Fix Expertise system, and regular skills downgrade / deletion on player delevel (based on player level + 9).
    - All Clan containers are now concurrent. ConcurrentModificationException were rare, but they were possible.
    - Fix blow formula (CRITICAL_DAMAGE_POS calculation). Ty sahar.
    - Fix NPE for clanless people on siege (3 potential spots, because switch can't accept a null value being passed on it). Ty sahar for the catch.
    - ServerRestart and ServerShutdown tasks are set to THU 17:00. Promise, I stop to edit them.
    - All packets logs concerning exploits/integrity checks are dropped (obviously checks themselves are retained...).
    - Say2
        - Max number of characters is now 100 (from 99). Ty kvex.
        - CRITICAL_ANNOUNCE can be used only by GMs characters.
        - Invalid integrity checks simply return and don't logout player.
    - Move CastleManager initialization higher in the hierarchy (was called indirectly by ItemsOnGroundTaskManager).
    - Fix a NPE using "remove castle" admin command if CastleManorManager is disabled.

 

PS :     - clan_data enabled column datatype is edited from enum to tinyint.
        - SSQZone file is dropped (unused), all zones lose "type" parameter.
        - Sailren zone id is changed to 110011, from 110015 (I ordered zones using L2OFF areadata.txt). Ant Queen && Orfen boss zones are deleted. Scripts are edited to reflect the change.
        - The 3 animation bugs (archer, cancel skill, autoattack) come from rev 338 (exist since 2015). Consider to throw some stones to Hasha.
        - if you use a live server, consider to redesign items.sql table.

Edited by Tryskell

Share this post


Link to post
Share on other sites

Changeset 375 (958)

AIs, Datatype organization, Misc


AIs
    - Intentions
      - Move onInteractionInteract logic on PlayerAI (PlayerAI is the only AI to use INTERACT).
      - Improvement of Desire class.
      - _nextIntention Object is updated and not created everytime anymore, which will save some memory.
      - Fix the NPE on onEvtReadyToAct() due to a lack of synchronization.
      - Add a next intention for INTERACT case if current is CAST, but a lot more cases need such improvements (PICKUP after ATTACK/CAST notably).
   - Attack stance
      - Drop _clientAutoAttacking variable.
      - Rename clientStartAutoAttack() for startAttackStance(), same for stop. Correct use of inheritance / override.
      - A missed hit doesn't start victim attack stance.
      - Drop multiple clientStopAutoAttack() / abortAttack().

Datatype organization
   - ScriptManager > ScriptData. Extends XMLDocument, CLogger, few Javadoc.
   
Community Board
   - Complete cleanup (method names, try-with-ressources, stringified queries, variable renaming, stream uses, CLogger uses)
   - ForumsBBSManager uses ConcurrentHashMap.newKeySet() instead of CopyOnWriteArrayList as container (performance).
   - MailBBSManager uses ConcurrentHashMap instead of HashMap as mails container (fix a potential ConcurrentException).
   - MailBBSManager.sendMail method is optimized.
   
Shutdown
   - Cleanup (use of CLogger, some methods cleanup).
   - ServerStatus.STATUS_DOWN is called when time is <= 60. Before it was called only when the timer was reaching 60, meaning the server status was never updated if a shorter time was set as restart/shutdown time.

Misc
   - Drop COORD_SYNCHRONIZE config.
   - Fix Q232. Ty LordWhiz.
   - Some SummonFriend methods cleanup. Add YOU_MAY_NOT_SUMMON_FROM_YOUR_CURRENT_LOCATION message.
   - Added DebugMovement config.
      - Set to 0 by default, if > 0 it will throw items to track server-side movements. Used as a debug tool.
      - The timer, which is the config, delete objects after X seconds.
   - Move ItemTable#createItem and #destroyItem to ItemInstance. Rename them create and destroyMe.
   - Refresh clan wars on clan deletion (db was correctly handled, but not server variables). Ty Sahar.
   - Tweak subclass change overweight check. Ty Root.
   - Addition of Lightning Strike enchant routes. Ty Sahar.
   - Fix an issue where heroes who took gate passes before taking hero status get the gate passes as if they aren't heroes. Ty Sahar.
   - Weekly maintenance time set to Tuesday and not Thursday (was right in 2008 at least, edited for Wednesday since 2011). Ty Sahar.
   - Handle correctly hero item inventory discard on relog - isHero() being not fed on Player object creation, we have to rely on another source. Ty Sahar.
   - Dismount player on Olympiad teleport. Ty th0r1 for report.
   - Raid points event is every month, not every week. Ty Remix2k18 for report.
   - Fix Q118 && Q123 getSponsor check logic.
   - Fix for double penalty of 3rd class summons. Ty Sahar.
   - Fix a typo in clan full system message. Ty Sahar.
   - Fix a bug causing hero weapons to disappear if relogging with them equipped. Ty Sahar.
   - Fix missing stacktype for song of renewal / wind (can cause a bug : when rebuffing that buffs disappears). Ty Sahar.
   - Fix hero items are not being deleted from player if he is online (player had to relog to have the item deleted). Also, drop a double InventoryUpdate packet send. Ty Sahar.
   - Fix being able to buy items from disallowed NPCs in some situations (like teleporting away and then buying something). Ty Sahar.
   - Fix character gets stuck if trying to interact with an unreachable target more than once. Ty Sahar.
   - Fix issue where if you change target while already running to a certain target, you will still run towards the old target. Ty Sahar.

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.
Sign in to follow this  

  • Recently Browsing   0 members

    No registered users viewing this page.



  • Posts

    • Mob die and  http:// no exp gain
    • First of all, we cannot controll banned users making new accounts. We do what you mentioned junking topics/posts etc from banned members but that doesn't solve anything. And secondly and most important, there are way more serious reasons of bans than flaming, xdem, kara and some other users are banned for flaming, but there are scammers that scam every day and we cannot do a lot of things about it, there are users bulling other members and they're doing it by following rules (doesn't scam, flame, etc) and way more reasons that our forum is what it is right now with zero new shares and zero creativity.   Some users flame or act childish but tbh isn't so much harm than other users bulling and scamming people here. The fact that xdem will write on l2prideful's topics that the server is trash it won't harm his server AT ALL. But users saying the code someone shared is crap, the npc he made is ugly af, etc will harm the people trying to crete new things and share them with everyone.   The point is, we're at a point that we (the staffers) cannot do a lot about these situations, if members won't change their attitude baning them all will end up worst than having them here and won't change a thing. If you remember the old days when tons of people got banned for stupid reasons such as staffer in a similar forum, spaming, flaming, etc (ofc i'm not speaking about scammers) ended up making a dead forum because these were the people that would bring activity into the forum. Now we're trying to bring activity using other ways like hidden content and people still bitching and not following rules at all but no one cares about that, you only care about a harmless post of a guy saying trash a server.
    • My opinion about new accounts > new accounts > new accounts... Update the forum terms of use etc. and type: In case of permanent ban, the member will lose any right to his topics and the administrator / moderators will have all the right to manage your topics.   Then you ban his profile (bye bye feedback's and reputation), junk all his market / server / project topics. (keep all the "useful" stuff that he shared on forum because he will accept the terms of use) and then lets see if he will flame again  
    • HI everyone, i have a small problem with exp. New characters don't get exp. Just exp and drop. Anyone know what's wrong? Thanks
  • Topics

×