Jump to content

An4rchy

Legendary Member
  • Posts

    2,656
  • Credits

  • Joined

  • Last visited

  • Days Won

    26
  • Feedback

    100%

Everything posted by An4rchy

  1. It is possible to write xml files through java :D But in this case sql provides better performance, if i am not mistaken, since on xml you have to search the whole xml for a line, then replace it with the other one you want etc.. It might be able to be done with Streams too, haven't tried it, but it should be working. Btw.... .. Irony :happyforever:
  2. I was just giving advice, didn't mean to insult you... You should try to rewrite/rework it.
  3. You didn't quite understand me.. For example: + if (command.startsWith("five")) + { + LeagueOfElo league = new LeagueOfElo(); + league.vs5reg(player); + player.sendMessage("Registration Successful"); + if (league.vs5.size() == 10) + { + league.pick5v5(); + } + } Here, it is unnecessary to make a new object of LeagueOfElo class, you can change pick5vs5() method and vs5reg() to static, and call them like this: LeagueOfElo.pick5vs5(); LeagueOfElo.vs5reg(); As well for vs5 variable which is static. But my point is that you have not coded it in a good way. There are unused stuff in there and more. You should have created for example an abstract class Match, and other classes afterwards that extend this class, to handle the 5vs5 match, 2vs2 and such. Also in Match class you should have abstract methods that all subclasses should override(must). So instead of this ugly code you would have a nice organized way to handle matches, using inheritance. More stuff: + ii.SetRankPts(ii.getRankPts() + 105); + if (ii.getRankPts() == 100) + { + ii.setRank("Ranked"); + } if (ii.getRankPts() == 100) This line is incorrect, you should check if it's >= 100 and if his rank is not Ranked (!ii.getRank().equals("Ranked")). Also, here: ii.SetRankPts(ii.getRankPts() + 105); I think you meant 15.. Unused/Unneeded stuff: + if (isTurret()) + { + + } + public class Start implements Runnable + { + @Override + public void run() + { + + } + } + + public void createTeam(L2PcInstance a) + { + + }
  4. As i said, your variables are static and you call them through object: LeagueOfElo league = new LeagueOfElo(); + league.vs5reg(player);
  5. Rofl, server name is 'BLACK-HOLE' and site is l2sellknights? :S
  6. Hahaha.. I don't even think == works for String objects.. I've had several errors in the past with this. You need to use equals(another string) or what Setekh said if you want to check that it's equal to nothing. There are more stuff that are done in the wrong way, for example creating a new object of LeagueOfElo class to call a method or a variable(i don't even know if your variables are static and you call them through objects, check below why). Also i noticed that LeagueOfElo class is missing from the diff :S
  7. Wait, if i understood well you can get other players' passwords with this? Or is it just saving your pwd?
  8. Saying it is bugless and stable means nothing. Post working features, what have you reworked, any custom addons(if any exist) etc. That way you won't only have a better presentation of your pack, but it will also attract more people. By the way, don't you think 80 euros is too much? Good luck.
  9. Seems interesting, a simple pvp server. But in order to attract people you should add something special, like special events or features. GL.
  10. This is the wrong section to post that. When you say preconfigured, you mean that you don't have source? (You did not compile your server files with eclipse?)
  11. An4rchy

    ...

    :not bad: :happyforever:
  12. Nice one, i already shared it, but this one works with options. GJ.
  13. Did you check Client Modding section? There is a stickied topic with patched systems from C4 to GOD.
  14. Ok, make 34534 shares that have voiced commands to tp somewhere, with 245232 configs each and with 1235253 of these: int placex; int placey; int placez; placex = Config.FARM_X; placey = Config.FARM_Y; placez = Config.FARM_Z; just to make the code seem bigger. Just TRY to use Maps/arrays.
  15. aCis or Esios. Not a bad server, despite the fact that xping is REALLY boring in the beginning.
  16. y u no change meme? :rage:
  17. Lol. If you wanna use an existing town, just modify L2TownZone.java with what you want(onEnter(), onExit() etc) and make a custom teleporter instance, where it won't allow players to join if they already joined that day(need to make long variable in characters.sql to save the last join time) or if another is in. Also there after someone joins, you have to run the task to tp him away after 2 hours. Also make a check if players restarts to remove him(to avoid bugs).
×
×
  • Create New...